Re: [PATCH v1 1/1] tools: env: use /run to store lockfile
On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: > According this issue https://github.com/ppp-project/ppp/issues/339. > Eventually, the dt-utils changed lock directory to fix missing /var/lock > directory error then make dt-utils can run normally. > > We also have a similar issue with these two utilities fw_printenv and > fw_setenv will failed when the directory /var/lock is non-existent. > > We have a custom linux distribution built with yocto (OpenBMC) that > use systemd and it deprecated the /var/lock directory. > More discussion in systemd/systemd#15668. > > Thus, we sync with community's solution for uboot/tools/env utilities: > The current location /var/lock is considered legacy (at least by systemd). > Just use /run to store the lockfile and append the usual .lock suffix. > > Tested: > Verified /run/lock is now present and fw_printenv can work in OpenBMC. > > Signed-off-by: Tim Lee > Reviewed-by: Tom Rini > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH v1 1/1] tools: env: use /run to store lockfile
On Thu, Feb 23, 2023 at 01:06:20AM +, chl...@nuvoton.com wrote: > Hi Tom, > > Is this commit valuable to merge into u-boot upstream? > Thanks your reviewing, just ping this event friendly. Yes, I'll be putting this in next soon, thanks. > > Best regards, > Tim > > -Original Message- > From: Tom Rini > Sent: Friday, February 10, 2023 11:30 PM > To: Tim Lee > Cc: s...@chromium.org; CS20 CHLi30 ; u-boot@lists.denx.de > Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile > > On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: > > > According this issue https://github.com/ppp-project/ppp/issues/339. > > Eventually, the dt-utils changed lock directory to fix missing > > /var/lock directory error then make dt-utils can run normally. > > > > We also have a similar issue with these two utilities fw_printenv and > > fw_setenv will failed when the directory /var/lock is non-existent. > > > > We have a custom linux distribution built with yocto (OpenBMC) that > > use systemd and it deprecated the /var/lock directory. > > More discussion in systemd/systemd#15668. > > > > Thus, we sync with community's solution for uboot/tools/env utilities: > > The current location /var/lock is considered legacy (at least by systemd). > > Just use /run to store the lockfile and append the usual .lock suffix. > > > > Tested: > > Verified /run/lock is now present and fw_printenv can work in OpenBMC. > > > > Signed-off-by: Tim Lee > > Reviewed-by: Tom Rini > > -- > Tom > > > The privileged confidential information contained in this email is intended > for use only by the addressees as indicated by the original sender of this > email. If you are not the addressee indicated in this email or are not > responsible for delivery of the email to such a person, please kindly reply > to the sender indicating this fact and delete all copies of it from your > computer and network server immediately. Your cooperation is highly > appreciated. It is advised that any unauthorized use of confidential > information of Nuvoton is strictly prohibited; and any information in this > email irrelevant to the official business of Nuvoton shall be deemed as > neither given nor endorsed by Nuvoton. -- Tom signature.asc Description: PGP signature
RE: [PATCH v1 1/1] tools: env: use /run to store lockfile
Hi Tom, Is this commit valuable to merge into u-boot upstream? Thanks your reviewing, just ping this event friendly. Best regards, Tim -Original Message- From: Tom Rini Sent: Friday, February 10, 2023 11:30 PM To: Tim Lee Cc: s...@chromium.org; CS20 CHLi30 ; u-boot@lists.denx.de Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: > According this issue https://github.com/ppp-project/ppp/issues/339. > Eventually, the dt-utils changed lock directory to fix missing > /var/lock directory error then make dt-utils can run normally. > > We also have a similar issue with these two utilities fw_printenv and > fw_setenv will failed when the directory /var/lock is non-existent. > > We have a custom linux distribution built with yocto (OpenBMC) that > use systemd and it deprecated the /var/lock directory. > More discussion in systemd/systemd#15668. > > Thus, we sync with community's solution for uboot/tools/env utilities: > The current location /var/lock is considered legacy (at least by systemd). > Just use /run to store the lockfile and append the usual .lock suffix. > > Tested: > Verified /run/lock is now present and fw_printenv can work in OpenBMC. > > Signed-off-by: Tim Lee Reviewed-by: Tom Rini -- Tom The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Re: [PATCH v1 1/1] tools: env: use /run to store lockfile
On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: > According this issue https://github.com/ppp-project/ppp/issues/339. > Eventually, the dt-utils changed lock directory to fix missing /var/lock > directory error then make dt-utils can run normally. > > We also have a similar issue with these two utilities fw_printenv and > fw_setenv will failed when the directory /var/lock is non-existent. > > We have a custom linux distribution built with yocto (OpenBMC) that > use systemd and it deprecated the /var/lock directory. > More discussion in systemd/systemd#15668. > > Thus, we sync with community's solution for uboot/tools/env utilities: > The current location /var/lock is considered legacy (at least by systemd). > Just use /run to store the lockfile and append the usual .lock suffix. > > Tested: > Verified /run/lock is now present and fw_printenv can work in OpenBMC. > > Signed-off-by: Tim Lee Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature
