Re: [PATCH v2 1/9] usb: dwc3: add dis_enblslpm_quirk

[Frank Wang]

Hi Jagan,

On 2020/5/1 14:53, Jagan Teki wrote:

On Thu, Apr 30, 2020 at 7:47 AM Frank Wang  wrote:

Add a quirk to clear the GUSB2PHYCFG.ENBLSLPM bit, which controls
whether the PHY receives the suspend signal from the controller.

Refer to commit ec791d149bca("usb: dwc3: Add dis_enblslpm_quirk")
in Linux Kernel.

Signed-off-by: Frank Wang 
Reviewed-by: Kever Yang 
---
  drivers/usb/dwc3/core.c | 6 ++
  drivers/usb/dwc3/core.h | 1 +
  include/dwc3-uboot.h| 1 +
  3 files changed, 8 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 4ec3f6df6a..a80e7d54aa 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -395,6 +395,9 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
 if (dwc->dis_u2_susphy_quirk)
 reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;

+   if (dwc->dis_enblslpm_quirk)
+   reg &= ~DWC3_GUSB2PHYCFG_ENBLSLPM;
+

This patch alone seems not building with DWC3
enabled,drivers/usb/dwc3/core.c: In function ‘dwc3_phy_setup’:
drivers/usb/dwc3/core.c:399:11: error: ‘DWC3_GUSB2PHYCFG_ENBLSLPM’
undeclared (first use in this function)
reg &= ~DWC3_GUSB2PHYCFG_ENBLSLPM;

Add this macros to core.h


ACK


Jagan.

Re: [PATCH v2 1/9] usb: dwc3: add dis_enblslpm_quirk

[Jagan Teki]

On Thu, Apr 30, 2020 at 7:47 AM Frank Wang  wrote:
>
> Add a quirk to clear the GUSB2PHYCFG.ENBLSLPM bit, which controls
> whether the PHY receives the suspend signal from the controller.
>
> Refer to commit ec791d149bca("usb: dwc3: Add dis_enblslpm_quirk")
> in Linux Kernel.
>
> Signed-off-by: Frank Wang 
> Reviewed-by: Kever Yang 
> ---
>  drivers/usb/dwc3/core.c | 6 ++
>  drivers/usb/dwc3/core.h | 1 +
>  include/dwc3-uboot.h| 1 +
>  3 files changed, 8 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 4ec3f6df6a..a80e7d54aa 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -395,6 +395,9 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
> if (dwc->dis_u2_susphy_quirk)
> reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
>
> +   if (dwc->dis_enblslpm_quirk)
> +   reg &= ~DWC3_GUSB2PHYCFG_ENBLSLPM;
> +

This patch alone seems not building with DWC3
enabled,drivers/usb/dwc3/core.c: In function ‘dwc3_phy_setup’:
drivers/usb/dwc3/core.c:399:11: error: ‘DWC3_GUSB2PHYCFG_ENBLSLPM’
undeclared (first use in this function)
   reg &= ~DWC3_GUSB2PHYCFG_ENBLSLPM;

Add this macros to core.h

Jagan.