Re: [PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data
> From: Simon Glass > Date: Tue, 28 Mar 2023 08:32:45 +1300 > > Hi Mark, > > On Tue, 28 Mar 2023 at 08:19, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Tue, 28 Mar 2023 08:02:24 +1300 > > > > > > Hi, > > > > > > On Mon, 27 Mar 2023 at 23:47, Konrad Dybcio > > > wrote: > > > > > > > > Mark's and Dzmitry's approaches come down to the same thing.. Let's > > > > unify them by first removing the static keyword from the common file > > > > to allow the variable to be reused, then renaming "reg0" to the more > > > > sensible fw_dtb_pointer coming from the Apple file and finally remove > > > > the mach-apple implementation of this very thing and enable the common > > > > approach in the respective defconfig. > > > > > > > > Only build-tested. > > > > > > > > Signed-off-by: Konrad Dybcio > > > > --- > > > > arch/arm/lib/save_prev_bl_data.c| 14 +++--- > > > > arch/arm/mach-apple/Makefile| 1 - > > > > arch/arm/mach-apple/lowlevel_init.S | 17 - > > > > configs/apple_m1_defconfig | 1 + > > > > 4 files changed, 8 insertions(+), 25 deletions(-) > > > > > > Perhaps we could start using a bloblist (in preparation for the coming > > > Firmware Handoff [1] [2]) to pass information between stages? > > > > We don't have TPL or SPL on these machines, only U-Boot proper. And > > the handoff protocol between m1n1 and U-Boot is defined by [3]. I > > have zero interest in changing that and my guess is that Hector Martin > > feels the same. > > This has nothing to do with TPL, nor SPL. It is a way of communicating > between projects. > > I hope you can both find the time and inclination to support firmware > standardisation as it evolves. > > Projects need to work together. https://xkcd.com/927/
Re: [PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data
Hi Mark, On Tue, 28 Mar 2023 at 08:19, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Tue, 28 Mar 2023 08:02:24 +1300 > > > > Hi, > > > > On Mon, 27 Mar 2023 at 23:47, Konrad Dybcio > > wrote: > > > > > > Mark's and Dzmitry's approaches come down to the same thing.. Let's > > > unify them by first removing the static keyword from the common file > > > to allow the variable to be reused, then renaming "reg0" to the more > > > sensible fw_dtb_pointer coming from the Apple file and finally remove > > > the mach-apple implementation of this very thing and enable the common > > > approach in the respective defconfig. > > > > > > Only build-tested. > > > > > > Signed-off-by: Konrad Dybcio > > > --- > > > arch/arm/lib/save_prev_bl_data.c| 14 +++--- > > > arch/arm/mach-apple/Makefile| 1 - > > > arch/arm/mach-apple/lowlevel_init.S | 17 - > > > configs/apple_m1_defconfig | 1 + > > > 4 files changed, 8 insertions(+), 25 deletions(-) > > > > Perhaps we could start using a bloblist (in preparation for the coming > > Firmware Handoff [1] [2]) to pass information between stages? > > We don't have TPL or SPL on these machines, only U-Boot proper. And > the handoff protocol between m1n1 and U-Boot is defined by [3]. I > have zero interest in changing that and my guess is that Hector Martin > feels the same. This has nothing to do with TPL, nor SPL. It is a way of communicating between projects. I hope you can both find the time and inclination to support firmware standardisation as it evolves. Projects need to work together. Regards, Simon > > Cheers, > > Mark > > [3] https://docs.kernel.org/arm64/booting.html
Re: [PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data
> From: Simon Glass > Date: Tue, 28 Mar 2023 08:02:24 +1300 > > Hi, > > On Mon, 27 Mar 2023 at 23:47, Konrad Dybcio wrote: > > > > Mark's and Dzmitry's approaches come down to the same thing.. Let's > > unify them by first removing the static keyword from the common file > > to allow the variable to be reused, then renaming "reg0" to the more > > sensible fw_dtb_pointer coming from the Apple file and finally remove > > the mach-apple implementation of this very thing and enable the common > > approach in the respective defconfig. > > > > Only build-tested. > > > > Signed-off-by: Konrad Dybcio > > --- > > arch/arm/lib/save_prev_bl_data.c| 14 +++--- > > arch/arm/mach-apple/Makefile| 1 - > > arch/arm/mach-apple/lowlevel_init.S | 17 - > > configs/apple_m1_defconfig | 1 + > > 4 files changed, 8 insertions(+), 25 deletions(-) > > Perhaps we could start using a bloblist (in preparation for the coming > Firmware Handoff [1] [2]) to pass information between stages? We don't have TPL or SPL on these machines, only U-Boot proper. And the handoff protocol between m1n1 and U-Boot is defined by [3]. I have zero interest in changing that and my guess is that Hector Martin feels the same. Cheers, Mark [3] https://docs.kernel.org/arm64/booting.html
Re: [PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data
Hi, On Mon, 27 Mar 2023 at 23:47, Konrad Dybcio wrote: > > Mark's and Dzmitry's approaches come down to the same thing.. Let's > unify them by first removing the static keyword from the common file > to allow the variable to be reused, then renaming "reg0" to the more > sensible fw_dtb_pointer coming from the Apple file and finally remove > the mach-apple implementation of this very thing and enable the common > approach in the respective defconfig. > > Only build-tested. > > Signed-off-by: Konrad Dybcio > --- > arch/arm/lib/save_prev_bl_data.c| 14 +++--- > arch/arm/mach-apple/Makefile| 1 - > arch/arm/mach-apple/lowlevel_init.S | 17 - > configs/apple_m1_defconfig | 1 + > 4 files changed, 8 insertions(+), 25 deletions(-) Perhaps we could start using a bloblist (in preparation for the coming Firmware Handoff [1] [2]) to pass information between stages? Regards, Simon [1] https://github.com/FirmwareHandoff/firmware_handoff [2] https://developer.arm.com/documentation/den0135/a
