Re: [PATCH v3 05/12] dm: Add support for simple-pm-bus
Hi Sean, On Mon, 3 Feb 2020 at 16:15, Sean Anderson wrote: > > > Please can you add a test for this new functionality? > > Should this be separate from test/dm/bus.c? As far as I can tell, that > file tests the concept of busses, and not the bus uclass. Yes it is fine to add a test/dm/simple-bus.c Regards, Simon
Re: [PATCH v3 05/12] dm: Add support for simple-pm-bus
On Mon, Feb 3, 2020 at 4:02 AM Sean Anderson wrote: > > This type of bus is used in Linux to designate busses which have power domains > and/or clocks which need to be enabled before their child devices can be used. > Because power domains are automatically enabled before probing in u-boot, we > just need to enable any clocks present. > > Signed-off-by: Sean Anderson > --- > Changes for v3: > - New > > .../bus/simple-pm-bus.txt | 44 ++ > drivers/core/simple-bus.c | 57 ++- > 2 files changed, 99 insertions(+), 2 deletions(-) > create mode 100644 doc/device-tree-bindings/bus/simple-pm-bus.txt > Reviewed-by: Bin Meng
Re: [PATCH v3 05/12] dm: Add support for simple-pm-bus
> Please can you add a test for this new functionality? Should this be separate from test/dm/bus.c? As far as I can tell, that file tests the concept of busses, and not the bus uclass. --Sean
Re: [PATCH v3 05/12] dm: Add support for simple-pm-bus
Hi Sean, On Sun, 2 Feb 2020 at 13:02, Sean Anderson wrote: > > This type of bus is used in Linux to designate busses which have power domains > and/or clocks which need to be enabled before their child devices can be used. > Because power domains are automatically enabled before probing in u-boot, we > just need to enable any clocks present. > > Signed-off-by: Sean Anderson > --- > Changes for v3: > - New > > .../bus/simple-pm-bus.txt | 44 ++ > drivers/core/simple-bus.c | 57 ++- > 2 files changed, 99 insertions(+), 2 deletions(-) > create mode 100644 doc/device-tree-bindings/bus/simple-pm-bus.txt Please can you add a test for this new functionality? Thanks, Simon
