Re: [PATCH v5 12/17] arm: dts: Introduce j784s4 u-boot dts files

2023-11-30 Thread Manorit Chawdhry
Hi Andrew,

On 09:11-20231130, Andrew Davis wrote:
> On 11/30/23 5:55 AM, Apurva Nandan wrote:
> > Introduce the base dts files needed for u-boot or to augment the linux
> > dtbs for use in the u-boot-spl and u-boot binaries.
> > 
> > Signed-off-by: Hari Nagalla 
> > [ add binman and ddr dtsi files ]
> > Signed-off-by: Neha Malcom Francis 
> > Signed-off-by: Dasnavis Sabiya 
> > Signed-off-by: Apurva Nandan 
> > ---
> >   arch/arm/dts/Makefile|3 +-
> >   arch/arm/dts/k3-j784s4-binman.dtsi   |  346 +
> >   arch/arm/dts/k3-j784s4-ddr-evm-lp4-4266.dtsi | 8757 +
> >   arch/arm/dts/k3-j784s4-ddr.dtsi  | 8858 ++
> >   arch/arm/dts/k3-j784s4-evm-u-boot.dtsi   |   25 +
> >   arch/arm/dts/k3-j784s4-r5-evm.dts|  105 +
> >   6 files changed, 18093 insertions(+), 1 deletion(-)
> >   create mode 100644 arch/arm/dts/k3-j784s4-binman.dtsi
> >   create mode 100644 arch/arm/dts/k3-j784s4-ddr-evm-lp4-4266.dtsi
> >   create mode 100644 arch/arm/dts/k3-j784s4-ddr.dtsi
> >   create mode 100644 arch/arm/dts/k3-j784s4-evm-u-boot.dtsi
> >   create mode 100644 arch/arm/dts/k3-j784s4-r5-evm.dts
> > 
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index 1a63ccba8e..b73f8a9230 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -1409,7 +1409,8 @@ dtb-$(CONFIG_SOC_K3_J721S2) += 
> > k3-am68-sk-base-board.dtb\
> >k3-j721s2-common-proc-board.dtb\
> >k3-j721s2-r5-common-proc-board.dtb
> >   dtb-$(CONFIG_SOC_K3_J784S4) += k3-am69-sk.dtb\
> > -  k3-j784s4-evm.dtb
> > +  k3-j784s4-evm.dtb\
> > +  k3-j784s4-r5-evm.dtb
> >   dtb-$(CONFIG_SOC_K3_AM642) += k3-am642-evm.dtb \
> >   k3-am642-r5-evm.dtb \
> >   k3-am642-sk.dtb \
> > diff --git a/arch/arm/dts/k3-j784s4-binman.dtsi 
> > b/arch/arm/dts/k3-j784s4-binman.dtsi
> > new file mode 100644
> > index 00..7349c2ba38
> > --- /dev/null
> > +++ b/arch/arm/dts/k3-j784s4-binman.dtsi
> > @@ -0,0 +1,346 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> > + */
> > +
> > +#include "k3-binman.dtsi"
> > +
> > +#ifdef CONFIG_TARGET_J784S4_R5_EVM
> > +
> > +_yaml_tifs {
> > +   config = "tifs-rm-cfg.yaml";
> > +};
> > +
> > + {
> > +   tiboot3-j784s4-hs-evm.bin {
> > +   filename = "tiboot3-j784s4-hs-evm.bin";
> > +
> > +   ti-secure-rom {
> > +   content = <_boot_spl>, <_fs_enc>, 
> > <_tifs_cfg>,
> > +   <_dm_cfg>, <_inner_cert>;
> > +   combined;
> > +   dm-data;
> > +   sysfw-inner-cert;
> > +   keyfile = "custMpk.pem";
> > +   sw-rev = <1>;
> > +   content-sbl = <_boot_spl>;
> > +   content-sysfw = <_fs_enc>;
> > +   content-sysfw-data = <_tifs_cfg>;
> > +   content-sysfw-inner-cert = <_inner_cert>;
> > +   content-dm-data = <_dm_cfg>;
> > +   load = <0x41c0>;
> > +   load-sysfw = <0x4>;
> > +   load-sysfw-data = <0x66800>;
> > +   load-dm-data = <0x41c8>;
> > +   };
> > +
> > +   u_boot_spl: u-boot-spl {
> > +   no-expanded;
> > +   };
> > +
> > +   ti_fs_enc: ti-fs-enc.bin {
> > +   filename = "ti-sysfw/ti-fs-firmware-j784s4-hs-enc.bin";
> > +   type = "blob-ext";
> > +   optional;
> > +   };
> > +
> > +   combined_tifs_cfg: combined-tifs-cfg.bin {
> > +   filename = "combined-tifs-cfg.bin";
> > +   type = "blob-ext";
> > +   };
> > +
> > +   sysfw_inner_cert: sysfw-inner-cert {
> > +   filename = "ti-sysfw/ti-fs-firmware-j784s4-hs-cert.bin";
> > +   type = "blob-ext";
> > +   optional;
> > +   };
> > +
> > +   combined_dm_cfg: combined-dm-cfg.bin {
> > +   filename = "combined-dm-cfg.bin";
> > +   type = "blob-ext";
> > +   };
> > +   };
> > +};
> > +
> > + {
> > +   tiboot3-j784s4-hs-fs-evm.bin {
> > +   filename = "tiboot3-j784s4-hs-fs-evm.bin";
> > +
> > +   ti-secure-rom {
> > +   content = <_boot_spl_fs>, <_fs_enc_fs>, 
> > <_tifs_cfg_fs>,
> > +   <_dm_cfg_fs>, <_inner_cert_fs>;
> > +   combined;
> > +   dm-data;
> > +   sysfw-inner-cert;
> > +   keyfile = "custMpk.pem";
> > +   sw-rev = <1>;
> > +   content-sbl = <_boot_spl_fs>;
> > +   content-sysfw = <_fs_enc_fs>;
> > + 

Re: [PATCH v5 12/17] arm: dts: Introduce j784s4 u-boot dts files

2023-11-30 Thread Andrew Davis

On 11/30/23 5:55 AM, Apurva Nandan wrote:

Introduce the base dts files needed for u-boot or to augment the linux
dtbs for use in the u-boot-spl and u-boot binaries.

Signed-off-by: Hari Nagalla 
[ add binman and ddr dtsi files ]
Signed-off-by: Neha Malcom Francis 
Signed-off-by: Dasnavis Sabiya 
Signed-off-by: Apurva Nandan 
---
  arch/arm/dts/Makefile|3 +-
  arch/arm/dts/k3-j784s4-binman.dtsi   |  346 +
  arch/arm/dts/k3-j784s4-ddr-evm-lp4-4266.dtsi | 8757 +
  arch/arm/dts/k3-j784s4-ddr.dtsi  | 8858 ++
  arch/arm/dts/k3-j784s4-evm-u-boot.dtsi   |   25 +
  arch/arm/dts/k3-j784s4-r5-evm.dts|  105 +
  6 files changed, 18093 insertions(+), 1 deletion(-)
  create mode 100644 arch/arm/dts/k3-j784s4-binman.dtsi
  create mode 100644 arch/arm/dts/k3-j784s4-ddr-evm-lp4-4266.dtsi
  create mode 100644 arch/arm/dts/k3-j784s4-ddr.dtsi
  create mode 100644 arch/arm/dts/k3-j784s4-evm-u-boot.dtsi
  create mode 100644 arch/arm/dts/k3-j784s4-r5-evm.dts

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 1a63ccba8e..b73f8a9230 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1409,7 +1409,8 @@ dtb-$(CONFIG_SOC_K3_J721S2) += k3-am68-sk-base-board.dtb\
   k3-j721s2-common-proc-board.dtb\
   k3-j721s2-r5-common-proc-board.dtb
  dtb-$(CONFIG_SOC_K3_J784S4) += k3-am69-sk.dtb\
-  k3-j784s4-evm.dtb
+  k3-j784s4-evm.dtb\
+  k3-j784s4-r5-evm.dtb
  dtb-$(CONFIG_SOC_K3_AM642) += k3-am642-evm.dtb \
  k3-am642-r5-evm.dtb \
  k3-am642-sk.dtb \
diff --git a/arch/arm/dts/k3-j784s4-binman.dtsi 
b/arch/arm/dts/k3-j784s4-binman.dtsi
new file mode 100644
index 00..7349c2ba38
--- /dev/null
+++ b/arch/arm/dts/k3-j784s4-binman.dtsi
@@ -0,0 +1,346 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ */
+
+#include "k3-binman.dtsi"
+
+#ifdef CONFIG_TARGET_J784S4_R5_EVM
+
+_yaml_tifs {
+   config = "tifs-rm-cfg.yaml";
+};
+
+ {
+   tiboot3-j784s4-hs-evm.bin {
+   filename = "tiboot3-j784s4-hs-evm.bin";
+
+   ti-secure-rom {
+   content = <_boot_spl>, <_fs_enc>, 
<_tifs_cfg>,
+   <_dm_cfg>, <_inner_cert>;
+   combined;
+   dm-data;
+   sysfw-inner-cert;
+   keyfile = "custMpk.pem";
+   sw-rev = <1>;
+   content-sbl = <_boot_spl>;
+   content-sysfw = <_fs_enc>;
+   content-sysfw-data = <_tifs_cfg>;
+   content-sysfw-inner-cert = <_inner_cert>;
+   content-dm-data = <_dm_cfg>;
+   load = <0x41c0>;
+   load-sysfw = <0x4>;
+   load-sysfw-data = <0x66800>;
+   load-dm-data = <0x41c8>;
+   };
+
+   u_boot_spl: u-boot-spl {
+   no-expanded;
+   };
+
+   ti_fs_enc: ti-fs-enc.bin {
+   filename = "ti-sysfw/ti-fs-firmware-j784s4-hs-enc.bin";
+   type = "blob-ext";
+   optional;
+   };
+
+   combined_tifs_cfg: combined-tifs-cfg.bin {
+   filename = "combined-tifs-cfg.bin";
+   type = "blob-ext";
+   };
+
+   sysfw_inner_cert: sysfw-inner-cert {
+   filename = "ti-sysfw/ti-fs-firmware-j784s4-hs-cert.bin";
+   type = "blob-ext";
+   optional;
+   };
+
+   combined_dm_cfg: combined-dm-cfg.bin {
+   filename = "combined-dm-cfg.bin";
+   type = "blob-ext";
+   };
+   };
+};
+
+ {
+   tiboot3-j784s4-hs-fs-evm.bin {
+   filename = "tiboot3-j784s4-hs-fs-evm.bin";
+
+   ti-secure-rom {
+   content = <_boot_spl_fs>, <_fs_enc_fs>, 
<_tifs_cfg_fs>,
+   <_dm_cfg_fs>, <_inner_cert_fs>;
+   combined;
+   dm-data;
+   sysfw-inner-cert;
+   keyfile = "custMpk.pem";
+   sw-rev = <1>;
+   content-sbl = <_boot_spl_fs>;
+   content-sysfw = <_fs_enc_fs>;
+   content-sysfw-data = <_tifs_cfg_fs>;
+   content-sysfw-inner-cert = <_inner_cert_fs>;
+   content-dm-data = <_dm_cfg_fs>;
+   load = <0x41c0>;
+   load-sysfw = <0x4>;
+