Re: [PATCH v6 082/102] x86: Move qemu CPU fixup function into its own file
On Sat, Dec 7, 2019 at 12:54 PM Simon Glass wrote: > > This function is specific to qemu so it seems best to keep it separate > from the generic code. > > Move it out to a new file and update the condition to use if() instead of > #ifdef > > Signed-off-by: Simon Glass > --- > > Changes in v6: > - Add back '#ifdef' line to commit message > - Drop incorrect mention of coreboot in qfw_cpu.c > > Changes in v5: > - Add a new patch to move qemu CPU fixup function into its own file > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > arch/x86/cpu/Makefile | 1 + > arch/x86/cpu/mp_init.c | 73 +++--- > arch/x86/cpu/qfw_cpu.c | 73 ++ > include/qfw.h | 8 + > 4 files changed, 87 insertions(+), 68 deletions(-) > create mode 100644 arch/x86/cpu/qfw_cpu.c > Reviewed-by: Bin Meng
Re: [PATCH v6 082/102] x86: Move qemu CPU fixup function into its own file
On Sun, Dec 8, 2019 at 4:03 PM Bin Meng wrote: > > On Sat, Dec 7, 2019 at 12:54 PM Simon Glass wrote: > > > > This function is specific to qemu so it seems best to keep it separate > > from the generic code. > > > > Move it out to a new file and update the condition to use if() instead of > > #ifdef > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v6: > > - Add back '#ifdef' line to commit message > > - Drop incorrect mention of coreboot in qfw_cpu.c > > > > Changes in v5: > > - Add a new patch to move qemu CPU fixup function into its own file > > > > Changes in v4: None > > Changes in v3: None > > Changes in v2: None > > > > arch/x86/cpu/Makefile | 1 + > > arch/x86/cpu/mp_init.c | 73 +++--- > > arch/x86/cpu/qfw_cpu.c | 73 ++ > > include/qfw.h | 8 + > > 4 files changed, 87 insertions(+), 68 deletions(-) > > create mode 100644 arch/x86/cpu/qfw_cpu.c > > > > Reviewed-by: Bin Meng applied to u-boot-x86/next, thanks!
