Re: [U-BOOT TEST HOOKS][PATCH 1/1] qemu-riscv: enable virtio-rng-pci
On 7/31/23 10:48, Bin Meng wrote: On Mon, Jul 31, 2023 at 4:00 PM Leo Liang wrote: On Mon, Jul 31, 2023 at 09:25:07AM +0200, Heinrich Schuchardt wrote: Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should enable CONFIG_DM_RNG in U-Boot. For the EFI unit test for the protocol to succeed a virtio-rng-pci device has to be provided when invoking QEMU. Reported-by: Leo Liang Signed-off-by: Heinrich Schuchardt --- See related patch [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG https://lists.denx.de/pipermail/u-boot/2023-July/525293.html The non-spl defconfigs still don't scan virtio devices automatically. This also needs to be addressed. --- bin/travis-ci/conf.qemu-riscv32_na | 2 +- bin/travis-ci/conf.qemu-riscv32_spl_na | 2 +- bin/travis-ci/conf.qemu-riscv64_na | 2 +- bin/travis-ci/conf.qemu-riscv64_spl_na | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) LGTM! Reviewed-by: Leo Yu-Chi Liang NAK! It should be "virtio-rng-device" Thanks. That resolves the issue with virtio scanning. Best regards Heinrich
Re: [U-BOOT TEST HOOKS][PATCH 1/1] qemu-riscv: enable virtio-rng-pci
On Mon, Jul 31, 2023 at 4:00 PM Leo Liang wrote: > > On Mon, Jul 31, 2023 at 09:25:07AM +0200, Heinrich Schuchardt wrote: > > Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should > > enable CONFIG_DM_RNG in U-Boot. For the EFI unit test for the protocol to > > succeed a virtio-rng-pci device has to be provided when invoking QEMU. > > > > Reported-by: Leo Liang > > Signed-off-by: Heinrich Schuchardt > > --- > > See related patch > > [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG > > https://lists.denx.de/pipermail/u-boot/2023-July/525293.html > > > > The non-spl defconfigs still don't scan virtio devices automatically. This > > also needs to be addressed. > > --- > > bin/travis-ci/conf.qemu-riscv32_na | 2 +- > > bin/travis-ci/conf.qemu-riscv32_spl_na | 2 +- > > bin/travis-ci/conf.qemu-riscv64_na | 2 +- > > bin/travis-ci/conf.qemu-riscv64_spl_na | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > LGTM! > Reviewed-by: Leo Yu-Chi Liang > NAK! It should be "virtio-rng-device" Regards, Bin
Re: [U-BOOT TEST HOOKS][PATCH 1/1] qemu-riscv: enable virtio-rng-pci
On Mon, Jul 31, 2023 at 09:25:07AM +0200, Heinrich Schuchardt wrote: > Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should > enable CONFIG_DM_RNG in U-Boot. For the EFI unit test for the protocol to > succeed a virtio-rng-pci device has to be provided when invoking QEMU. > > Reported-by: Leo Liang > Signed-off-by: Heinrich Schuchardt > --- > See related patch > [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG > https://lists.denx.de/pipermail/u-boot/2023-July/525293.html > > The non-spl defconfigs still don't scan virtio devices automatically. This > also needs to be addressed. > --- > bin/travis-ci/conf.qemu-riscv32_na | 2 +- > bin/travis-ci/conf.qemu-riscv32_spl_na | 2 +- > bin/travis-ci/conf.qemu-riscv64_na | 2 +- > bin/travis-ci/conf.qemu-riscv64_spl_na | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) LGTM! Reviewed-by: Leo Yu-Chi Liang Best regards, Leo
