Re: [U-Boot] [PATCH] Coding Style cleanup
Dear Sanjeev, In message you wrote: > > I was referring to the extra line added by the "+" sign. Ah, I see. Indeed. Strange. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de All repairs tend to destroy the structure, to increase the entropy and disorder of the system. Less and less effort is spent on fixing original design flaws; more and more is spent on fixing flaws intro- duced by earlier fixes. - Fred Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Coding Style cleanup
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, December 19, 2011 9:07 PM > To: Premi, Sanjeev > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] Coding Style cleanup > > Dear "Premi, Sanjeev", > > In message > you wrote: > > > > > @@ -563,6 +556,7 @@ extern unsigned long=20 > > > get_board_sys_clk(unsigned long dummy); > > > "tftp $fdtaddr $tftppath/$fdtfile;" =09 > > > \ > > > "bootm $loadaddr - $fdtaddr" > > > =20 > > > + > > > #define CONFIG_RAMBOOTCOMMAND=09 > > > > This appears to be a stray addition. > > ...which appears to be added by your mailer. I don;t see it in the > patch. I was referring to the extra line added by the "+" sign. [quoting from original patch] @@ -563,6 +556,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); "tftp $fdtaddr $tftppath/$fdtfile;" \ "bootm $loadaddr - $fdtaddr" + #define CONFIG_RAMBOOTCOMMAND \ "setenv bootargs root=/dev/ram rw " \ "console=$consoledev,$baudrate $othbootargs;" \ [/quote] ~sanjeev > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > When the ax entered the forest, the trees said, "The handle is one of > us!" -- Turkish proverb > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Coding Style cleanup
Dear "Premi, Sanjeev", In message you wrote: > > > @@ -563,6 +556,7 @@ extern unsigned long=20 > > get_board_sys_clk(unsigned long dummy); > > "tftp $fdtaddr $tftppath/$fdtfile;" =09 > > \ > > "bootm $loadaddr - $fdtaddr" > > =20 > > + > > #define CONFIG_RAMBOOTCOMMAND =09 > > This appears to be a stray addition. ...which appears to be added by your mailer. I don;t see it in the patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When the ax entered the forest, the trees said, "The handle is one of us!" -- Turkish proverb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Coding Style cleanup
> -Original Message- > From: u-boot-boun...@lists.denx.de > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Wolfgang Denk > Sent: Monday, December 19, 2011 4:41 PM > To: u-boot@lists.denx.de > Subject: [U-Boot] [PATCH] Coding Style cleanup > > Fix trailing white space, indentation by spaces instead of TABs, > excessive blank lines, trailing blank lines. > > Signed-off-by: Wolfgang Denk [snip]...[snip] > @@ -563,6 +556,7 @@ extern unsigned long > get_board_sys_clk(unsigned long dummy); > "tftp $fdtaddr $tftppath/$fdtfile;" > \ > "bootm $loadaddr - $fdtaddr" > > + > #define CONFIG_RAMBOOTCOMMAND This appears to be a stray addition. ~sanjeev [snip]...[snip] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
