Re: [U-Boot] [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

[Stefano Babic]

Hi Philipp,

On 04/01/19 01:18, Philipp Tomsich wrote:
> 
> 
>> On 03.01.2019, at 21:21, Tom Rini > > wrote:
>>
>> On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote:
>>
>>> No point in showing the various DRAM options (right in the top-level
>>> menu for 'Device Drivers') for i.MX8M when configured for a different
>>> architecture.  This wraps an 'if ARCH_IMX8M' around these.
>>>
>>> Signed-off-by: Philipp Tomsich >> >
>>> ---
>>>
>>> drivers/ddr/imx/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig
>>> index 7e06fb2..09a35e5 100644
>>> --- a/drivers/ddr/imx/Kconfig
>>> +++ b/drivers/ddr/imx/Kconfig
>>> @@ -1 +1,3 @@
>>> +if ARCH_IMX8M
>>> source "drivers/ddr/imx/imx8m/Kconfig"
>>> +endif
>>
>> Ugh.  We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on'
>> lines like all of the other DDR controllers.
> 
> Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and
> MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first
> time in a long time)—they just didn’t bother me as much as this one ;-)
> 
> If I remember to do so, I’ll submit patches for those two as well ...
> 

Nevertheless, and I agree your patch is working, too, the common way in
Kconfig is to add suitable "depends on" as suggested by Tom and as we
have on other DDR drivers instead of a global #if ARCH_IMX8m (I agree
that for an user does not change a lot, by the way).

Best regards,
Stefano


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

[Peng Fan]

> -Original Message-
> From: Philipp Tomsich [mailto:philipp.toms...@theobroma-systems.com]
> Sent: 2019年1月4日 1:48
> To: u-boot@lists.denx.de
> Cc: Tom Rini ; Philipp Tomsich
> ; Peng Fan ;
> Masahiro Yamada 
> Subject: [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for
> everyone
> 
> No point in showing the various DRAM options (right in the top-level menu for
> 'Device Drivers') for i.MX8M when configured for a different architecture.
> This wraps an 'if ARCH_IMX8M' around these.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
>  drivers/ddr/imx/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig index
> 7e06fb2..09a35e5 100644
> --- a/drivers/ddr/imx/Kconfig
> +++ b/drivers/ddr/imx/Kconfig
> @@ -1 +1,3 @@
> +if ARCH_IMX8M
>  source "drivers/ddr/imx/imx8m/Kconfig"
> +endif

Thanks. Reviewed-by: Peng Fan 

> --
> 2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

[Philipp Tomsich]

> On 03.01.2019, at 21:21, Tom Rini  wrote:
> 
> On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote:
> 
>> No point in showing the various DRAM options (right in the top-level
>> menu for 'Device Drivers') for i.MX8M when configured for a different
>> architecture.  This wraps an 'if ARCH_IMX8M' around these.
>> 
>> Signed-off-by: Philipp Tomsich 
>> ---
>> 
>> drivers/ddr/imx/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig
>> index 7e06fb2..09a35e5 100644
>> --- a/drivers/ddr/imx/Kconfig
>> +++ b/drivers/ddr/imx/Kconfig
>> @@ -1 +1,3 @@
>> +if ARCH_IMX8M
>> source "drivers/ddr/imx/imx8m/Kconfig"
>> +endif
> 
> Ugh.  We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on'
> lines like all of the other DDR controllers.

Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and
MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first
time in a long time)—they just didn’t bother me as much as this one ;-)

If I remember to do so, I’ll submit patches for those two as well ...

Cheers,
Phil.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

[Tom Rini]

On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote:

> No point in showing the various DRAM options (right in the top-level
> menu for 'Device Drivers') for i.MX8M when configured for a different
> architecture.  This wraps an 'if ARCH_IMX8M' around these.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
>  drivers/ddr/imx/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig
> index 7e06fb2..09a35e5 100644
> --- a/drivers/ddr/imx/Kconfig
> +++ b/drivers/ddr/imx/Kconfig
> @@ -1 +1,3 @@
> +if ARCH_IMX8M
>  source "drivers/ddr/imx/imx8m/Kconfig"
> +endif

Ugh.  We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on'
lines like all of the other DDR controllers.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot