Re: [U-Boot] [PATCH] LZO: Add a LZO compression feature

2010-10-01 Thread Wolfgang Denk
Dear Donggeun Kim,

In message 4ca5b732.3030...@samsung.com you wrote:
 In some case, LZO compression function is needed in U-Boot.

Can you please explain what use cases you have in mind?

So far, we provide only uncompression functions, and it seems nobody
ever needed compression inside U-Boot yet?

If we really add this, then please make it separately configurable, so
that not everybody who wants LZO decompression always has to accept
the compression functions, too.


 This patch supports LZO compression feature which is originated from Linux 
 kernel.
...
 --- /dev/null
 +++ b/lib/lzo/lzo1x_compress.c
 @@ -0,0 +1,219 @@
 +/*
 + *  LZO1X Compressor from MiniLZO
 + *
 + *  Copyright (C) 1996-2005 Markus F.X.J. Oberhumer mar...@oberhumer.com
 + *
 + *  The full LZO package can be found at:
 + *  http://www.oberhumer.com/opensource/lzo/
 + *
 + *  Changed for kernel use by:
 + *  Nitin Gupta nitingupta...@gmail.com
 + *  Richard Purdie rpur...@openedhand.com
 + */

What exactly are the licensing terms?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Am I your nanny? The kernel is there to support  user  programs,  but
it's a _resource_ handler, not a baby feeder. - Linus Torvalds in
  pine.lnx.3.91.960425074845.22041c-100...@linux.cs.helsinki.fi
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] LZO: Add a LZO compression feature

2010-10-01 Thread Kyungmin Park
Hi Wolfgang.

On Fri, Oct 1, 2010 at 7:53 PM, Wolfgang Denk w...@denx.de wrote:
 Dear Donggeun Kim,

 In message 4ca5b732.3030...@samsung.com you wrote:
 In some case, LZO compression function is needed in U-Boot.

 Can you please explain what use cases you have in mind?

There's request from other team. They want to transfer the binary but
it's written as ubifs filesystem.
So download the binary to RAM and then mkfs.ubifs at this address and
ubinize it finally.
Then write it to flash.
When mkfs.ubifs, it requires it.

 So far, we provide only uncompression functions, and it seems nobody
 ever needed compression inside U-Boot yet?

 If we really add this, then please make it separately configurable, so
 that not everybody who wants LZO decompression always has to accept
 the compression functions, too.
Agree, It will use the CONFIG_LZO_COMPRESSION


 This patch supports LZO compression feature which is originated from Linux 
 kernel.
 ...
 --- /dev/null
 +++ b/lib/lzo/lzo1x_compress.c
 @@ -0,0 +1,219 @@
 +/*
 + *  LZO1X Compressor from MiniLZO
 + *
 + *  Copyright (C) 1996-2005 Markus F.X.J. Oberhumer mar...@oberhumer.com
 + *
 + *  The full LZO package can be found at:
 + *  http://www.oberhumer.com/opensource/lzo/
 + *
 + *  Changed for kernel use by:
 + *  Nitin Gupta nitingupta...@gmail.com
 + *  Richard Purdie rpur...@openedhand.com
 + */

 What exactly are the licensing terms?
It's from kernel code. do you want to add the GPL v2?

Thank you,
Kyungmin Park

 Best regards,

 Wolfgang Denk

 --
 DENX Software Engineering GmbH,     MD: Wolfgang Denk  Detlev Zundel
 HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
 Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
 Am I your nanny? The kernel is there to support  user  programs,  but
 it's a _resource_ handler, not a baby feeder.     - Linus Torvalds in
      pine.lnx.3.91.960425074845.22041c-100...@linux.cs.helsinki.fi
 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] LZO: Add a LZO compression feature

2010-10-01 Thread Wolfgang Denk
Dear Kyungmin Park,

In message aanlkti=hnkqfunozmrwgg_=ghjor6efigwwukggzc...@mail.gmail.com you 
wrote:
 
 There's request from other team. They want to transfer the binary but
 it's written as ubifs filesystem.
 So download the binary to RAM and then mkfs.ubifs at this address and
 ubinize it finally.
 Then write it to flash.
 When mkfs.ubifs, it requires it.

You mean you want to add both support for ubinize and mkfs.ubifs to
U-Boot?  Would it not make more sense to boot a (minimal) Linux kernel
for that purposes?

  What exactly are the licensing terms?
 It's from kernel code. do you want to add the GPL v2?

I think we should do that (if that's what the original code is
released under; I'm not so certain), to make things clear.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There's always been Tower of Babel sort of  bickering  inside  Unix,
but  this  is the most extreme form ever. This means at least several
years of confusion. - Bill Gates, founder and chairman of Microsoft,
about the Open Systems Foundation
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] LZO: Add a LZO compression feature

2010-10-01 Thread Kyungmin Park
On Fri, Oct 1, 2010 at 10:54 PM, Wolfgang Denk w...@denx.de wrote:
 Dear Kyungmin Park,

 In message aanlkti=hnkqfunozmrwgg_=ghjor6efigwwukggzc...@mail.gmail.com you 
 wrote:

 There's request from other team. They want to transfer the binary but
 it's written as ubifs filesystem.
 So download the binary to RAM and then mkfs.ubifs at this address and
 ubinize it finally.
 Then write it to flash.
 When mkfs.ubifs, it requires it.

 You mean you want to add both support for ubinize and mkfs.ubifs to
 U-Boot?  Would it not make more sense to boot a (minimal) Linux kernel
 for that purposes?
Umm it's maybe difficult. This team don't use the linux and don't have
linux environment.
Only generate binary it and remaining job are done by each product team.
The even worse there's no console when they are use it.

Enter the download mode and send the image to target.

Of course this method is not visible to their. and no behavior changed
to our environment.

Thank you,
Kyungmin Park

  What exactly are the licensing terms?
 It's from kernel code. do you want to add the GPL v2?

 I think we should do that (if that's what the original code is
 released under; I'm not so certain), to make things clear.
Then just add the It's from linux kernel

 Best regards,

 Wolfgang Denk

 --
 DENX Software Engineering GmbH,     MD: Wolfgang Denk  Detlev Zundel
 HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
 Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
 There's always been Tower of Babel sort of  bickering  inside  Unix,
 but  this  is the most extreme form ever. This means at least several
 years of confusion. - Bill Gates, founder and chairman of Microsoft,
 about the Open Systems Foundation
 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] LZO: Add a LZO compression feature

2010-10-01 Thread Mike Frysinger
On Fri, Oct 1, 2010 at 10:11 AM, Kyungmin Park wrote:
 On Fri, Oct 1, 2010 at 10:54 PM, Wolfgang Denk wrote:
 Kyungmin Park wrote:
 There's request from other team. They want to transfer the binary but
 it's written as ubifs filesystem.
 So download the binary to RAM and then mkfs.ubifs at this address and
 ubinize it finally.
 Then write it to flash.
 When mkfs.ubifs, it requires it.

 You mean you want to add both support for ubinize and mkfs.ubifs to
 U-Boot?  Would it not make more sense to boot a (minimal) Linux kernel
 for that purposes?

 Umm it's maybe difficult. This team don't use the linux and don't have
 linux environment.
 Only generate binary it and remaining job are done by each product team.
 The even worse there's no console when they are use it.

 Enter the download mode and send the image to target.

so why dont you generate the ubifs on the development system and just
transfer the image to the board ?
-mike
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot