Re: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Hello Wolfgang, Wolfgang Denk wrote: In message 4b175f3f.2060...@denx.de you wrote: Applied, thanks. Heiko, I hope this is OK with you. Hmm.. not really, my last comment on this was: Ouch, sorry. No probelm. http://lists.denx.de/pipermail/u-boot/2009-November/064245.html I missed that, sorry. This was in another thread, not connected with the patch. I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE. What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?] I actually vote for removing the code, so I sent soon a patch, which fixes the comment. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Dear Heiko, In message 4b175f3f.2060...@denx.de you wrote: Applied, thanks. Heiko, I hope this is OK with you. Hmm.. not really, my last comment on this was: Ouch, sorry. http://lists.denx.de/pipermail/u-boot/2009-November/064245.html I missed that, sorry. This was in another thread, not connected with the patch. I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE. What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Der Irrtum wiederholt sich immerfort in der Tat. Deshalb muß man das Wahre unermüdlich in Worten wiederholen. - Goethe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Dear Pratap Chandu, In message 1258034305-31770-1-git-send-email-pratap.r...@gmail.com you wrote: There is some dead code enclosed by #if 0 #endif in the file common/cmd_i2c.c This patch removes the dead code. Signed-off-by: Pratap Chandu pratap.r...@gmail.com --- common/cmd_i2c.c |8 1 files changed, 0 insertions(+), 8 deletions(-) Applied, thanks. Heiko, I hope this is OK with you. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de COMPONENT EQUIVALENCY NOTICE: The Subatomic Particles (Electrons, Protons, etc.) Comprising This Product Are Exactly the Same in Every Measurable Respect as Those Used in the Products of Other Manufactu- rers, and No Claim to the Contrary May Legitimately Be Expressed or Implied. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Hello Wolfgang, Wolfgang Denk schrieb: Dear Pratap Chandu, In message 1258034305-31770-1-git-send-email-pratap.r...@gmail.com you wrote: There is some dead code enclosed by #if 0 #endif in the file common/cmd_i2c.c This patch removes the dead code. Signed-off-by: Pratap Chandu pratap.r...@gmail.com --- common/cmd_i2c.c |8 1 files changed, 0 insertions(+), 8 deletions(-) Applied, thanks. Heiko, I hope this is OK with you. Hmm.. not really, my last comment on this was: http://lists.denx.de/pipermail/u-boot/2009-November/064245.html I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
