Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On May 24, 2010, at 3:10 PM, Timur Tabi wrote: > The device tree (fdt) must always exist in within the bootmap (usually the > first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an > LMB region in the bootmap and copy the fdt into that region. It will also > increase the size of the fdt. > > If the fdt is already in the bootmap, then previously the memory was just > reserved. There was no contingency if the reservation failed, however. > > By always allocating an lmb region and copying/resizing the fdt into that > region, the code is simplified and the memory region is always allocated > properly. > > Also change the types of some variables to avoid some typecasts. > > Signed-off-by: Timur Tabi > --- > common/image.c | 83 +++- > 1 files changed, 28 insertions(+), 55 deletions(-) applied to 85xx - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On Mon, May 24, 2010 at 3:10 PM, Timur Tabi wrote: > The device tree (fdt) must always exist in within the bootmap (usually the > first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an > LMB region in the bootmap and copy the fdt into that region. It will also > increase the size of the fdt. > > If the fdt is already in the bootmap, then previously the memory was just > reserved. There was no contingency if the reservation failed, however. > > By always allocating an lmb region and copying/resizing the fdt into that > region, the code is simplified and the memory region is always allocated > properly. > > Also change the types of some variables to avoid some typecasts. > > Signed-off-by: Timur Tabi > --- Why was this patch not merged into U-Boot during the merge window? I've been waiting since May for this patch to be applied, and it's been tested and verified. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On Fri, Aug 20, 2010 at 2:12 PM, Timur Tabi wrote: > On Sat, Aug 7, 2010 at 6:36 PM, Wolfgang Denk wrote: > >> I would like to see any ACK or Tested-by: from actual users of this code. > > Kumar, who should ack this patch? This patch has been tested and acked by Ira Synder: http://lists.denx.de/pipermail/u-boot/2010-September/076946.html Kumar, please apply this patch for -next -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On Sat, Aug 7, 2010 at 6:36 PM, Wolfgang Denk wrote: > I would like to see any ACK or Tested-by: from actual users of this code. Kumar, who should ack this patch? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
Dear Kumar, In message <20100802205706.56072d3c...@gemini.denx.de> I wrote: > > In message you > wrote: > > > > As this isn't to 8xxx related code I'm NOT going to apply it. Wolfgang > > should. > > Which boards except 8xxx actually use that code? I mean, which boards > can be used for testing? > > [I don't remember any Tested-by: messages ?] Ping... I would like to see any ACK or Tested-by: from actual users of this code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Pig: An animal (Porcus omnivorous) closely allied to the human race by the splendor and vivacity of its appetite, which, however, is in- ferior in scope, for it balks at pig.- Ambrose Bierce ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
Dear Kumar Gala, In message you wrote: > > As this isn't to 8xxx related code I'm NOT going to apply it. Wolfgang > should. Which boards except 8xxx actually use that code? I mean, which boards can be used for testing? [I don't remember any Tested-by: messages ?] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are always alternatives. -- Spock, "The Galileo Seven", stardate 2822.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On Aug 2, 2010, at 10:43 AM, Timur Tabi wrote: > Kumar, do you have any issues with this patch? I submitted it in May, > but you never picked it up. > > On Mon, May 24, 2010 at 3:10 PM, Timur Tabi wrote: >> The device tree (fdt) must always exist in within the bootmap (usually the >> first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an >> LMB region in the bootmap and copy the fdt into that region. It will also >> increase the size of the fdt. >> >> If the fdt is already in the bootmap, then previously the memory was just >> reserved. There was no contingency if the reservation failed, however. >> >> By always allocating an lmb region and copying/resizing the fdt into that >> region, the code is simplified and the memory region is always allocated >> properly. >> >> Also change the types of some variables to avoid some typecasts. >> >> Signed-off-by: Timur Tabi > > -- > Timur Tabi > Linux kernel developer at Freescale As this isn't to 8xxx related code I'm NOT going to apply it. Wolfgang should. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
Kumar, do you have any issues with this patch? I submitted it in May, but you never picked it up. On Mon, May 24, 2010 at 3:10 PM, Timur Tabi wrote: > The device tree (fdt) must always exist in within the bootmap (usually the > first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an > LMB region in the bootmap and copy the fdt into that region. It will also > increase the size of the fdt. > > If the fdt is already in the bootmap, then previously the memory was just > reserved. There was no contingency if the reservation failed, however. > > By always allocating an lmb region and copying/resizing the fdt into that > region, the code is simplified and the memory region is always allocated > properly. > > Also change the types of some variables to avoid some typecasts. > > Signed-off-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
On Jul 17, 2010, at 10:17 PM, "Jerry Van Baren" wrote: >> Signed-off-by: Timur Tabi > ^ > Need a space in your SOB line? That's your mailer, not me. Check the archive -- my message is correct. > I assume this is a "live" patch, and replaces the patch with the subject > "libfdt: make fdt_increase_size() available to everyone". It looks > like a good improvement to me and nobody threw any stones at it, so... The two patches are not related. The other one rejected anyway. > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
Hi Timur, On 05/24/2010 04:10 PM, Timur Tabi wrote: > The device tree (fdt) must always exist in within the bootmap (usually the > first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an > LMB region in the bootmap and copy the fdt into that region. It will also > increase the size of the fdt. > > If the fdt is already in the bootmap, then previously the memory was just > reserved. There was no contingency if the reservation failed, however. > > By always allocating an lmb region and copying/resizing the fdt into that > region, the code is simplified and the memory region is always allocated > properly. > > Also change the types of some variables to avoid some typecasts. > > Signed-off-by: Timur Tabi ^ Need a space in your SOB line? > --- > common/image.c | 83 > +++- > 1 files changed, 28 insertions(+), 55 deletions(-) I assume this is a "live" patch, and replaces the patch with the subject "libfdt: make fdt_increase_size() available to everyone". It looks like a good improvement to me and nobody threw any stones at it, so... Acked-by: Gerald Van Baren [snip] Best regards, gvb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
