Re: [U-Boot] [PATCH] mmc: bcm2835_sdhci: Restore original delay behavior
On Saturday, June 20, 2015 at 01:36:58 PM, Jakub Kiciński wrote: > On Fri, 19 Jun 2015 23:39:41 +0200, Marek Vasut wrote: > > Patch 33fe2fb8df01647f97a7bce96a1c7781a7f6d253 titled > > "mmc: bcm283x: Remove get_timer_us() from mmc driver" > > incorrectly replaced ad-hoc get_timer_us() function > > with a plain get_timer(). The get_timer() operates in > > mSec units instead of uSec though, which caused very > > slow operation of the driver. > > > > Restore the original behavior of the driver, but avoid > > get_timer_us() and use timer_get_us() instead. The later > > is part of the standard API. > > > > Signed-off-by: Marek Vasut > > Cc: Jakub Kiciński > > Cc: Stephen Warren > > Tested-by: Jakub Kicinski Thanks :) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: bcm2835_sdhci: Restore original delay behavior
On Fri, 19 Jun 2015 23:39:41 +0200, Marek Vasut wrote: > Patch 33fe2fb8df01647f97a7bce96a1c7781a7f6d253 titled > "mmc: bcm283x: Remove get_timer_us() from mmc driver" > incorrectly replaced ad-hoc get_timer_us() function > with a plain get_timer(). The get_timer() operates in > mSec units instead of uSec though, which caused very > slow operation of the driver. > > Restore the original behavior of the driver, but avoid > get_timer_us() and use timer_get_us() instead. The later > is part of the standard API. > > Signed-off-by: Marek Vasut > Cc: Jakub Kiciński > Cc: Stephen Warren Tested-by: Jakub Kicinski ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: bcm2835_sdhci: Restore original delay behavior
On Friday, June 19, 2015 at 11:39:41 PM, Marek Vasut wrote: > Patch 33fe2fb8df01647f97a7bce96a1c7781a7f6d253 titled > "mmc: bcm283x: Remove get_timer_us() from mmc driver" > incorrectly replaced ad-hoc get_timer_us() function > with a plain get_timer(). The get_timer() operates in > mSec units instead of uSec though, which caused very > slow operation of the driver. > > Restore the original behavior of the driver, but avoid > get_timer_us() and use timer_get_us() instead. The later > is part of the standard API. > > Signed-off-by: Marek Vasut > Cc: Jakub Kiciński > Cc: Stephen Warren Stephen/Jakub, can you please test this one one more time ? If it works, it'd be nice if this could be applied to current relase please. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
