Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On Wed, Sep 30, 2015 at 9:12 AM, Jacob Stifflerwrote: > The net_boot_file_name buffer is used as storage for the bootfilename > command line argument to network boot commands such as tftp and nfs. > > Increase the size of this buffer to 1024 bytes as the current size of > 128 bytes is restrictive for arbitrary paths on the server. > > Signed-off-by: Jacob Stiffler Applied to u-boot-net/master, thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
Hi Jacob, On Wed, Sep 30, 2015 at 9:12 AM, Jacob Stifflerwrote: > The net_boot_file_name buffer is used as storage for the bootfilename > command line argument to network boot commands such as tftp and nfs. > > Increase the size of this buffer to 1024 bytes as the current size of > 128 bytes is restrictive for arbitrary paths on the server. > > Signed-off-by: Jacob Stiffler Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On Sat, Oct 3, 2015 at 11:13 AM, Stefan Bruenswrote: > On Thursday 01 October 2015 16:27:11 Wolfgang Denk wrote: >> Dear Jacob, >> >> In message <1443622325-30792-1-git-send-email-j-stiff...@ti.com> you wrote: >> > The net_boot_file_name buffer is used as storage for the bootfilename >> > command line argument to network boot commands such as tftp and nfs. >> > >> > Increase the size of this buffer to 1024 bytes as the current size of >> > 128 bytes is restrictive for arbitrary paths on the server. >> >> According to RFC 2131, the boot file name has a fixed size of 128 >> octets. > > You can also put the file name into Option 67, which results in a length limit > of 255 octets (DHCP option length limit). > > I sent patches with several DHCP enhancements, including Option 67 support, to > the ML a few weeks ago. Has those patches been applied? otherwise it would be good to rebase it and send them again as we are close of release and merge window will soon open. The intent of this patch is not to increase the size of the path for bootp, but to increase the size of the path for nfs and tftp. The "net_boot_file_name" is a common global variable used for all network commands which load files into memory, and is basically temporary storage. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On Thursday 01 October 2015 16:27:11 Wolfgang Denk wrote: > Dear Jacob, > > In message <1443622325-30792-1-git-send-email-j-stiff...@ti.com> you wrote: > > The net_boot_file_name buffer is used as storage for the bootfilename > > command line argument to network boot commands such as tftp and nfs. > > > > Increase the size of this buffer to 1024 bytes as the current size of > > 128 bytes is restrictive for arbitrary paths on the server. > > According to RFC 2131, the boot file name has a fixed size of 128 > octets. You can also put the file name into Option 67, which results in a length limit of 255 octets (DHCP option length limit). I sent patches with several DHCP enhancements, including Option 67 support, to the ML a few weeks ago. Kind regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On Sat, Oct 3, 2015 at 11:13 AM, Stefan Bruenswrote: > On Thursday 01 October 2015 16:27:11 Wolfgang Denk wrote: >> Dear Jacob, >> >> In message <1443622325-30792-1-git-send-email-j-stiff...@ti.com> you wrote: >> > The net_boot_file_name buffer is used as storage for the bootfilename >> > command line argument to network boot commands such as tftp and nfs. >> > >> > Increase the size of this buffer to 1024 bytes as the current size of >> > 128 bytes is restrictive for arbitrary paths on the server. >> >> According to RFC 2131, the boot file name has a fixed size of 128 >> octets. > > You can also put the file name into Option 67, which results in a length limit > of 255 octets (DHCP option length limit). > > I sent patches with several DHCP enhancements, including Option 67 support, to > the ML a few weeks ago. Has those patches been applied? otherwise it would be good to rebase it and send them again as we are close of release and merge window will soon open. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
Dear Jacob, In message <1443622325-30792-1-git-send-email-j-stiff...@ti.com> you wrote: > The net_boot_file_name buffer is used as storage for the bootfilename > command line argument to network boot commands such as tftp and nfs. > > Increase the size of this buffer to 1024 bytes as the current size of > 128 bytes is restrictive for arbitrary paths on the server. According to RFC 2131, the boot file name has a fixed size of 128 octets. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober! - Terry Pratchett, _Men at Arms_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On 10/1/2015 10:27 AM, Wolfgang Denk wrote: Dear Jacob, In message <1443622325-30792-1-git-send-email-j-stiff...@ti.com> you wrote: The net_boot_file_name buffer is used as storage for the bootfilename command line argument to network boot commands such as tftp and nfs. Increase the size of this buffer to 1024 bytes as the current size of 128 bytes is restrictive for arbitrary paths on the server. According to RFC 2131, the boot file name has a fixed size of 128 octets. Wolfgang, Yes. However, the global "net_boot_file_name" is not only used for BOOTP, but also for NFS and TFTP. "net_boot_file_name" appears to be temporary storage to supply the file path to arbitrary protocols from the command line arguments. The "file" field in the bootp message is fixed at 128 octets in the "bootp_hdr" structure. The contents of "net_boot_file_name" are read or written using the standard "strncopy()" or the similar "copy_filename()", so there should be any issue with respect to memory leaks. Thank you, Jacob Stiffler Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
Dear Jacob, In message <560d6de3.8070...@ti.com> you wrote: > > Yes. However, the global "net_boot_file_name" is not only used for > BOOTP, but also for NFS and TFTP. > > "net_boot_file_name" appears to be temporary storage to supply the file > path to arbitrary protocols from the command line arguments. I see. > The "file" field in the bootp message is fixed at 128 octets in the > "bootp_hdr" structure. > > The contents of "net_boot_file_name" are read or written using the > standard "strncopy()" or the similar "copy_filename()", so there should > be any issue with respect to memory leaks. I guess you mean there should NOT be any issue? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Anarchy may not be the best form of government, but it's better than no government at all. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
On 10/1/2015 4:07 PM, Wolfgang Denk wrote: Dear Jacob, In message <560d6de3.8070...@ti.com> you wrote: Yes. However, the global "net_boot_file_name" is not only used for BOOTP, but also for NFS and TFTP. "net_boot_file_name" appears to be temporary storage to supply the file path to arbitrary protocols from the command line arguments. I see. The "file" field in the bootp message is fixed at 128 octets in the "bootp_hdr" structure. The contents of "net_boot_file_name" are read or written using the standard "strncopy()" or the similar "copy_filename()", so there should be any issue with respect to memory leaks. I guess you mean there should NOT be any issue? Yes, sorry. There should not be any issue with respect to memory leaks. Thank you, Jacob Stiffler Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot