Re: [U-Boot] [PATCH] net: phy: ti: Fix clock output DT property
> -Original Message- > From: Trent Piepho > Sent: Friday, May 10, 2019 12:49 PM > To: u-boot@lists.denx.de > Cc: Trent Piepho ; Joseph Hershberger > ; Janine Hagemann > ; Grygorii Strashko > Subject: [EXTERNAL] [PATCH] net: phy: ti: Fix clock output DT property > > The code block reading the DT property for the clock output control was > before the phy's DT node pointer was set, so it could never work. Move it > after the node pointer is set. > > Also store the unsigned 32-bit property into an unsigned value, not a signed > value, as the former will cause a problem if value overflows. > For instance, if one were to add 0x as a code to mean the clock output > should be turned off. > > Cc: Joe Hershberger > Cc: Janine Hagemann > Cc: Grygorii Strashko > Signed-off-by: Trent Piepho Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: phy: ti: Fix clock output DT property
On 10.05.19 20:49, Trent Piepho wrote: > The code block reading the DT property for the clock output control was > before the phy's DT node pointer was set, so it could never work. Move > it after the node pointer is set. > > Also store the unsigned 32-bit property into an unsigned value, not a > signed value, as the former will cause a problem if value overflows. > For instance, if one were to add 0x as a code to mean the clock > output should be turned off. > > Cc: Joe Hershberger > Cc: Janine Hagemann > Cc: Grygorii Strashko > Signed-off-by: Trent Piepho > --- > drivers/net/phy/ti.c | 16 +--- > 1 file changed, 5 insertions(+), 11 deletions(-) > Reviewed-by: Grygorii Strashko -- Best regards, grygorii ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot