Re: [U-Boot] [PATCH] nios2: remove EP1C20, EP1S10, EP1S40 boards

2010-05-27 Thread Thomas Chou
Scott McNutt wrote:
 I tested on the 1c20 this evening as well ... works fine. I will test on
 the 2c35 board tomorrow. I'd like to get a positive confirmation WRT the
 1S10 and 1S40 before applying this patch.

Hi Scott,

Please follow up this patch.

Best regards,
Thomas
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] nios2: remove EP1C20, EP1S10, EP1S40 boards

2010-04-22 Thread Scott McNutt
Hi Thomas,

Thomas Chou wrote:
 The example configuration files of nios2-generic board can generated
 binary to run on the EP1C20, EP1S10, and EP1S40 boards. So the three
 boards can be removed.
 
 With nios2-generic approach, the fpga parameter header file can
 be generated from hardware designs using tools. Porting u-boot for

What tools are you referring to?

 nios2 boards is simplified. Vendors can supply their fpga parameter
 file or patches to add a new nios2-generic board instance. There is

Support for several Altera nios2 boards has been available in u-boot
for at least four years. To date, this vendor has offered no support
whatsoever, either through patches, files, consultation or otherwise.

Is there any reason you believe this is likely to change?

 no need to include other boards support for nios2 in the u-boot
 mainline.

I'm not convinced that this is true.

Regards,
--Scott

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] nios2: remove EP1C20, EP1S10, EP1S40 boards

2010-04-22 Thread Thomas Chou
Hi Scott,

On 04/22/2010 08:36 PM, Scott McNutt wrote:
 With nios2-generic approach, the fpga parameter header file can
 be generated from hardware designs using tools. Porting u-boot for


 What tools are you referring to?
There are two tools.

1. sopc-create-header-files

It is included in altera design suite v8.0 or later. I used this in the 
initial version of nios2-generic board.

2. sopc-create-config-files

The script is available at

  http://sopc.et.ntust.edu.tw/?p=toolchain-build.git;
a=blob_plain;f=tools/sopc-create-config-files;hb=HEAD

I wrote this to generate unified u-boot header files, while I was 
discussing with Michal Simek. He liked this approach and I got his 
Acked-by of this patch.



 Support for several Altera nios2 boards has been available in u-boot
 for at least four years. To date, this vendor has offered no support
 whatsoever, either through patches, files, consultation or otherwise.

 Is there any reason you believe this is likely to change?
We really appreciate your work. But these boards are getting obsolete, 
and there are more new boards unsupported. We cannot add every board, 
and a generic approach should be taken as Michal suggested. We, (you, I 
, the community and Altera), should work together to offer a better 
solution.

The binary generated with the nios2-generic target should work on these 
three boards. I tested on  EP1C20 and I believe it will work on the 
other two. These boards are still supported, just under a different name.


 no need to include other boards support for nios2 in the u-boot
 mainline.

 I'm not convinced that this is true.

Michal's work on microblaze-generic already proved this.

Best regards,
Thomas


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] nios2: remove EP1C20, EP1S10, EP1S40 boards

2010-04-22 Thread Scott McNutt
Hi Thomas,

Thomas Chou wrote:
 With nios2-generic approach, the fpga parameter header file can
 be generated from hardware designs using tools. Porting u-boot for

 What tools are you referring to?

 2. sopc-create-config-files
 
 The script is available at
 
   http://sopc.et.ntust.edu.tw/?p=toolchain-build.git;
 a=blob_plain;f=tools/sopc-create-config-files;hb=HEAD

Ok ... GPL ... very nice! This addresses several of my big concerns.

 We cannot add every board, 
 and a generic approach should be taken as Michal suggested. We, (you, I 
 , the community and Altera), should work together to offer a better 
 solution.

Agreed. And please realize that I think the generic approach is
a great way to proceed. I listed my concerns in an earlier response
to Dalon. The availability of your GPL-ed script addresses most of
them.

 The binary generated with the nios2-generic target should work on these 
 three boards. I tested on  EP1C20 and I believe it will work on the 
 other two. These boards are still supported, just under a different name.

I tested on the 1c20 this evening as well ... works fine. I will test on
the 2c35 board tomorrow. I'd like to get a positive confirmation WRT the
1S10 and 1S40 before applying this patch.

 no need to include other boards support for nios2 in the u-boot
 mainline.
 I'm not convinced that this is true.

 Michal's work on microblaze-generic already proved this.

Michal proved the concept ... and the microblaze implementation (many
thanks for your contributions Michal). I'd like to _know_ that nothing
is broken before we remove existing code -- I don't want to leave
anyone high and dry. I've been in such situations ... it's no fun.

I'll apply the generic board patch to the nios 'next' branch, but I'd
like to hold off on blowing away those other board trees until we get
a chance to test the generic board on the actual targets. Fair enough?

Thanks for your efforts.

Regards,
--Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] nios2: remove EP1C20, EP1S10, EP1S40 boards

2010-04-22 Thread Thomas Chou
On 04/23/2010 12:21 PM, Scott McNutt wrote:

 I tested on the 1c20 this evening as well ... works fine. I will test on
 the 2c35 board tomorrow. I'd like to get a positive confirmation WRT the
 1S10 and 1S40 before applying this patch.

Great! Please also check epcs/spi flash on EP1C20.

1. apply this patch, [PATCH] spi_flash: support old STMicro parts with RES

2. add the following to board/altera/nios2-generic/custom_fpga.h

/* epcs_controller.epcs_control_port is a 
altera_avalon_epcs_flash_controller */
#define CONFIG_SYS_SPI_BASE 0x82100200
#define CONFIG_ALTERA_SPI
#define CONFIG_CMD_SPI
#define CONFIG_CMD_SF
#define CONFIG_SF_DEFAULT_SPEED 3000
#define CONFIG_SPI_FLASH
#define CONFIG_SPI_FLASH_STMICRO

3.
sf probe 0
sf read/write



 I'll apply the generic board patch to the nios 'next' branch, but I'd
 like to hold off on blowing away those other board trees until we get
 a chance to test the generic board on the actual targets. Fair enough?


OK.

Cheers,
Thomas


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot