Re: [U-Boot] [PATCH] rpi: remove redundant board files
Am 04.04.2016 um 17:36 schrieb Stephen Warren: > On 04/03/2016 09:41 AM, Andreas Färber wrote: >> Am 03.04.2016 um 05:56 schrieb Stephen Warren: >>> Now that rpi_*defconfig and Kconfig rather than the config header file, >> >> "rpi*_defconfig"? > > Both regexes match the same set of files at present, Sorry, missed the underscore in _2, we strip that in our package name. > but I prefer the > one I wrote, since it guarantees that it only matches the word "rpi" at > the start, not "rpi" followed by anything, which perhaps makes it > slightly less likely to accidentally match any other board in the future. Sure, makes sense. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] rpi: remove redundant board files
On 04/03/2016 09:41 AM, Andreas Färber wrote: Am 03.04.2016 um 05:56 schrieb Stephen Warren: Now that rpi_*defconfig and Kconfig rather than the config header file, "rpi*_defconfig"? Both regexes match the same set of files at present, but I prefer the one I wrote, since it guarantees that it only matches the word "rpi" at the start, not "rpi" followed by anything, which perhaps makes it slightly less likely to accidentally match any other board in the future. Also the sentence seems to be missing a verb - "Now that we use ..."? provide the identify of the build, we don't need to separate config "provide" is the verb. There should have been a command after "Kconfig" in the first line, or the comma before "provide" could be removed. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] rpi: remove redundant board files
Am 03.04.2016 um 05:56 schrieb Stephen Warren: > Now that rpi_*defconfig and Kconfig rather than the config header file, "rpi*_defconfig"? Also the sentence seems to be missing a verb - "Now that we use ..."? > provide the identify of the build, we don't need to separate config "identity"? > headers and board directories for each RPi variant. Set CONFIG_SYS_BOARD > and CONFIG_SYS_CONFIG_NAME so that we can get rid of the duplication. This > requires a tiny number of extra ifdefs in the config header. > > The only disadvantage of this approach is that the $board/$board_name > environment variables aren't as descriptive as they used to be. This isn't > really an issue because those only exist to allow scripts to create DTB > filenames at runtime. However, the RPi board code already sets $fdtfile to > something more accurate based on FW-reported board ID anyway. > > While at it, unify some Kconfig select options, and add a MAINTAINERS > entry for bcm283x too. > > Partially-suggested-by: Tom Rini > Signed-off-by: Stephen Warren Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] rpi: remove redundant board files
On Sat, Apr 02, 2016 at 09:56:10PM -0600, Stephen Warren wrote: > Now that rpi_*defconfig and Kconfig rather than the config header file, > provide the identify of the build, we don't need to separate config > headers and board directories for each RPi variant. Set CONFIG_SYS_BOARD > and CONFIG_SYS_CONFIG_NAME so that we can get rid of the duplication. This > requires a tiny number of extra ifdefs in the config header. > > The only disadvantage of this approach is that the $board/$board_name > environment variables aren't as descriptive as they used to be. This isn't > really an issue because those only exist to allow scripts to create DTB > filenames at runtime. However, the RPi board code already sets $fdtfile to > something more accurate based on FW-reported board ID anyway. > > While at it, unify some Kconfig select options, and add a MAINTAINERS > entry for bcm283x too. > > Partially-suggested-by: Tom Rini > Signed-off-by: Stephen Warren Reviewed-by: Tom Rini Thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
