Re: [U-Boot] [PATCH] u-boot: Update yaffs2 file system

2012-08-13 Thread Wolfgang Denk
Dear Charles,

In message 20120810224140.0f1b9204...@gemini.denx.de I wrote:
 Dear Charles,
 
 In message 20120809213931.755ad204...@gemini.denx.de I wrote:
  
  In message 1336618517-2947-1-git-send-email-cdhmann...@gmail.com you 
  wrote:
   This patch updates the yaffs2 in u-boot to correspond to
   git://www.aleph1.co.uk/yaffs2
   commit id 9ee5d0643e559568dbe62215f76e0a7bd5a63d93
 ...
  Applied, thanks.
 
 Unfortunately, this code causes a TON of errors and warnings, like
 these:
 
 In file included from yportenv.h:80:0,
  from yaffs_guts.h:19,
  from yaffs_allocator.h:19,
  from yaffs_allocator.c:14:
 ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
 /work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
 previous definition
 ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of 
 the previous definition
 ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of 
 the previous definition
 
 In file included from yportenv.h:80:0,
  from yaffscfg.h:26,
  from yaffs_uboot_glue.c:26:
 ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
 /work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
 previous definition
 ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of 
 the previous definition
 ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of 
 the previous definition
 ydirectenv.h:66:0: warning: kmalloc redefined [enabled by default]
 /work/wd/u-boot/include/linux/compat.h:20:0: note: this is the location of 
 the previous definition
 ydirectenv.h:67:0: warning: kfree redefined [enabled by default]
 /work/wd/u-boot/include/linux/compat.h:23:0: note: this is the location of 
 the previous definition
 ydirectenv.h:68:0: warning: vmalloc redefined [enabled by default]
 /work/wd/u-boot/include/linux/compat.h:22:0: note: this is the location of 
 the previous definition
 ydirectenv.h:69:0: warning: vfree redefined [enabled by default]
 /work/wd/u-boot/include/linux/compat.h:24:0: note: this is the location of 
 the previous definition
 
 In file included from yportenv.h:80:0,
  from yaffs_guts.c:14:
 ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
 /work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
 previous definition
 ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of 
 the previous definition
 ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
 /work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of 
 the previous definition
 yaffs_guts.c: In function 'yaffs_check_chunk_erased':
 yaffs_guts.c:324:6: warning: variable 'result' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c: In function 'yaffs_verify_chunk_written':
 yaffs_guts.c:352:6: warning: variable 'result' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c: In function 'yaffs_grab_chunk_cache':
 yaffs_guts.c:1488:6: warning: variable 'pushout' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c: In function 'yaffs_check_obj_details_loaded':
 yaffs_guts.c:3180:6: warning: variable 'alloc_failed' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c:3179:6: warning: variable 'result' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c: In function 'yaffs_update_oh':
 yaffs_guts.c:3288:6: warning: variable 'result' set but not used 
 [-Wunused-but-set-variable]
 yaffs_guts.c: In function 'yaffs_get_obj_name':
 yaffs_guts.c:4447:7: warning: variable 'result' set but not used 
 [-Wunused-but-set-variable]
 
 
 and so on and on.
 
 
 Please provide a fix, ideally soon, as this breaking builds!  Thanks!


Ping...

This needs to be fixed, or we will have to revert this commit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There is no statute of limitations on stupidity.
- Randomly produced by a computer program called Markov3.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] u-boot: Update yaffs2 file system

2012-08-10 Thread Wolfgang Denk
Dear Charles,

In message 20120809213931.755ad204...@gemini.denx.de I wrote:
 
 In message 1336618517-2947-1-git-send-email-cdhmann...@gmail.com you wrote:
  This patch updates the yaffs2 in u-boot to correspond to
  git://www.aleph1.co.uk/yaffs2
  commit id 9ee5d0643e559568dbe62215f76e0a7bd5a63d93
...
 Applied, thanks.

Unfortunately, this code causes a TON of errors and warnings, like
these:

In file included from yportenv.h:80:0,
 from yaffs_guts.h:19,
 from yaffs_allocator.h:19,
 from yaffs_allocator.c:14:
ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
/work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
previous definition
ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of the 
previous definition
ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of the 
previous definition

In file included from yportenv.h:80:0,
 from yaffscfg.h:26,
 from yaffs_uboot_glue.c:26:
ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
/work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
previous definition
ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of the 
previous definition
ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of the 
previous definition
ydirectenv.h:66:0: warning: kmalloc redefined [enabled by default]
/work/wd/u-boot/include/linux/compat.h:20:0: note: this is the location of the 
previous definition
ydirectenv.h:67:0: warning: kfree redefined [enabled by default]
/work/wd/u-boot/include/linux/compat.h:23:0: note: this is the location of the 
previous definition
ydirectenv.h:68:0: warning: vmalloc redefined [enabled by default]
/work/wd/u-boot/include/linux/compat.h:22:0: note: this is the location of the 
previous definition
ydirectenv.h:69:0: warning: vfree redefined [enabled by default]
/work/wd/u-boot/include/linux/compat.h:24:0: note: this is the location of the 
previous definition

In file included from yportenv.h:80:0,
 from yaffs_guts.c:14:
ydirectenv.h:31:0: warning: BUG redefined [enabled by default]
/work/wd/u-boot/include/common.h:160:0: note: this is the location of the 
previous definition
ydirectenv.h:50:0: warning: hweight8 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:139:0: note: this is the location of the 
previous definition
ydirectenv.h:51:0: warning: hweight32 redefined [enabled by default]
/work/wd/tmp-arm/include2/asm/bitops.h:137:0: note: this is the location of the 
previous definition
yaffs_guts.c: In function 'yaffs_check_chunk_erased':
yaffs_guts.c:324:6: warning: variable 'result' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c: In function 'yaffs_verify_chunk_written':
yaffs_guts.c:352:6: warning: variable 'result' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c: In function 'yaffs_grab_chunk_cache':
yaffs_guts.c:1488:6: warning: variable 'pushout' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c: In function 'yaffs_check_obj_details_loaded':
yaffs_guts.c:3180:6: warning: variable 'alloc_failed' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c:3179:6: warning: variable 'result' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c: In function 'yaffs_update_oh':
yaffs_guts.c:3288:6: warning: variable 'result' set but not used 
[-Wunused-but-set-variable]
yaffs_guts.c: In function 'yaffs_get_obj_name':
yaffs_guts.c:4447:7: warning: variable 'result' set but not used 
[-Wunused-but-set-variable]


and so on and on.


Please provide a fix, ideally soon, as this breaking builds!  Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You can't have everything... where would you put it?  - Steven Wright
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] u-boot: Update yaffs2 file system

2012-08-09 Thread Wolfgang Denk
Dear Charles Manning,

In message 1336618517-2947-1-git-send-email-cdhmann...@gmail.com you wrote:
 This patch updates the yaffs2 in u-boot to correspond to
 git://www.aleph1.co.uk/yaffs2
 commit id 9ee5d0643e559568dbe62215f76e0a7bd5a63d93
 
 Signed-off-by: Charles Manning cdhmann...@gmail.com
 ---
  common/cmd_yaffs2.c|  383 ++-
  fs/yaffs2/Makefile |   31 +-
  fs/yaffs2/README-linux |  201 -
  fs/yaffs2/devextras.h  |  275 --
  fs/yaffs2/stdio.h  |1 +
  fs/yaffs2/stdlib.h |1 +
  fs/yaffs2/string.h |6 +
  fs/yaffs2/yaffs_allocator.c|  357 ++
  fs/yaffs2/yaffs_allocator.h|   30 +
  fs/yaffs2/yaffs_attribs.c  |  153 +
  fs/yaffs2/yaffs_attribs.h  |   28 +
  fs/yaffs2/yaffs_bitmap.c   |   97 +
  fs/yaffs2/yaffs_bitmap.h   |   33 +
  fs/yaffs2/yaffs_checkptrw.c|  525 ++--
  fs/yaffs2/yaffs_checkptrw.h|   15 +-
  fs/yaffs2/yaffs_ecc.c  |  148 +-
  fs/yaffs2/yaffs_ecc.h  |   46 +-
  fs/yaffs2/yaffs_error.c|   58 +
  fs/yaffs2/yaffs_flashif.h  |   24 +-
  fs/yaffs2/yaffs_flashif2.h |   35 +
  fs/yaffs2/yaffs_getblockinfo.h |   35 +
  fs/yaffs2/yaffs_guts.c | 9213 
 +++-
  fs/yaffs2/yaffs_guts.h | 1219 +++---
  fs/yaffs2/yaffs_hweight.c  |   53 +
  fs/yaffs2/yaffs_hweight.h  |   24 +
  fs/yaffs2/yaffs_list.h |  126 +
  fs/yaffs2/yaffs_malloc.h   |   25 -
  fs/yaffs2/yaffs_mtdif.c|  175 +-
  fs/yaffs2/yaffs_mtdif.h|   12 +-
  fs/yaffs2/yaffs_mtdif2.c   |  270 +-
  fs/yaffs2/yaffs_mtdif2.h   |   17 +-
  fs/yaffs2/yaffs_nameval.c  |  208 +
  fs/yaffs2/yaffs_nameval.h  |   28 +
  fs/yaffs2/yaffs_nand.c |  150 +-
  fs/yaffs2/yaffs_nand.h |   31 +-
  fs/yaffs2/yaffs_nandemul2k.h   |   26 +-
  fs/yaffs2/yaffs_nandif.c   |  252 ++
  fs/yaffs2/yaffs_nandif.h   |   65 +
  fs/yaffs2/yaffs_osglue.h   |   42 +
  fs/yaffs2/yaffs_packedtags1.c  |   63 +-
  fs/yaffs2/yaffs_packedtags1.h  |   24 +-
  fs/yaffs2/yaffs_packedtags2.c  |  268 +-
  fs/yaffs2/yaffs_packedtags2.h  |   35 +-
  fs/yaffs2/yaffs_qsort.c|   58 +-
  fs/yaffs2/yaffs_qsort.h|   23 -
  fs/yaffs2/yaffs_ramdisk.h  |   32 -
  fs/yaffs2/yaffs_summary.c  |  313 ++
  fs/yaffs2/yaffs_summary.h  |   37 +
  fs/yaffs2/yaffs_tagscompat.c   |  573 +--
  fs/yaffs2/yaffs_tagscompat.h   |   34 +-
  fs/yaffs2/yaffs_tagsvalidity.c |   31 -
  fs/yaffs2/yaffs_tagsvalidity.h |   24 -
  fs/yaffs2/yaffs_trace.h|   57 +
  fs/yaffs2/yaffs_uboot_glue.c   |  464 ++
  fs/yaffs2/yaffs_verify.c   |  529 +++
  fs/yaffs2/yaffs_verify.h   |   43 +
  fs/yaffs2/yaffs_yaffs1.c   |  422 ++
  fs/yaffs2/yaffs_yaffs1.h   |   22 +
  fs/yaffs2/yaffs_yaffs2.c   | 1532 +++
  fs/yaffs2/yaffs_yaffs2.h   |   39 +
  fs/yaffs2/yaffscfg.c   |  420 --
  fs/yaffs2/yaffscfg.h   |   24 +-
  fs/yaffs2/yaffsfs.c| 3446 +++
  fs/yaffs2/yaffsfs.h|  282 +-
  fs/yaffs2/yaffsinterface.h |   21 -
  fs/yaffs2/ydirectenv.h |   82 +-
  fs/yaffs2/yportenv.h   |  393 ++-
  67 files changed, 13596 insertions(+), 10113 deletions(-)
  delete mode 100644 fs/yaffs2/README-linux
  delete mode 100644 fs/yaffs2/devextras.h
  create mode 100644 fs/yaffs2/stdio.h
  create mode 100644 fs/yaffs2/stdlib.h
  create mode 100644 fs/yaffs2/string.h
  create mode 100644 fs/yaffs2/yaffs_allocator.c
  create mode 100644 fs/yaffs2/yaffs_allocator.h
  create mode 100644 fs/yaffs2/yaffs_attribs.c
  create mode 100644 fs/yaffs2/yaffs_attribs.h
  create mode 100644 fs/yaffs2/yaffs_bitmap.c
  create mode 100644 fs/yaffs2/yaffs_bitmap.h
  create mode 100644 fs/yaffs2/yaffs_error.c
  create mode 100644 fs/yaffs2/yaffs_flashif2.h
  create mode 100644 fs/yaffs2/yaffs_getblockinfo.h
  create mode 100644 fs/yaffs2/yaffs_hweight.c
  create mode 100644 fs/yaffs2/yaffs_hweight.h
  create mode 100644 fs/yaffs2/yaffs_list.h
  delete mode 100644 fs/yaffs2/yaffs_malloc.h
  create mode 100644 fs/yaffs2/yaffs_nameval.c
  create mode 100644 fs/yaffs2/yaffs_nameval.h
  create mode 100644 fs/yaffs2/yaffs_nandif.c
  create mode 100644 fs/yaffs2/yaffs_nandif.h
  create mode 100644 fs/yaffs2/yaffs_osglue.h
  delete mode 100644 fs/yaffs2/yaffs_qsort.h
  delete mode 100644 fs/yaffs2/yaffs_ramdisk.h
  create mode 100644 fs/yaffs2/yaffs_summary.c
  create mode 100644 fs/yaffs2/yaffs_summary.h
  delete mode 100644 fs/yaffs2/yaffs_tagsvalidity.c
  delete mode 100644 fs/yaffs2/yaffs_tagsvalidity.h
  create mode 100644 fs/yaffs2/yaffs_trace.h
  create mode 100644 fs/yaffs2/yaffs_uboot_glue.c
  create mode 100644 fs/yaffs2/yaffs_verify.c
  create mode 100644 fs/yaffs2/yaffs_verify.h
  create mode 100644 fs/yaffs2/yaffs_yaffs1.c
  create mode 100644 fs/yaffs2/yaffs_yaffs1.h
  create mode 100644 fs/yaffs2/yaffs_yaffs2.c
  create mode 100644 fs/yaffs2/yaffs_yaffs2.h