Re: [U-Boot] [PATCH] video: add command cls

2018-11-19 Thread Patrick DELAUNAY
Hi Anatolij,

> From: Anatolij Gustschin  
> Sent: samedi 17 novembre 2018 15:37
> 
Hi Patrick,
> 
> On Sat, 17 Nov 2018 14:50:26 +0100
> Anatolij Gustschin ag...@denx.de wrote:
> ...
>> Thanks for the patch! But I think we should remove this existing lcd 
>> specific cls and add a common command under cmd/cls.c. I'll submit a 
>> path for this.
>>
>> Please test using this patch [1].
>> 
>> [1] http://patchwork.ozlabs.org/patch/999320/

I agree, that adding a new command file in cmd directory is cleaner.
I hesitate to do the same when I prepare my patch.

This patchset is superseded by (1), tested on my side for DM_VIDEO 
configuration (stm32mp157 board).

> --
>Anatolij

Regards
Patrick
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] video: add command cls

2018-11-17 Thread Anatolij Gustschin
Hi Patrick,

On Sat, 17 Nov 2018 14:50:26 +0100
Anatolij Gustschin ag...@denx.de wrote:
...
> Thanks for the patch! But I think we should remove this existing
> lcd specific cls and add a common command under cmd/cls.c. I'll
> submit a path for this.

Please test using this patch [1].

[1] http://patchwork.ozlabs.org/patch/999320/

--
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] video: add command cls

2018-11-17 Thread Anatolij Gustschin
Hi Patrick,

On Thu, 8 Nov 2018 18:24:32 +0100
Patrick Delaunay patrick.delau...@st.com wrote:

> Implement the existing command cls, for clear screen,
> when CONFIG_DM_VIDEO is activated.
> 
> This command was defined for old LCD framework (not dm) in
>   common/lcd.c:251
>   U_BOOT_CMD(cls, 1, 1, do_lcd_clear, "clear screen", "");
> 
> This command is useful to clear existing output (vidconsole) before
> to display splashscreen with bmp command.

Thanks for the patch! But I think we should remove this existing
lcd specific cls and add a common command under cmd/cls.c. I'll
submit a path for this.

--
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot