Re: [U-Boot] [PATCH 002/080] mpc83xx: spd_sdram: Fix whitespace style violations

[Mario Six]

Hi Wolfgang,

On Fri, Sep 29, 2017 at 4:03 PM, Wolfgang Denk  wrote:
> Dear Mario,
>
> In message <20170929125238.26226-2-mario@gdsys.cc> you wrote:
>> Fix whitespace style violations in the MPC83xx SPD-SDRAM code.
> ...
>
>> - ddr->csbnds[1].csbnds = ( (banksize(spd.row_dens) >> 8)
>> -   | ((banksize(spd.row_dens) >> 23) - 1) );
>>   ddr->cs_config[1] = ( 1<<31
>> + ddr->csbnds[1].csbnds = ((banksize(spd.row_dens) >> 8)
>> +   | ((banksize(spd.row_dens) >> 23) - 1));
>>   | (odt_rd_cfg << 20)
>>   | (odt_wr_cfg << 16)
>>   | ((spd.nbanks == 8 ? 1 : 0) << 14)
>>   | ((spd.nrow_addr - 12) << 8)
>
> This looks as if you were changing the code, and not only whitespace ?
>
> I would expect that this does not even compile!
>

Argh, something went wrong when I split the commits; this and the next commit
were originally a single commit, but I split them in order to be more readable
(the next commit fixes the order of the lines again).

> Which sort of testing did you give to this patch series?
>

I tested the final, and some of the larger patches using buildman, but not
these ones. I'll put the entire series through the wringer for v2. Terribly
sorry for that.

> Best regards,
>
> Wolfgang Denk
>

Best regards,

Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 002/080] mpc83xx: spd_sdram: Fix whitespace style violations

[Wolfgang Denk]

Dear Mario,

In message <20170929125238.26226-2-mario@gdsys.cc> you wrote:
> Fix whitespace style violations in the MPC83xx SPD-SDRAM code.
...

> - ddr->csbnds[1].csbnds = ( (banksize(spd.row_dens) >> 8)
> -   | ((banksize(spd.row_dens) >> 23) - 1) );
>   ddr->cs_config[1] = ( 1<<31
> + ddr->csbnds[1].csbnds = ((banksize(spd.row_dens) >> 8)
> +   | ((banksize(spd.row_dens) >> 23) - 1));
>   | (odt_rd_cfg << 20)
>   | (odt_wr_cfg << 16)
>   | ((spd.nbanks == 8 ? 1 : 0) << 14)
>   | ((spd.nrow_addr - 12) << 8)

This looks as if you were changing the code, and not only whitespace ?

I would expect that this does not even compile!

Which sort of testing did you give to this patch series?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A witty saying proves nothing, but saying  something  pointless  gets
people's attention.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot