Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
On Thursday, October 23, 2014 at 04:26:07 AM, Masahiro Yamada wrote: > Hi Marek, Hello! > On Wed, 22 Oct 2014 21:10:28 +0200 > > Marek Vasut wrote: > > On Monday, October 20, 2014 at 08:55:29 PM, Wolfgang Denk wrote: > > > Dear Marek, > > > > > > In message <201410201649.49448.ma...@denx.de> you wrote: > > > > Ah, you're right, we have this thing. One thing I'm not sure about is > > > > how is someone supposed to determine the commit in which the board > > > > was removed before the commit was created in the upstream > > > > repository. This kinda doesn't add up to me. > > > > > > You just insert place holders for the boards you are touching, and fix > > > up older entries that already hit mainline. > > > > I wonder if we shouldn't get rid of this README.scrapyard. Personally, I > > don't find much value in it to be honest ; if I am looking for some > > ancient board, I just do git log -p and search for whatever I need. > > I stick to it if this rule is a decision of u-boot community, but I have > also been wondering it. It is true we need some effort to maintain this > file. > > Maybe you should open a new thread to discuss removal of > doc/README.scrapyard. You're right, done! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
Hi Marek, On Wed, 22 Oct 2014 21:10:28 +0200 Marek Vasut wrote: > On Monday, October 20, 2014 at 08:55:29 PM, Wolfgang Denk wrote: > > Dear Marek, > > > > In message <201410201649.49448.ma...@denx.de> you wrote: > > > Ah, you're right, we have this thing. One thing I'm not sure about is how > > > is someone supposed to determine the commit in which the board was > > > removed before the commit was created in the upstream repository. This > > > kinda doesn't add up to me. > > > > You just insert place holders for the boards you are touching, and fix > > up older entries that already hit mainline. > > I wonder if we shouldn't get rid of this README.scrapyard. Personally, I > don't find much value in it to be honest ; if I am looking for some ancient > board, I just do git log -p and search for whatever I need. I stick to it if this rule is a decision of u-boot community, but I have also been wondering it. It is true we need some effort to maintain this file. Maybe you should open a new thread to discuss removal of doc/README.scrapyard. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
On Monday, October 20, 2014 at 08:55:29 PM, Wolfgang Denk wrote: > Dear Marek, > > In message <201410201649.49448.ma...@denx.de> you wrote: > > Ah, you're right, we have this thing. One thing I'm not sure about is how > > is someone supposed to determine the commit in which the board was > > removed before the commit was created in the upstream repository. This > > kinda doesn't add up to me. > > You just insert place holders for the boards you are touching, and fix > up older entries that already hit mainline. I wonder if we shouldn't get rid of this README.scrapyard. Personally, I don't find much value in it to be honest ; if I am looking for some ancient board, I just do git log -p and search for whatever I need. That said, I will fix up the patches ... also, I will split the removal from the eeprom changes, so the removal doesn't block the eeprom stuff. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
Dear Marek Vasut, In message <1413769706-8596-2-git-send-email-ma...@denx.de> you wrote: > This board is the only user of CONFIG_SYS_EEPROM_X40430 , remove > it so the EEPROM command code can be cleansed of the related code > as well. > > Signed-off-by: Marek Vasut > Cc: Masahiro Yamada > Cc: Tom Rini > Cc: Wolfgang Denk > Cc: Simon Glass > Cc: Heiko Schocher Assuming you also add an entry to scrapyard: Acked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To make this work we'd need a patch, as nobody of us tests this. - L. Poettering in https://bugs.freedesktop.org/show_bug.cgi?id=74589 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
Dear Marek, In message <201410201649.49448.ma...@denx.de> you wrote: > > Ah, you're right, we have this thing. One thing I'm not sure about is how > is someone supposed to determine the commit in which the board was removed > before the commit was created in the upstream repository. This kinda doesn't > add up to me. You just insert place holders for the boards you are touching, and fix up older entries that already hit mainline. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many seconds are there in a year? If I tell you there are 3.155 x 10^7, you won't even try to remember it. On the other hand, who could forget that, to within half a percent, pi seconds is a nanocentury. -- Tom Duff, Bell Labs ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
On Monday, October 20, 2014 at 05:54:18 AM, Masahiro Yamada wrote: > Hi Marek, Hi! > On Mon, 20 Oct 2014 03:48:02 +0200 > > Marek Vasut wrote: > > This board is the only user of CONFIG_SYS_EEPROM_X40430 , remove > > it so the EEPROM command code can be cleansed of the related code > > as well. > > > > Signed-off-by: Marek Vasut > > Cc: Masahiro Yamada > > Cc: Tom Rini > > Cc: Wolfgang Denk > > Cc: Simon Glass > > Cc: Heiko Schocher > > Can we do this all day long? > I am happy with 01/25 thru 07/25. :-) With pleasure ;-) Scrubbing old ad-hoc stuff is really enjoyable. > There is only one item I can tell: > I know it is a tedious work, but can you > update doc/README.scrapyard, please? > It seems a rule in U-boot when dumping board supports. Ah, you're right, we have this thing. One thing I'm not sure about is how is someone supposed to determine the commit in which the board was removed before the commit was created in the upstream repository. This kinda doesn't add up to me. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/25] ppc: Zap ICU862 board
Hi Marek, On Mon, 20 Oct 2014 03:48:02 +0200 Marek Vasut wrote: > This board is the only user of CONFIG_SYS_EEPROM_X40430 , remove > it so the EEPROM command code can be cleansed of the related code > as well. > > Signed-off-by: Marek Vasut > Cc: Masahiro Yamada > Cc: Tom Rini > Cc: Wolfgang Denk > Cc: Simon Glass > Cc: Heiko Schocher Can we do this all day long? I am happy with 01/25 thru 07/25. :-) There is only one item I can tell: I know it is a tedious work, but can you update doc/README.scrapyard, please? It seems a rule in U-boot when dumping board supports. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
