Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
Hi Stephen, On 25 April 2016 at 16:02, Stephen Warren wrote: > On 04/25/2016 03:54 PM, Simon Glass wrote: >> >> Hi Stephen, >> >> On 25 April 2016 at 13:34, Stephen Warren wrote: >>> >>> >>> On 04/24/2016 04:20 AM, Wolfgang Denk wrote: Dear Stephen, In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you wrote: > > > ... > > >/* > * Copyright (c) 2011 The Chromium OS Authors. > + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. Can you please get rid of this "All rights reserved." ? >>> >>> >>> >>> Sorry, that is the format I'm required to use by NVIDIA legal. >>> >>> To address your next question, "all rights reserved" is 100% compatible >>> with OSS licenses. Equally, the phrase already exists throughout both the >>> U-Boot and Linux kernel code-base (just a couple of prominent examples) for >>> both NVIDIA's copyright notices, and those of many other prominent entities >>> such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. >>> Please fix this globally in the whole patch set. I assume it cannot be a problem to do that, as in other places you did not add this either, for example here: > --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h > +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h > @@ -1,6 +1,6 @@ >/* > - * (C) Copyright 2010-2015 > - * NVIDIA Corporation > + * (C) Copyright 2010-2016 > + * NVIDIA Corporation >>> >>> >>> >>> The primary purpose of this patch-set isn't to clean up copyright >>> notices. As such, where I added new copyright notices I followed the format >>> that NVIDIA legal requests me to. However, where I simply edited the date in >>> existing notices I didn't do any other cleanup. >> >> >> Perhaps you could consider just not updating the notices? It isn't >> required by U-Boot. I tend not to do it. >> >> Also the all rights reserved thing is apparently pointless. > > > NVIDIA legal says I have to. > > I believe the only choice I have is whether to contribute to U-Boot. > > That said, I will go and double check again. Also point them to this: https://en.wikipedia.org/wiki/All_rights_reserved I recall a similar discussion before... Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
On Mon, Apr 25, 2016 at 04:02:13PM -0600, Stephen Warren wrote: > On 04/25/2016 03:54 PM, Simon Glass wrote: > >Hi Stephen, > > > >On 25 April 2016 at 13:34, Stephen Warren wrote: > >> > >>On 04/24/2016 04:20 AM, Wolfgang Denk wrote: > >>> > >>>Dear Stephen, > >>> > >>>In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you > >>>wrote: > > > >>>... > > /* > * Copyright (c) 2011 The Chromium OS Authors. > + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. > >>> > >>> > >>>Can you please get rid of this "All rights reserved." ? > >> > >> > >>Sorry, that is the format I'm required to use by NVIDIA legal. > >> > >>To address your next question, "all rights reserved" is 100% compatible > >>with OSS licenses. Equally, the phrase already exists throughout both the > >>U-Boot and Linux kernel code-base (just a couple of prominent examples) for > >>both NVIDIA's copyright notices, and those of many other prominent entities > >>such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. > >> > >>>Please fix this globally in the whole patch set. > >>> > >>>I assume it cannot be a problem to do that, as in other places you did > >>>not add this either, for example here: > >>> > --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h > +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h > @@ -1,6 +1,6 @@ > /* > - * (C) Copyright 2010-2015 > - * NVIDIA Corporation > + * (C) Copyright 2010-2016 > + * NVIDIA Corporation > >> > >> > >>The primary purpose of this patch-set isn't to clean up copyright notices. > >>As such, where I added new copyright notices I followed the format that > >>NVIDIA legal requests me to. However, where I simply edited the date in > >>existing notices I didn't do any other cleanup. > > > >Perhaps you could consider just not updating the notices? It isn't > >required by U-Boot. I tend not to do it. > > > >Also the all rights reserved thing is apparently pointless. > > NVIDIA legal says I have to. > > I believe the only choice I have is whether to contribute to U-Boot. > > That said, I will go and double check again. Please do go double check. Full disclosure, it's not something that's a dealbreaker for contributions, but I'd still rather not see it be added. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
On 04/25/2016 03:54 PM, Simon Glass wrote: Hi Stephen, On 25 April 2016 at 13:34, Stephen Warren wrote: On 04/24/2016 04:20 AM, Wolfgang Denk wrote: Dear Stephen, In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you wrote: ... /* * Copyright (c) 2011 The Chromium OS Authors. + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. Can you please get rid of this "All rights reserved." ? Sorry, that is the format I'm required to use by NVIDIA legal. To address your next question, "all rights reserved" is 100% compatible with OSS licenses. Equally, the phrase already exists throughout both the U-Boot and Linux kernel code-base (just a couple of prominent examples) for both NVIDIA's copyright notices, and those of many other prominent entities such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. Please fix this globally in the whole patch set. I assume it cannot be a problem to do that, as in other places you did not add this either, for example here: --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h @@ -1,6 +1,6 @@ /* - * (C) Copyright 2010-2015 - * NVIDIA Corporation + * (C) Copyright 2010-2016 + * NVIDIA Corporation The primary purpose of this patch-set isn't to clean up copyright notices. As such, where I added new copyright notices I followed the format that NVIDIA legal requests me to. However, where I simply edited the date in existing notices I didn't do any other cleanup. Perhaps you could consider just not updating the notices? It isn't required by U-Boot. I tend not to do it. Also the all rights reserved thing is apparently pointless. NVIDIA legal says I have to. I believe the only choice I have is whether to contribute to U-Boot. That said, I will go and double check again. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
On 04/25/2016 03:46 PM, Wolfgang Denk wrote: Dear Stephen, In message <571e7135.2030...@wwwdotorg.org> you wrote: Can you please get rid of this "All rights reserved." ? Sorry, that is the format I'm required to use by NVIDIA legal. To address your next question, "all rights reserved" is 100% compatible with OSS licenses. Equally, the phrase already exists throughout both the U-Boot and Linux kernel code-base (just a couple of prominent examples) for both NVIDIA's copyright notices, and those of many other prominent entities such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. Yes, I know these arguments. But actually this is b*llsh*t. Is there really no chance to drop that? I could ask NVIDIA legal again, but it's been discuss before and the guidance given was not changed, so I don't imagine it would be productive. - * (C) Copyright 2010-2015 - * NVIDIA Corporation + * (C) Copyright 2010-2016 + * NVIDIA Corporation The primary purpose of this patch-set isn't to clean up copyright notices. As such, where I added new copyright notices I followed the format that NVIDIA legal requests me to. However, where I simply edited the date in existing notices I didn't do any other cleanup. Well, obviously other people were either notrequested to add this "All rights reserved." phrase, or found other ways to avoid it. Can you please try to do the same? Given that message about says "2010" as the start date, I imagine the file was created (or copied blindly from another file that was created) before NVIDIA legal gave guidance for us to follow. I could only do the same by not following their current guidance, or claiming I forgot this time, which would be rather hard to do given this email thread. Either way, our internal systems will ding me for this when I rebase the copy of U-Boot we use internally, so I'll have to explain it then. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
Hi Stephen, On 25 April 2016 at 13:34, Stephen Warren wrote: > > On 04/24/2016 04:20 AM, Wolfgang Denk wrote: >> >> Dear Stephen, >> >> In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you >> wrote: >>> >>> >> ... >>> >>> /* >>>* Copyright (c) 2011 The Chromium OS Authors. >>> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. >> >> >> Can you please get rid of this "All rights reserved." ? > > > Sorry, that is the format I'm required to use by NVIDIA legal. > > To address your next question, "all rights reserved" is 100% compatible with > OSS licenses. Equally, the phrase already exists throughout both the U-Boot > and Linux kernel code-base (just a couple of prominent examples) for both > NVIDIA's copyright notices, and those of many other prominent entities such > as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. > >> Please fix this globally in the whole patch set. >> >> I assume it cannot be a problem to do that, as in other places you did >> not add this either, for example here: >> >>> --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h >>> +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h >>> @@ -1,6 +1,6 @@ >>> /* >>> - * (C) Copyright 2010-2015 >>> - * NVIDIA Corporation >>> + * (C) Copyright 2010-2016 >>> + * NVIDIA Corporation > > > The primary purpose of this patch-set isn't to clean up copyright notices. As > such, where I added new copyright notices I followed the format that NVIDIA > legal requests me to. However, where I simply edited the date in existing > notices I didn't do any other cleanup. Perhaps you could consider just not updating the notices? It isn't required by U-Boot. I tend not to do it. Also the all rights reserved thing is apparently pointless. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
Dear Stephen, In message <571e7135.2030...@wwwdotorg.org> you wrote: > > > Can you please get rid of this "All rights reserved." ? > > Sorry, that is the format I'm required to use by NVIDIA legal. > > To address your next question, "all rights reserved" is 100% compatible > with OSS licenses. Equally, the phrase already exists throughout both > the U-Boot and Linux kernel code-base (just a couple of prominent > examples) for both NVIDIA's copyright notices, and those of many other > prominent entities such as The Linux Foundation, Red Hat, Intel, The > Chromium OS Authors, etc. Yes, I know these arguments. But actually this is b*llsh*t. Is there really no chance to drop that? > >> - * (C) Copyright 2010-2015 > >> - * NVIDIA Corporation > >> + * (C) Copyright 2010-2016 > >> + * NVIDIA Corporation > > The primary purpose of this patch-set isn't to clean up copyright > notices. As such, where I added new copyright notices I followed the > format that NVIDIA legal requests me to. However, where I simply edited > the date in existing notices I didn't do any other cleanup. Well, obviously other people were either notrequested to add this "All rights reserved." phrase, or found other ways to avoid it. Can you please try to do the same? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Backed up the system lately? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
On 04/24/2016 04:20 AM, Wolfgang Denk wrote: Dear Stephen, In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you wrote: ... /* * Copyright (c) 2011 The Chromium OS Authors. + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. Can you please get rid of this "All rights reserved." ? Sorry, that is the format I'm required to use by NVIDIA legal. To address your next question, "all rights reserved" is 100% compatible with OSS licenses. Equally, the phrase already exists throughout both the U-Boot and Linux kernel code-base (just a couple of prominent examples) for both NVIDIA's copyright notices, and those of many other prominent entities such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc. Please fix this globally in the whole patch set. I assume it cannot be a problem to do that, as in other places you did not add this either, for example here: --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h @@ -1,6 +1,6 @@ /* - * (C) Copyright 2010-2015 - * NVIDIA Corporation + * (C) Copyright 2010-2016 + * NVIDIA Corporation The primary purpose of this patch-set isn't to clean up copyright notices. As such, where I added new copyright notices I followed the format that NVIDIA legal requests me to. However, where I simply edited the date in existing notices I didn't do any other cleanup. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
Dear Stephen, In message <1461099580-3866-2-git-send-email-swar...@wwwdotorg.org> you wrote: > ... > /* > * Copyright (c) 2011 The Chromium OS Authors. > + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. Can you please get rid of this "All rights reserved." ? Please fix this globally in the whole patch set. I assume it cannot be a problem to do that, as in other places you did not add this either, for example here: > --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h > +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h > @@ -1,6 +1,6 @@ > /* > - * (C) Copyright 2010-2015 > - * NVIDIA Corporation > + * (C) Copyright 2010-2016 > + * NVIDIA Corporation Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To be is to program. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers
On 19 April 2016 at 14:58, Stephen Warren wrote: > From: Stephen Warren > > arch/arm/include/asm/arch-tegra*/*.h have accumulated a fair number of > unused definitions. This patch aims to delete them all. > > While working on this, I noticed a few redundancies and fixed them. No > doubt other redundancies still exist simply because I wasn't looking hard > for them. > > A few definitions were moved between files to allow deletion of headers. > > Later changes will attempt to: > - Reduce the number of headers in the include directory. > - Move headers into arch/arm/mach-tegra/*, or into the same directory as > the drivers they serve. > - Eliminate remaining duplication. > - Refactor the headers to allow addition of future SoC support, where > those SoCs don't share many of the definitions currently located in > common headers. > > Signed-off-by: Stephen Warren > --- > arch/arm/include/asm/arch-tegra/ap.h | 69 - > arch/arm/include/asm/arch-tegra/clk_rst.h| 81 +++-- > arch/arm/include/asm/arch-tegra/clock.h | 2 +- > arch/arm/include/asm/arch-tegra/gp_padctrl.h | 6 +- > arch/arm/include/asm/arch-tegra/gpio.h | 4 +- > arch/arm/include/asm/arch-tegra/pmc.h| 19 +- > arch/arm/include/asm/arch-tegra/pwm.h| 3 +- > arch/arm/include/asm/arch-tegra/sys_proto.h | 4 +- > arch/arm/include/asm/arch-tegra/tegra.h | 26 ++-- > arch/arm/include/asm/arch-tegra/tegra_i2c.h | 11 +--- > arch/arm/include/asm/arch-tegra/tegra_mmc.h | 4 +- > arch/arm/include/asm/arch-tegra/timer.h | 15 - > arch/arm/include/asm/arch-tegra/uart.h | 31 -- > arch/arm/include/asm/arch-tegra/usb.h| 5 +- > arch/arm/include/asm/arch-tegra/warmboot.h | 3 +- > arch/arm/include/asm/arch-tegra124/ahb.h | 91 > > arch/arm/include/asm/arch-tegra124/display.h | 58 -- > arch/arm/include/asm/arch-tegra124/flow.h| 8 +-- > arch/arm/include/asm/arch-tegra124/mc.h | 3 +- > arch/arm/include/asm/arch-tegra124/tegra.h | 5 +- > arch/arm/include/asm/arch-tegra20/tegra.h| 4 +- > arch/arm/include/asm/arch-tegra210/ahb.h | 13 +--- > arch/arm/include/asm/arch-tegra210/clock.h | 3 +- > arch/arm/include/asm/arch-tegra210/flow.h| 16 + > arch/arm/include/asm/arch-tegra210/mc.h | 5 +- > arch/arm/include/asm/arch-tegra210/tegra.h | 5 +- > arch/arm/include/asm/arch-tegra30/tegra.h| 4 +- > arch/arm/mach-tegra/ap.c | 10 +-- > arch/arm/mach-tegra/board.c | 11 ++-- > arch/arm/mach-tegra/board2.c | 6 +- > arch/arm/mach-tegra/cache.c | 4 +- > arch/arm/mach-tegra/clock.c | 4 +- > arch/arm/mach-tegra/cpu.h| 34 +++ > arch/arm/mach-tegra/emc.c| 5 +- > arch/arm/mach-tegra/tegra114/clock.c | 3 +- > arch/arm/mach-tegra/tegra124/clock.c | 3 +- > arch/arm/mach-tegra/tegra124/cpu.c | 4 +- > arch/arm/mach-tegra/tegra124/psci.c | 3 +- > arch/arm/mach-tegra/tegra20/clock.c | 3 +- > arch/arm/mach-tegra/tegra20/display.c| 5 +- > arch/arm/mach-tegra/tegra20/emc.c| 2 +- > arch/arm/mach-tegra/tegra20/pmu.c| 4 +- > arch/arm/mach-tegra/tegra20/warmboot.c | 4 +- > arch/arm/mach-tegra/tegra20/warmboot_avp.c | 6 +- > arch/arm/mach-tegra/tegra20/warmboot_avp.h | 6 +- > arch/arm/mach-tegra/tegra210/clock.c | 3 +- > arch/arm/mach-tegra/tegra30/clock.c | 3 +- > board/avionic-design/common/tamonten.c | 9 ++- > board/toradex/apalis_t30/apalis_t30.c| 6 +- > board/toradex/colibri_t20/colibri_t20.c | 4 +- > board/toradex/colibri_t30/colibri_t30.c | 6 +- > drivers/i2c/tegra_i2c.c | 6 +- > drivers/input/tegra-kbc.c| 5 +- > drivers/video/tegra.c| 3 +- > include/configs/tegra-common.h | 10 ++- > 55 files changed, 117 insertions(+), 553 deletions(-) > delete mode 100644 arch/arm/include/asm/arch-tegra/ap.h > delete mode 100644 arch/arm/include/asm/arch-tegra/timer.h > delete mode 100644 arch/arm/include/asm/arch-tegra/uart.h > delete mode 100644 arch/arm/include/asm/arch-tegra124/ahb.h > delete mode 100644 arch/arm/include/asm/arch-tegra124/display.h Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
