Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insertions(+), 25 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "There's only one way to have a happy marriage and as soon as I learn what it is I'll get married again." - Clint Eastwood ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insertions(+), 25 deletions(-) Urgh... This breaks almost all ARM boards like this: Configuring for a320evb board... board.c: In function 'board_init_r': board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.) make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1 make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2 Didn't you run MAKELL? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ADVISORY: There is an Extremely Small but Nonzero Chance That, Through a Process Know as "Tunneling," This Product May Spontaneously Disappear from Its Present Location and Reappear at Any Random Place in the Universe, Including Your Neighbor's Domicile. The Manufacturer Will Not Be Responsible for Any Damages or Inconvenience That May Result. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:49 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: >> This changes the board code to use the new getenv_ulong() function. >> >> Signed-off-by: Simon Glass >> --- >> arch/arm/lib/board.c | 36 +++- >> 1 files changed, 11 insertions(+), 25 deletions(-) > > Urgh... > > This breaks almost all ARM boards like this: > > Configuring for a320evb board... > board.c: In function 'board_init_r': > board.c:569: error: 's' undeclared (first use in this function) > board.c:569: error: (Each undeclared identifier is reported only once > board.c:569: error: for each function it appears in.) > make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1 > make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2 Sorry, I have sent a patch for this. > > > Didn't you run MAKELL? No these pre-date my getting that running (with Mike's help) and I didn't think to go back to this series. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > ADVISORY: There is an Extremely Small but Nonzero Chance That, > Through a Process Know as "Tunneling," This Product May Spontaneously > Disappear from Its Present Location and Reappear at Any Random Place > in the Universe, Including Your Neighbor's Domicile. The Manufacturer > Will Not Be Responsible for Any Damages or Inconvenience That May > Result. > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
