Re: [U-Boot] [PATCH 02/14] ARM: AM43xx: Adapt to ti_armv7_common.h config file

2013-11-06 Thread Vaibhav Bedia
On Mon, Nov 4, 2013 at 11:20 PM, Lokesh Vutla lokeshvu...@ti.com wrote:
 Use ti_armv7_common.h config file to inclde the common
 configs.

[...]


 +/* Clock Defines */
 +#define V_OSCK 2400  /* Clock output from T2 */
 +#define V_SCLK (V_OSCK)

I know this is slightly unrelated but i don't think hardcoding the osc freq
is a good idea. We should be reading the PRCM register to detect the
sysboot settings and then use that similar to the kernel. Follow up patch?


 -/* Unsupported features */
 -#undef CONFIG_USE_IRQ
 +/* NS16550 Configuration */
 +#define CONFIG_SYS_NS16550_COM10x44e09000  /* Base EVM 
 has UART0 */

I think the comment on base EVM is not applicable here ;)

Regards,
Vaibhav
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 02/14] ARM: AM43xx: Adapt to ti_armv7_common.h config file

2013-11-06 Thread Lokesh Vutla
Hi Vaibhav,

On Wednesday 06 November 2013 06:04 PM, Vaibhav Bedia wrote:
 On Mon, Nov 4, 2013 at 11:20 PM, Lokesh Vutla lokeshvu...@ti.com wrote:
 Use ti_armv7_common.h config file to inclde the common
 configs.
 
 [...]
 
 
 +/* Clock Defines */
 +#define V_OSCK 2400  /* Clock output from T2 */
 +#define V_SCLK (V_OSCK)
 
 I know this is slightly unrelated but i don't think hardcoding the osc freq
 is a good idea. We should be reading the PRCM register to detect the
 sysboot settings and then use that similar to the kernel. Follow up patch?
This is how it is done in all other OMAPs and AMXX. But you are correct,
it can be done from reading the register. Will discuss with Tom and update 
about a separate patch but not in this series..:)

Thanks and regards,
Lokesh 
 

 -/* Unsupported features */
 -#undef CONFIG_USE_IRQ
 +/* NS16550 Configuration */
 +#define CONFIG_SYS_NS16550_COM10x44e09000  /* Base EVM 
 has UART0 */
 
 I think the comment on base EVM is not applicable here ;)
 
 Regards,
 Vaibhav
 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot