Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-07 Thread Marek Vasut
On 12/07/2016 04:05 PM, Dinh Nguyen wrote:
> 
> 
> On 12/06/2016 05:41 PM, Marek Vasut wrote:
>>> The previous patches in this series applied to Marek's 01-arria10 branch,
>>> but this patch does not apply at all:
>>>
>>> error: patch failed: arch/arm/mach-socfpga/misc.c:361
>>> error: arch/arm/mach-socfpga/misc.c: patch does not apply
>>>
>>> Also, on the next revision, please add -C to git format-patch.
>>
>> I was tempted to discard that arria 10 patchset from the tree, I've been
>> trying to keep it kinda in sync, but it's probably broken. If
>> you plan to submit A10, just start on u-boot/master and -- if we all
>> agree -- I'll discard the 01-arria10 branch. The current situation
>> is chaos.
>>
> 
> I agree that it is a bit chaotic. I'll let you make the decision, since
> I have not been actively sending patches for A10. That is Tien Fong's
> and Chin Liang's job now.

Yeah :-)

> BTW, really appreciate the work to keep the 01-arria10 branch alive for
> all this time.

No problem, although I think bitrot has set in .

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-07 Thread Dinh Nguyen


On 12/07/2016 06:04 AM, Chee, Tien Fong wrote:
>> The previous patches in this series applied to Marek's 01-arria10
>> branch,
>> but this patch does not apply at all:
>>
>> error: patch failed: arch/arm/mach-socfpga/misc.c:361
>> error: arch/arm/mach-socfpga/misc.c: patch does not apply
>>
>> Also, on the next revision, please add -C to git format-patch.
>>
>> Dinh
> 
> Sorry to hear that. It is too weird the patch didn't applied, but i
> have no issue with this patch. Are you using git am command?
> 

I tried everything...git am and git apply. Perhaps you have some
uncommitted changes in your branch?

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-07 Thread Dinh Nguyen


On 12/06/2016 05:41 PM, Marek Vasut wrote:
>> The previous patches in this series applied to Marek's 01-arria10 branch,
>> but this patch does not apply at all:
>>
>> error: patch failed: arch/arm/mach-socfpga/misc.c:361
>> error: arch/arm/mach-socfpga/misc.c: patch does not apply
>>
>> Also, on the next revision, please add -C to git format-patch.
> 
> I was tempted to discard that arria 10 patchset from the tree, I've been
> trying to keep it kinda in sync, but it's probably broken. If
> you plan to submit A10, just start on u-boot/master and -- if we all
> agree -- I'll discard the 01-arria10 branch. The current situation
> is chaos.
> 

I agree that it is a bit chaotic. I'll let you make the decision, since
I have not been actively sending patches for A10. That is Tien Fong's
and Chin Liang's job now.

BTW, really appreciate the work to keep the 01-arria10 branch alive for
all this time.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-07 Thread Chee, Tien Fong
On Sel, 2016-12-06 at 16:26 -0600, dinguyen wrote:
> On Tue, 6 Dec 2016, Chee Tien Fong wrote:
> 
> > 
> > From: Tien Fong Chee 
> > 
> > The drivers is restructured such common functions, gen5 functions,
> > and arria10 functions are moved to misc.c, misc_gen5 and
> > misc_arria10
> > respectively.
> > 
> > Signed-off-by: Tien Fong Chee 
> > Cc: Marek Vasut 
> > Cc: Dinh Nguyen 
> > Cc: Chin Liang See 
> > Cc: Tien Fong 
> > ---
> >  arch/arm/mach-socfpga/Makefile|4 +-
> >  arch/arm/mach-socfpga/include/mach/misc.h |   25 ++
> >  arch/arm/mach-socfpga/misc.c  |  429 +--
> > -
> >  arch/arm/mach-socfpga/misc_arria10.c  |  111 
> >  arch/arm/mach-socfpga/misc_gen5.c |  363
> > 
> >  5 files changed, 517 insertions(+), 415 deletions(-)
> >  create mode 100644 arch/arm/mach-socfpga/include/mach/misc.h
> >  create mode 100644 arch/arm/mach-socfpga/misc_arria10.c
> >  create mode 100644 arch/arm/mach-socfpga/misc_gen5.c
> > 
> The previous patches in this series applied to Marek's 01-arria10
> branch,
> but this patch does not apply at all:
> 
> error: patch failed: arch/arm/mach-socfpga/misc.c:361
> error: arch/arm/mach-socfpga/misc.c: patch does not apply
> 
> Also, on the next revision, please add -C to git format-patch.
> 
> Dinh

Sorry to hear that. It is too weird the patch didn't applied, but i
have no issue with this patch. Are you using git am command?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-06 Thread Marek Vasut
On 12/06/2016 11:26 PM, dinguyen wrote:
> On Tue, 6 Dec 2016, Chee Tien Fong wrote:
> 
>> From: Tien Fong Chee 
>>
>> The drivers is restructured such common functions, gen5 functions,
>> and arria10 functions are moved to misc.c, misc_gen5 and misc_arria10
>> respectively.
>>
>> Signed-off-by: Tien Fong Chee 
>> Cc: Marek Vasut 
>> Cc: Dinh Nguyen 
>> Cc: Chin Liang See 
>> Cc: Tien Fong 
>> ---
>>  arch/arm/mach-socfpga/Makefile|4 +-
>>  arch/arm/mach-socfpga/include/mach/misc.h |   25 ++
>>  arch/arm/mach-socfpga/misc.c  |  429 
>> +---
>>  arch/arm/mach-socfpga/misc_arria10.c  |  111 
>>  arch/arm/mach-socfpga/misc_gen5.c |  363 
>>  5 files changed, 517 insertions(+), 415 deletions(-)
>>  create mode 100644 arch/arm/mach-socfpga/include/mach/misc.h
>>  create mode 100644 arch/arm/mach-socfpga/misc_arria10.c
>>  create mode 100644 arch/arm/mach-socfpga/misc_gen5.c
>>
> 
> The previous patches in this series applied to Marek's 01-arria10 branch,
> but this patch does not apply at all:
> 
> error: patch failed: arch/arm/mach-socfpga/misc.c:361
> error: arch/arm/mach-socfpga/misc.c: patch does not apply
> 
> Also, on the next revision, please add -C to git format-patch.

I was tempted to discard that arria 10 patchset from the tree, I've been
trying to keep it kinda in sync, but it's probably broken. If
you plan to submit A10, just start on u-boot/master and -- if we all
agree -- I'll discard the 01-arria10 branch. The current situation
is chaos.


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 07/10] arm: socfpga: arria10: Added miscellaneous drivers for Arria10

2016-12-06 Thread dinguyen
On Tue, 6 Dec 2016, Chee Tien Fong wrote:

> From: Tien Fong Chee 
> 
> The drivers is restructured such common functions, gen5 functions,
> and arria10 functions are moved to misc.c, misc_gen5 and misc_arria10
> respectively.
> 
> Signed-off-by: Tien Fong Chee 
> Cc: Marek Vasut 
> Cc: Dinh Nguyen 
> Cc: Chin Liang See 
> Cc: Tien Fong 
> ---
>  arch/arm/mach-socfpga/Makefile|4 +-
>  arch/arm/mach-socfpga/include/mach/misc.h |   25 ++
>  arch/arm/mach-socfpga/misc.c  |  429 +---
>  arch/arm/mach-socfpga/misc_arria10.c  |  111 
>  arch/arm/mach-socfpga/misc_gen5.c |  363 
>  5 files changed, 517 insertions(+), 415 deletions(-)
>  create mode 100644 arch/arm/mach-socfpga/include/mach/misc.h
>  create mode 100644 arch/arm/mach-socfpga/misc_arria10.c
>  create mode 100644 arch/arm/mach-socfpga/misc_gen5.c
> 

The previous patches in this series applied to Marek's 01-arria10 branch,
but this patch does not apply at all:

error: patch failed: arch/arm/mach-socfpga/misc.c:361
error: arch/arm/mach-socfpga/misc.c: patch does not apply

Also, on the next revision, please add -C to git format-patch.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot