Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt 
On 03/18/2018 01:10 PM, Marek Vasut wrote:
> On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote:
>> In
>>
>>  struct dwc3_request *r = NULL;
>>  r = A;
>>
>> the first assignment has no effect. Remove it.
>>
>> Signed-off-by: Heinrich Schuchardt 
> 
> The driver is imported from Linux, did you fix it in Linux too ?

Thanks for the hint.
https://lkml.org/lkml/2018/3/18/143

Regards

Heinrich
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

2018-03-18 Thread Marek Vasut 
On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote:
> In
> 
>   struct dwc3_request *r = NULL;
>   r = A;
> 
> the first assignment has no effect. Remove it.
> 
> Signed-off-by: Heinrich Schuchardt 

The driver is imported from Linux, did you fix it in Linux too ?

> ---
>  drivers/usb/dwc3/ep0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
> index e61d98046f..2719984603 100644
> --- a/drivers/usb/dwc3/ep0.c
> +++ b/drivers/usb/dwc3/ep0.c
> @@ -767,7 +767,7 @@ out:
>  static void dwc3_ep0_complete_data(struct dwc3 *dwc,
>   const struct dwc3_event_depevt *event)
>  {
> - struct dwc3_request *r = NULL;
> + struct dwc3_request *r;
>   struct usb_request  *ur;
>   struct dwc3_trb *trb;
>   struct dwc3_ep  *ep0;
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot