Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp
On Fri, 4 Oct 2019 at 09:13, Tom Rini wrote: > > We may not always be able to write to the default output directory but > we will always have a usable /tmp. Make the buildman tests use /tmp > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > tools/buildman/func_test.py | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Simon Glass (this, or using $TMPDIR) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp
On Fri, Oct 04, 2019 at 12:40:02PM -0600, Stephen Warren wrote: > On 10/4/19 11:26 AM, Tom Rini wrote: > > On Fri, Oct 04, 2019 at 10:32:42AM -0600, Stephen Warren wrote: > > > On 10/4/19 10:12 AM, Tom Rini wrote: > > > > We may not always be able to write to the default output directory but > > > > we will always have a usable /tmp. > > > > > > Is that a valid assumption? Surely $TMPDIR should be used if set in the > > > environment, falling back to a hard-coded /tmp if that isn't set? > > > > $TMPDIR is most portable but as far as Linux goes, there needs to be > > /tmp, yes? > > I don't think there absolutely has to be, no. Calling tempfile.mkdtemp() > will "just work" and do the right thing in all cases. OK, that wasn't too bad, waiting for any other feedback before v2'ing, thanks. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp
On 10/4/19 11:26 AM, Tom Rini wrote: On Fri, Oct 04, 2019 at 10:32:42AM -0600, Stephen Warren wrote: On 10/4/19 10:12 AM, Tom Rini wrote: We may not always be able to write to the default output directory but we will always have a usable /tmp. Is that a valid assumption? Surely $TMPDIR should be used if set in the environment, falling back to a hard-coded /tmp if that isn't set? $TMPDIR is most portable but as far as Linux goes, there needs to be /tmp, yes? I don't think there absolutely has to be, no. Calling tempfile.mkdtemp() will "just work" and do the right thing in all cases. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp
On Fri, Oct 04, 2019 at 10:32:42AM -0600, Stephen Warren wrote: > On 10/4/19 10:12 AM, Tom Rini wrote: > > We may not always be able to write to the default output directory but > > we will always have a usable /tmp. > > Is that a valid assumption? Surely $TMPDIR should be used if set in the > environment, falling back to a hard-coded /tmp if that isn't set? $TMPDIR is most portable but as far as Linux goes, there needs to be /tmp, yes? -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp
On 10/4/19 10:12 AM, Tom Rini wrote: We may not always be able to write to the default output directory but we will always have a usable /tmp. Is that a valid assumption? Surely $TMPDIR should be used if set in the environment, falling back to a hard-coded /tmp if that isn't set? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
