Re: [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean
Hello Wolfgang, Looks good. A minor commend below. On Fri, 23 Dec 2011 12:29:10 +0100 Wolfgang Denk w...@denx.de wrote: Signed-off-by: Wolfgang Denk w...@denx.de Cc: Anatolij Gustschin ag...@denx.de Cc: Stefan Roese s...@denx.de Cc: Kumar Gala ga...@kernel.crashing.org Cc: Kim Phillips kim.phill...@freescale.com Cc: Andy Fleming aflem...@gmail.com --- post/lib_powerpc/multi.c | 54 + 1 files changed, 25 insertions(+), 29 deletions(-) diff --git a/post/lib_powerpc/multi.c b/post/lib_powerpc/multi.c index 5845616..4b4b119 100644 --- a/post/lib_powerpc/multi.c +++ b/post/lib_powerpc/multi.c @@ -38,45 +38,41 @@ #if CONFIG_POST CONFIG_SYS_POST_CPU -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2); +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2); IIRC checkpatch complains like foo * bar should be foo *bar, There is surely no need to resubmit the patch, it could be changed when applying. Otherwise Acked-by: Anatolij Gustschin ag...@denx.de Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean
Dear Wolfgang Denk, In message 1324639752-26856-1-git-send-email...@denx.de you wrote: Signed-off-by: Wolfgang Denk w...@denx.de Cc: Anatolij Gustschin ag...@denx.de Cc: Stefan Roese s...@denx.de Cc: Kumar Gala ga...@kernel.crashing.org Cc: Kim Phillips kim.phill...@freescale.com Cc: Andy Fleming aflem...@gmail.com --- post/lib_powerpc/multi.c | 54 + 1 files changed, 25 insertions(+), 29 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The typical page layout program is nothing more than an electronic light table for cutting and pasting documents. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean
Dear Anatolij Gustschin, In message 20111223133952.5e09a8b4@wker you wrote: Looks good. A minor commend below. ... -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2); +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2); IIRC checkpatch complains like foo * bar should be foo *bar, There is surely no need to resubmit the patch, it could be changed when applying. Otherwise You are right. Fixed this. Thanks for the review! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Science makes godlike -- it is all over with priests and gods when man becomes scientific. Moral: science is the forbidden as such -- it alone is forbidden. Science is the *first* sin, the *original* sin. *This alone is morality.* ``Thou shalt not know'' -- the rest follows. - Friedrich Nietzsche ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
