Re: [U-Boot] [PATCH 1/4] MX51: iomux: Added support for mxc_iomux_set_input()

[Stefano Babic]

David Jander wrote:
> Signed-off-by: David Jander 
> ---

Hi Dave,

>  arch/arm/cpu/armv7/mx51/iomux.c |8 +++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 

Probably iut is better you set a more useful comment in your commit.
Instead of "Added support for   mxc_iomux_set_input()", you can explain
which is the new feature you provide. Something to explain you add a
utility for the "daisy chain" pins, to control the input path to a
module when the module can be connected to more as one pin.

The patch is part of a series. However, I can see only the first two
patches. Is there something missing ? I do not see any relation between
these two patches, too.

> +void mxc_iomux_set_input(iomux_input_select_t input, u32 config)
> +{
> + u32 pad_reg = IOMUXSW_INPUT_CTL+(input*4);

Code styling, you should add spaces:

u32 pad_reg = IOMUXSW_INPUT_CTL + (input * 4);

> + writel(config, pad_reg);
> +}

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] MX51: iomux: Added support for mxc_iomux_set_input()

[Stefano Babic]

David Jander wrote:
> Hi Stefano,
> 

Hi David,

> Hmmm. I thought it was a trivial and obviously missing function to make 
> iomux.c complete.
> Someone just needed to write it. I didn't think it needed 
> any more explaining than that, but I'll do it in the next version of the 
> patch 
> set (will take a while).

Not everybody works with the MX51, and if we do not write some
additional info it is difficult to find a relation in the reference
manual ;-).

> I sent 4 patches and received them all on the mailing-list. Are you sure you 
> miss two of them?

I have found them on gmane now, thanks.

Best regards,
Stefano

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot