Re: [U-Boot] [PATCH 1/4 V6] EXYNOS5: FDT: Add compatible strings for Serial

2013-06-24 Thread Minkyu Kang
On 24/06/13 18:16, Rajeshwari Shinde wrote:
 Add required compatible information for s5p serial driver
 
 Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
 Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
 ---
 Changes in V2:
 - Changed the compatible string to samsung,exynos4210-uart
 Changes in V3:
 - Rebased on latest u-boot-samsung
 Changes in V4:
 - Rebased on latest u-boot-samsung
 - Changed to COMPAT_SAMSUNG_EXYNOS5_SERIAL to 
 COMPAT_SAMSUNG_EXYNOS_SERIAL
 Changes in V5:
 - None
 Changes in V6:
   - Moved compatible strings up with all other samsung strings.
  include/fdtdec.h |1 +
  lib/fdtdec.c |1 +
  2 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/include/fdtdec.h b/include/fdtdec.h
 index bc3b89b..bea326e 100644
 --- a/include/fdtdec.h
 +++ b/include/fdtdec.h
 @@ -90,6 +90,7 @@ enum fdt_compat_id {
   COMPAT_SAMSUNG_EXYNOS_FIMD, /* Exynos Display controller */
   COMPAT_SAMSUNG_EXYNOS5_DP,  /* Exynos Display port controller */
   COMPAT_SAMSUNG_EXYNOS5_DWMMC,   /* Exynos5 DWMMC controller */
 + COMPAT_SAMSUNG_EXYNOS_SERIAL,   /* Exynos UART */
   COMPAT_MAXIM_MAX77686_PMIC, /* MAX77686 PMIC */
   COMPAT_GENERIC_SPI_FLASH,   /* Generic SPI Flash chip */
   COMPAT_MAXIM_98095_CODEC,   /* MAX98095 Codec */
 diff --git a/lib/fdtdec.c b/lib/fdtdec.c
 index e3142cb..d1acc35 100644
 --- a/lib/fdtdec.c
 +++ b/lib/fdtdec.c
 @@ -63,6 +63,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
   COMPAT(SAMSUNG_EXYNOS_FIMD, samsung,exynos-fimd),
   COMPAT(SAMSUNG_EXYNOS5_DP, samsung,exynos5-dp),
   COMPAT(SAMSUNG_EXYNOS5_DWMMC, samsung,exynos5250-dwmmc),
 + COMPAT(SAMSUNG_EXYNOS_SERIAL, samsung,exynos4210-uart),

Is it exynos4210 specific?
If not, how about exynos-uart?

   COMPAT(MAXIM_MAX77686_PMIC, maxim,max77686_pmic),
   COMPAT(GENERIC_SPI_FLASH, spi-flash),
   COMPAT(MAXIM_98095_CODEC, maxim,max98095-codec),
 

Thanks,
Minkyu Kang.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/4 V6] EXYNOS5: FDT: Add compatible strings for Serial

2013-06-24 Thread Rajeshwari Birje
Hi Minkyu,

Please do find the answer to your commnet.

On Mon, Jun 24, 2013 at 3:46 PM, Minkyu Kang mk7.k...@samsung.com wrote:
 On 24/06/13 18:16, Rajeshwari Shinde wrote:
 Add required compatible information for s5p serial driver

 Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
 Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
 ---
 Changes in V2:
 - Changed the compatible string to samsung,exynos4210-uart
 Changes in V3:
 - Rebased on latest u-boot-samsung
 Changes in V4:
 - Rebased on latest u-boot-samsung
 - Changed to COMPAT_SAMSUNG_EXYNOS5_SERIAL to 
 COMPAT_SAMSUNG_EXYNOS_SERIAL
 Changes in V5:
 - None
 Changes in V6:
   - Moved compatible strings up with all other samsung strings.
  include/fdtdec.h |1 +
  lib/fdtdec.c |1 +
  2 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/include/fdtdec.h b/include/fdtdec.h
 index bc3b89b..bea326e 100644
 --- a/include/fdtdec.h
 +++ b/include/fdtdec.h
 @@ -90,6 +90,7 @@ enum fdt_compat_id {
   COMPAT_SAMSUNG_EXYNOS_FIMD, /* Exynos Display controller */
   COMPAT_SAMSUNG_EXYNOS5_DP,  /* Exynos Display port controller */
   COMPAT_SAMSUNG_EXYNOS5_DWMMC,   /* Exynos5 DWMMC controller */
 + COMPAT_SAMSUNG_EXYNOS_SERIAL,   /* Exynos UART */
   COMPAT_MAXIM_MAX77686_PMIC, /* MAX77686 PMIC */
   COMPAT_GENERIC_SPI_FLASH,   /* Generic SPI Flash chip */
   COMPAT_MAXIM_98095_CODEC,   /* MAX98095 Codec */
 diff --git a/lib/fdtdec.c b/lib/fdtdec.c
 index e3142cb..d1acc35 100644
 --- a/lib/fdtdec.c
 +++ b/lib/fdtdec.c
 @@ -63,6 +63,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
   COMPAT(SAMSUNG_EXYNOS_FIMD, samsung,exynos-fimd),
   COMPAT(SAMSUNG_EXYNOS5_DP, samsung,exynos5-dp),
   COMPAT(SAMSUNG_EXYNOS5_DWMMC, samsung,exynos5250-dwmmc),
 + COMPAT(SAMSUNG_EXYNOS_SERIAL, samsung,exynos4210-uart),

 Is it exynos4210 specific?
 If not, how about exynos-uart?
We use samsung,exynos4210-uart to keep it same as it is in kernel.
This was changed after a commnet from Simon
http://lists.denx.de/pipermail/u-boot/2013-March/148095.html

   COMPAT(MAXIM_MAX77686_PMIC, maxim,max77686_pmic),
   COMPAT(GENERIC_SPI_FLASH, spi-flash),
   COMPAT(MAXIM_98095_CODEC, maxim,max98095-codec),


 Thanks,
 Minkyu Kang.

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
-- 
Regards,
Rajeshwari Shinde
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot