Re: [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms
On Fri, 2014-07-04 at 17:44 +0200, Marek Vasut wrote: > On Friday, July 04, 2014 at 05:26:40 PM, Ian Campbell wrote: > > On Fri, 2014-07-04 at 16:58 +0200, Marek Vasut wrote: > > > On Saturday, May 31, 2014 at 06:36:11 PM, Ian Campbell wrote: > > > > In 73545f75b66d "ahci: wait longer for link" I increased the > > > > timeout to 40ms based on the observed behaviour of a WD disk on a > > > > Cubietruck. Since then Karsten Merker and myself have both > > > > observed timeouts with HGST disks (Karsten on Cubietruck, me on > > > > Cubieboard2). Increasing the timeout to ~175ms fixes this, so go > > > > to 200ms for a bit of headroom. > > > > > > > > Signed-off-by: Ian Campbell > > > > Cc: Karsten Merker > > > > > > Is there no way to poll for this condition instead of using an > > > ever-growing timeout? > > > > This timeout is the maximum time to poll for. If the device is ready > > sooner (likely) then we'll notice that and carry one. > > And if the device is never ready, then we will wait 200mS for nothing ? If you've typed "scsi scan", yes. Does u-boot have any mechanisms to do anything else though? Ian. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms
On Friday, July 04, 2014 at 05:26:40 PM, Ian Campbell wrote: > On Fri, 2014-07-04 at 16:58 +0200, Marek Vasut wrote: > > On Saturday, May 31, 2014 at 06:36:11 PM, Ian Campbell wrote: > > > In 73545f75b66d "ahci: wait longer for link" I increased the > > > timeout to 40ms based on the observed behaviour of a WD disk on a > > > Cubietruck. Since then Karsten Merker and myself have both > > > observed timeouts with HGST disks (Karsten on Cubietruck, me on > > > Cubieboard2). Increasing the timeout to ~175ms fixes this, so go > > > to 200ms for a bit of headroom. > > > > > > Signed-off-by: Ian Campbell > > > Cc: Karsten Merker > > > > Is there no way to poll for this condition instead of using an > > ever-growing timeout? > > This timeout is the maximum time to poll for. If the device is ready > sooner (likely) then we'll notice that and carry one. And if the device is never ready, then we will wait 200mS for nothing ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms
On Fri, 2014-07-04 at 16:58 +0200, Marek Vasut wrote: > On Saturday, May 31, 2014 at 06:36:11 PM, Ian Campbell wrote: > > In 73545f75b66d "ahci: wait longer for link" I increased the > > timeout to 40ms based on the observed behaviour of a WD disk on a > > Cubietruck. Since then Karsten Merker and myself have both > > observed timeouts with HGST disks (Karsten on Cubietruck, me on > > Cubieboard2). Increasing the timeout to ~175ms fixes this, so go > > to 200ms for a bit of headroom. > > > > Signed-off-by: Ian Campbell > > Cc: Karsten Merker > > Is there no way to poll for this condition instead of using an ever-growing > timeout? This timeout is the maximum time to poll for. If the device is ready sooner (likely) then we'll notice that and carry one. Ian. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms
On Saturday, May 31, 2014 at 06:36:11 PM, Ian Campbell wrote: > In 73545f75b66d "ahci: wait longer for link" I increased the > timeout to 40ms based on the observed behaviour of a WD disk on a > Cubietruck. Since then Karsten Merker and myself have both > observed timeouts with HGST disks (Karsten on Cubietruck, me on > Cubieboard2). Increasing the timeout to ~175ms fixes this, so go > to 200ms for a bit of headroom. > > Signed-off-by: Ian Campbell > Cc: Karsten Merker Is there no way to poll for this condition instead of using an ever-growing timeout? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
