Re: [U-Boot] [PATCH 10/12] dt: socfpga: Import and enable Arria V DK DTS

2015-01-30 Thread Marek Vasut 
On Sunday, January 18, 2015 at 07:21:34 AM, Dinh Nguyen wrote:
 On 12/31/14 1:14 PM, Marek Vasut wrote:

[...]

  diff --git a/arch/arm/dts/socfpga_arria5.dtsi
  b/arch/arm/dts/socfpga_arria5.dtsi new file mode 100644
  index 000..5175f03
  --- /dev/null
  +++ b/arch/arm/dts/socfpga_arria5.dtsi
  @@ -0,0 +1,34 @@
  +/*
  + *  Copyright (C) 2013 Altera Corporation www.altera.com
 
 Nit: extra space before Copyright.

Hi!

Sorry for the late reply. This DTS comes from mainline Linux, so
I wonder if it makes sense to diverge here, especially since this
is just a comment. Diverging in the DTS files would make it more
annoying in the long run, since checking the differences between
Linux and U-Boot would spit this one false positive.

What do you think please ?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/12] dt: socfpga: Import and enable Arria V DK DTS

2015-01-17 Thread Dinh Nguyen 


On 12/31/14 1:14 PM, Marek Vasut wrote:
 Import DTS for Arria V development kit and enable support
 for DT. The DT is imported from Linux 3.19-rc1 as of commit
 97bf6af1f928216fd6c5a66e8a57bfa95a659672 .
 
 Signed-off-by: Marek Vasut ma...@denx.de
 Cc: Chin Liang See cl...@opensource.altera.com
 Cc: Dinh Nguyen dingu...@opensource.altera.com
 Cc: Pavel Machek pa...@denx.de
 Cc: Stefan Roese s...@denx.de
 Cc: Vince Bridgers vbrid...@opensource.altera.com
 ---
  arch/arm/dts/Makefile |  1 +
  arch/arm/dts/socfpga_arria5.dtsi  | 34 
  arch/arm/dts/socfpga_arria5_socdk.dts | 74 
 +++
  configs/socfpga_arria5_defconfig  |  2 +
  4 files changed, 111 insertions(+)
  create mode 100644 arch/arm/dts/socfpga_arria5.dtsi
  create mode 100644 arch/arm/dts/socfpga_arria5_socdk.dts
 
 diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
 index c851d65..2a84323 100644
 --- a/arch/arm/dts/Makefile
 +++ b/arch/arm/dts/Makefile
 @@ -49,6 +49,7 @@ dtb-$(CONFIG_ZYNQ) += zynq-zc702.dtb \
  dtb-$(CONFIG_AM33XX) += am335x-boneblack.dtb
  
  dtb-$(CONFIG_SOCFPGA) += \
 + socfpga_arria5_socdk.dtb\
   socfpga_cyclone5_socdk.dtb  \
   socfpga_cyclone5_socrates.dtb
  
 diff --git a/arch/arm/dts/socfpga_arria5.dtsi 
 b/arch/arm/dts/socfpga_arria5.dtsi
 new file mode 100644
 index 000..5175f03
 --- /dev/null
 +++ b/arch/arm/dts/socfpga_arria5.dtsi
 @@ -0,0 +1,34 @@
 +/*
 + *  Copyright (C) 2013 Altera Corporation www.altera.com

Nit: extra space before Copyright.

 + *
 + * SPDX-License-Identifier:  GPL-2.0+
 + */
 +
 +/dts-v1/;
 +/* First 4KB has trampoline code for secondary cores. */
 +/memreserve/ 0x 0x0001000;
 +#include socfpga.dtsi
 +
 +/ {
 + soc {
 + clkmgr@ffd04000 {
 + clocks {
 + osc1 {
 + clock-frequency = 2500;
 + };
 + };
 + };
 +
 + mmc0: dwmmc0@ff704000 {
 + num-slots = 1;
 + broken-cd;
 + bus-width = 4;
 + cap-mmc-highspeed;
 + cap-sd-highspeed;
 + };
 +
 + sysmgr@ffd08000 {
 + cpu1-start-addr = 0xffd080c4;
 + };
 + };
 +};
 diff --git a/arch/arm/dts/socfpga_arria5_socdk.dts 
 b/arch/arm/dts/socfpga_arria5_socdk.dts
 new file mode 100644
 index 000..4e529a1
 --- /dev/null
 +++ b/arch/arm/dts/socfpga_arria5_socdk.dts
 @@ -0,0 +1,74 @@
 +/*
 + *  Copyright (C) 2013 Altera Corporation www.altera.com

Same nit

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/12] dt: socfpga: Import and enable Arria V DK DTS

2015-01-03 Thread Pavel Machek 
On Wed 2014-12-31 20:14:58, Marek Vasut wrote:
 Import DTS for Arria V development kit and enable support
 for DT. The DT is imported from Linux 3.19-rc1 as of commit
 97bf6af1f928216fd6c5a66e8a57bfa95a659672 .
 
 Signed-off-by: Marek Vasut ma...@denx.de
 Cc: Chin Liang See cl...@opensource.altera.com
 Cc: Dinh Nguyen dingu...@opensource.altera.com

Acked-by: Pavel Machek pa...@denx.de

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/12] dt: socfpga: Import and enable Arria V DK DTS

2015-01-03 Thread Stefan Roese 

On 31.12.2014 20:14, Marek Vasut wrote:

Import DTS for Arria V development kit and enable support
for DT. The DT is imported from Linux 3.19-rc1 as of commit
97bf6af1f928216fd6c5a66e8a57bfa95a659672 .

Signed-off-by: Marek Vasut ma...@denx.de
Cc: Chin Liang See cl...@opensource.altera.com
Cc: Dinh Nguyen dingu...@opensource.altera.com
Cc: Pavel Machek pa...@denx.de
Cc: Stefan Roese s...@denx.de
Cc: Vince Bridgers vbrid...@opensource.altera.com


Reviewed-by: Stefan Roese s...@denx.de

Thanks,
Stefan

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot