Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox
Hi Simon, Am 23.07.2016 um 04:31 schrieb Simon Glass: > On 18 July 2016 at 06:13, Heiko Stübner wrote: >> Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber: >>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig >>> index 86b77f8..597f043 100644 >>> --- a/arch/arm/mach-rockchip/Kconfig >>> +++ b/arch/arm/mach-rockchip/Kconfig >>> @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP >>> config ROCKCHIP_RK3288 >>> bool "Support Rockchip RK3288" >>> select CPU_V7 >>> + select SUPPORT_SPL >>> + select SPL >>> + select SPL_DM >>> + select SPL_SYS_MALLOC_SIMPLE >>> help >>> The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17 >>> including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two >>> @@ -13,12 +17,21 @@ config ROCKCHIP_RK3288 >>> config ROCKCHIP_RK3036 >>> bool "Support Rockchip RK3036" >>> select CPU_V7 >>> + select SUPPORT_SPL >>> + select SPL >>> + select SPL_DM >>> + select SPL_SYS_MALLOC_SIMPLE >>> help >>> The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7 >>> including NEON and GPU, Mali-400 graphics, several DDR3 options >>> and video codec support. Peripherals include Gigabit Ethernet, >>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs. >> >> looks like both you and Kever need that separation of the SPL symbols (me as >> well for the rk3188 for the time being), so it might make sense to split that >> out into a separate patch, all could use. >> >> I guess it might also make it easier for Simon to find an order to apply the >> patches? > > Yes. Andreas, can you please resent your patches against > u-boot-rockchip/master? I had done that and thereby ran into the mismerges I pointed out. ;) Didn't send that blown-up version out since you suggested an rk3399 resend, which came once I was unavailable over the extended weekend... > Also it needs a MAINTAINERS file I think. True. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox
Hi, On 18 July 2016 at 06:13, Heiko Stübner wrote: > Hi Andreas, > > Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber: >> The RK3368 is an octa-core Cortex-A53 SoC from Rockchip. >> >> The GeekBox is a TV box from GeekBuying, based on an MXM3 module. >> The module can be used with base boards such as the GeekBox Landingship. >> >> This adds basic support to chain-load U-Boot from Rockchip's miniloader. >> >> $ ./lollipop_u-boot/tools/loaderimage --pack u-boot.bin u-boot.img >> # ./utils/upgrade_tool di uboot u-boot.img >> >> Implemented is the serial console, but no boot media drivers yet. >> >> Note that flashing the resulting U-Boot will not allow you to enter the >> rockusb mode any more via "Update" button. Instead, you will need to >> short two pins on the bottom of the module to enter MaskRom mode and >> re-flash the loader: >> >> # ./utils/upgrade_tool ul ./lollipop_u-boot/RK3368MiniLoaderAll_V2.40.bin >> # ./utils/upgrade_tool di uboot u-boot.img >> >> Signed-off-by: Andreas Färber >> --- >> arch/arm/Kconfig | 4 --- >> arch/arm/dts/rk3368.dtsi | 1 + >> arch/arm/mach-rockchip/Kconfig | 14 ++ >> arch/arm/mach-rockchip/Makefile| 1 + >> arch/arm/mach-rockchip/rk3368/Kconfig | 14 ++ >> arch/arm/mach-rockchip/rk3368/Makefile | 7 + >> arch/arm/mach-rockchip/rk3368/rk3368.c | 28 >> board/geekbuying/geekbox/Kconfig | 15 +++ >> board/geekbuying/geekbox/Makefile | 7 + >> board/geekbuying/geekbox/geekbox.c | 26 +++ >> configs/geekbox_defconfig | 20 +++ >> include/configs/geekbox.h | 19 ++ >> include/configs/rk3368_common.h| 47 >> ++ 13 files changed, 199 insertions(+), 4 >> deletions(-) >> create mode 100644 arch/arm/mach-rockchip/rk3368/Kconfig >> create mode 100644 arch/arm/mach-rockchip/rk3368/Makefile >> create mode 100644 arch/arm/mach-rockchip/rk3368/rk3368.c >> create mode 100644 board/geekbuying/geekbox/Kconfig >> create mode 100644 board/geekbuying/geekbox/Makefile >> create mode 100644 board/geekbuying/geekbox/geekbox.c >> create mode 100644 configs/geekbox_defconfig >> create mode 100644 include/configs/geekbox.h >> create mode 100644 include/configs/rk3368_common.h >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index f9fddad..4ff1a26 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -838,14 +838,10 @@ config STM32 >> >> config ARCH_ROCKCHIP >> bool "Support Rockchip SoCs" >> - select SUPPORT_SPL >> - select SPL >> select OF_CONTROL >> select BLK >> select DM >> - select SPL_DM >> select SYS_MALLOC_F >> - select SPL_SYS_MALLOC_SIMPLE >> select DM_GPIO >> select DM_I2C >> select DM_MMC > [...] >> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig >> index 86b77f8..597f043 100644 >> --- a/arch/arm/mach-rockchip/Kconfig >> +++ b/arch/arm/mach-rockchip/Kconfig >> @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP >> config ROCKCHIP_RK3288 >> bool "Support Rockchip RK3288" >> select CPU_V7 >> + select SUPPORT_SPL >> + select SPL >> + select SPL_DM >> + select SPL_SYS_MALLOC_SIMPLE >> help >> The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17 >> including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two >> @@ -13,12 +17,21 @@ config ROCKCHIP_RK3288 >> config ROCKCHIP_RK3036 >> bool "Support Rockchip RK3036" >> select CPU_V7 >> + select SUPPORT_SPL >> + select SPL >> + select SPL_DM >> + select SPL_SYS_MALLOC_SIMPLE >> help >> The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7 >> including NEON and GPU, Mali-400 graphics, several DDR3 options >> and video codec support. Peripherals include Gigabit Ethernet, >> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs. > > looks like both you and Kever need that separation of the SPL symbols (me as > well for the rk3188 for the time being), so it might make sense to split that > out into a separate patch, all could use. > > I guess it might also make it easier for Simon to find an order to apply the > patches? Yes. Andreas, can you please resent your patches against u-boot-rockchip/master? Also it needs a MAINTAINERS file I think. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox
Hi Andreas, Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber: > The RK3368 is an octa-core Cortex-A53 SoC from Rockchip. > > The GeekBox is a TV box from GeekBuying, based on an MXM3 module. > The module can be used with base boards such as the GeekBox Landingship. > > This adds basic support to chain-load U-Boot from Rockchip's miniloader. > > $ ./lollipop_u-boot/tools/loaderimage --pack u-boot.bin u-boot.img > # ./utils/upgrade_tool di uboot u-boot.img > > Implemented is the serial console, but no boot media drivers yet. > > Note that flashing the resulting U-Boot will not allow you to enter the > rockusb mode any more via "Update" button. Instead, you will need to > short two pins on the bottom of the module to enter MaskRom mode and > re-flash the loader: > > # ./utils/upgrade_tool ul ./lollipop_u-boot/RK3368MiniLoaderAll_V2.40.bin > # ./utils/upgrade_tool di uboot u-boot.img > > Signed-off-by: Andreas Färber > --- > arch/arm/Kconfig | 4 --- > arch/arm/dts/rk3368.dtsi | 1 + > arch/arm/mach-rockchip/Kconfig | 14 ++ > arch/arm/mach-rockchip/Makefile| 1 + > arch/arm/mach-rockchip/rk3368/Kconfig | 14 ++ > arch/arm/mach-rockchip/rk3368/Makefile | 7 + > arch/arm/mach-rockchip/rk3368/rk3368.c | 28 > board/geekbuying/geekbox/Kconfig | 15 +++ > board/geekbuying/geekbox/Makefile | 7 + > board/geekbuying/geekbox/geekbox.c | 26 +++ > configs/geekbox_defconfig | 20 +++ > include/configs/geekbox.h | 19 ++ > include/configs/rk3368_common.h| 47 > ++ 13 files changed, 199 insertions(+), 4 > deletions(-) > create mode 100644 arch/arm/mach-rockchip/rk3368/Kconfig > create mode 100644 arch/arm/mach-rockchip/rk3368/Makefile > create mode 100644 arch/arm/mach-rockchip/rk3368/rk3368.c > create mode 100644 board/geekbuying/geekbox/Kconfig > create mode 100644 board/geekbuying/geekbox/Makefile > create mode 100644 board/geekbuying/geekbox/geekbox.c > create mode 100644 configs/geekbox_defconfig > create mode 100644 include/configs/geekbox.h > create mode 100644 include/configs/rk3368_common.h > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index f9fddad..4ff1a26 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -838,14 +838,10 @@ config STM32 > > config ARCH_ROCKCHIP > bool "Support Rockchip SoCs" > - select SUPPORT_SPL > - select SPL > select OF_CONTROL > select BLK > select DM > - select SPL_DM > select SYS_MALLOC_F > - select SPL_SYS_MALLOC_SIMPLE > select DM_GPIO > select DM_I2C > select DM_MMC [...] > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index 86b77f8..597f043 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP > config ROCKCHIP_RK3288 > bool "Support Rockchip RK3288" > select CPU_V7 > + select SUPPORT_SPL > + select SPL > + select SPL_DM > + select SPL_SYS_MALLOC_SIMPLE > help > The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17 > including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two > @@ -13,12 +17,21 @@ config ROCKCHIP_RK3288 > config ROCKCHIP_RK3036 > bool "Support Rockchip RK3036" > select CPU_V7 > + select SUPPORT_SPL > + select SPL > + select SPL_DM > + select SPL_SYS_MALLOC_SIMPLE > help > The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7 > including NEON and GPU, Mali-400 graphics, several DDR3 options > and video codec support. Peripherals include Gigabit Ethernet, > USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs. looks like both you and Kever need that separation of the SPL symbols (me as well for the rk3188 for the time being), so it might make sense to split that out into a separate patch, all could use. I guess it might also make it easier for Simon to find an order to apply the patches? Heiko ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox
Hi Andreas, On 17 July 2016 at 19:06, Andreas Färber wrote: > The RK3368 is an octa-core Cortex-A53 SoC from Rockchip. > > The GeekBox is a TV box from GeekBuying, based on an MXM3 module. > The module can be used with base boards such as the GeekBox Landingship. > > This adds basic support to chain-load U-Boot from Rockchip's miniloader. > > $ ./lollipop_u-boot/tools/loaderimage --pack u-boot.bin u-boot.img > # ./utils/upgrade_tool di uboot u-boot.img > > Implemented is the serial console, but no boot media drivers yet. > > Note that flashing the resulting U-Boot will not allow you to enter the > rockusb mode any more via "Update" button. Instead, you will need to > short two pins on the bottom of the module to enter MaskRom mode and > re-flash the loader: > > # ./utils/upgrade_tool ul ./lollipop_u-boot/RK3368MiniLoaderAll_V2.40.bin > # ./utils/upgrade_tool di uboot u-boot.img > > Signed-off-by: Andreas Färber > --- > arch/arm/Kconfig | 4 --- > arch/arm/dts/rk3368.dtsi | 1 + > arch/arm/mach-rockchip/Kconfig | 14 ++ > arch/arm/mach-rockchip/Makefile| 1 + > arch/arm/mach-rockchip/rk3368/Kconfig | 14 ++ > arch/arm/mach-rockchip/rk3368/Makefile | 7 + > arch/arm/mach-rockchip/rk3368/rk3368.c | 28 > board/geekbuying/geekbox/Kconfig | 15 +++ > board/geekbuying/geekbox/Makefile | 7 + > board/geekbuying/geekbox/geekbox.c | 26 +++ > configs/geekbox_defconfig | 20 +++ > include/configs/geekbox.h | 19 ++ > include/configs/rk3368_common.h| 47 > ++ > 13 files changed, 199 insertions(+), 4 deletions(-) > create mode 100644 arch/arm/mach-rockchip/rk3368/Kconfig > create mode 100644 arch/arm/mach-rockchip/rk3368/Makefile > create mode 100644 arch/arm/mach-rockchip/rk3368/rk3368.c > create mode 100644 board/geekbuying/geekbox/Kconfig > create mode 100644 board/geekbuying/geekbox/Makefile > create mode 100644 board/geekbuying/geekbox/geekbox.c > create mode 100644 configs/geekbox_defconfig > create mode 100644 include/configs/geekbox.h > create mode 100644 include/configs/rk3368_common.h Acked-by: Simon Glass Can you please also send a README in board/geekbuying/geekbox with the flashing info from your cover letter? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox
Am 18.07.2016 um 03:06 schrieb Andreas Färber:
> The RK3368 is an octa-core Cortex-A53 SoC from Rockchip.
>
> The GeekBox is a TV box from GeekBuying, based on an MXM3 module.
> The module can be used with base boards such as the GeekBox Landingship.
>
> This adds basic support to chain-load U-Boot from Rockchip's miniloader.
>
> $ ./lollipop_u-boot/tools/loaderimage --pack u-boot.bin u-boot.img
> # ./utils/upgrade_tool di uboot u-boot.img
>
> Implemented is the serial console, but no boot media drivers yet.
>
> Note that flashing the resulting U-Boot will not allow you to enter the
> rockusb mode any more via "Update" button. Instead, you will need to
> short two pins on the bottom of the module to enter MaskRom mode and
> re-flash the loader:
>
> # ./utils/upgrade_tool ul ./lollipop_u-boot/RK3368MiniLoaderAll_V2.40.bin
> # ./utils/upgrade_tool di uboot u-boot.img
>
> Signed-off-by: Andreas Färber
> ---
> arch/arm/Kconfig | 4 ---
> arch/arm/dts/rk3368.dtsi | 1 +
> arch/arm/mach-rockchip/Kconfig | 14 ++
> arch/arm/mach-rockchip/Makefile| 1 +
> arch/arm/mach-rockchip/rk3368/Kconfig | 14 ++
> arch/arm/mach-rockchip/rk3368/Makefile | 7 +
> arch/arm/mach-rockchip/rk3368/rk3368.c | 28
> board/geekbuying/geekbox/Kconfig | 15 +++
> board/geekbuying/geekbox/Makefile | 7 +
> board/geekbuying/geekbox/geekbox.c | 26 +++
> configs/geekbox_defconfig | 20 +++
> include/configs/geekbox.h | 19 ++
> include/configs/rk3368_common.h| 47
> ++
> 13 files changed, 199 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/mach-rockchip/rk3368/Kconfig
> create mode 100644 arch/arm/mach-rockchip/rk3368/Makefile
> create mode 100644 arch/arm/mach-rockchip/rk3368/rk3368.c
> create mode 100644 board/geekbuying/geekbox/Kconfig
> create mode 100644 board/geekbuying/geekbox/Makefile
> create mode 100644 board/geekbuying/geekbox/geekbox.c
> create mode 100644 configs/geekbox_defconfig
> create mode 100644 include/configs/geekbox.h
> create mode 100644 include/configs/rk3368_common.h
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f9fddad..4ff1a26 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -838,14 +838,10 @@ config STM32
>
> config ARCH_ROCKCHIP
> bool "Support Rockchip SoCs"
> - select SUPPORT_SPL
> - select SPL
> select OF_CONTROL
> select BLK
> select DM
> - select SPL_DM
> select SYS_MALLOC_F
> - select SPL_SYS_MALLOC_SIMPLE
> select DM_GPIO
> select DM_I2C
> select DM_MMC
> diff --git a/arch/arm/dts/rk3368.dtsi b/arch/arm/dts/rk3368.dtsi
> index 8b4a7c9..3ab7edc 100644
> --- a/arch/arm/dts/rk3368.dtsi
> +++ b/arch/arm/dts/rk3368.dtsi
> @@ -609,6 +609,7 @@
> uart2: serial@ff69 {
> compatible = "rockchip,rk3368-uart", "snps,dw-apb-uart";
> reg = <0x0 0xff69 0x0 0x100>;
> + clock-frequency = <2400>;
> clocks = <&cru SCLK_UART2>, <&cru PCLK_UART2>;
> clock-names = "baudclk", "apb_pclk";
> interrupts = ;
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 86b77f8..597f043 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP
> config ROCKCHIP_RK3288
> bool "Support Rockchip RK3288"
> select CPU_V7
> + select SUPPORT_SPL
> + select SPL
> + select SPL_DM
> + select SPL_SYS_MALLOC_SIMPLE
> help
> The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
> including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
> @@ -13,12 +17,21 @@ config ROCKCHIP_RK3288
> config ROCKCHIP_RK3036
> bool "Support Rockchip RK3036"
> select CPU_V7
> + select SUPPORT_SPL
> + select SPL
> + select SPL_DM
> + select SPL_SYS_MALLOC_SIMPLE
> help
> The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7
> including NEON and GPU, Mali-400 graphics, several DDR3 options
> and video codec support. Peripherals include Gigabit Ethernet,
> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>
> +config ROCKCHIP_RK3368
> + bool "Support Rockchip RK3368"
> + select ARM64
> + select SYS_NS16550
> +
> config ROCKCHIP_SPL_BACK_TO_BROM
> bool "SPL returns to bootrom"
> default y if ROCKCHIP_RK3036
> @@ -29,4 +42,5 @@ config ROCKCHIP_SPL_BACK_TO_BROM
>
> source "arch/arm/mach-rockchip/rk3288/Kconfig"
> source "arch/arm/mach-rockchip/rk3036/Kconfig"
> +source "arch/arm/mach-rockchip/rk3368/Kconfig"
> endif
> diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile
> index 6763af4..48e78c1 100644
> --- a/arch/arm/mach-
