Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
Dear Albin Tonnerre, In message 1249641457-16887-2-git-send-email-albin.tonne...@free-electrons.com you wrote: The Calao TNY-A9260 and TNY-9G20 are boards manufactured and sold by Calao Systems http://www.calao-systems.com. Their components are very similar to the AT91SAM9260EK board, so their configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, no ethernet. They also can use SPI EEPROM to store the environment. ... --- a/Makefile +++ b/Makefile @@ -2838,6 +2838,25 @@ at91sam9g45ekes_config : unconfig pm9263_config: unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +tny_a9g20_nandflash_config \ +tny_a9g20_eeprom_config \ +tny_a9g20_config \ +tny_a9260_nandflash_config \ +tny_a9260_eeprom_config \ +tny_a9260_config : unconfig + @mkdir -p $(obj)include + @if [ $(findstring _nandflash,$@) ] ; then \ + echo #define CONFIG_ENV_IS_IN_NAND $(obj)include/config.h ; \ + else \ + echo #define CONFIG_ENV_IS_IN_EEPROM $(obj)include/config.h ; \ + fi; + @if [ $(findstring _a9g20,$@) ] ; then \ + echo #define CONFIG_TNY_A9G20 $(obj)include/config.h ; \ + else \ + echo #define CONFIG_TNY_A9260 $(obj)include/config.h ; \ + fi; + @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 Please do not add such scripting to the top level Makefile. Perform it in your board config file instead. For an example, please see http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A father doesn't destroy his children. -- Lt. Carolyn Palamas, Who Mourns for Adonais?, stardate 3468.1. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
On Sun, Aug 09, 2009 at 10:38:25PM +0200, Wolfgang Denk wrote : Dear Albin Tonnerre, Hi Wolfgang, In message 1249641457-16887-2-git-send-email-albin.tonne...@free-electrons.com you wrote: +tny_a9g20_nandflash_config \ +tny_a9g20_eeprom_config \ +tny_a9g20_config \ +tny_a9260_nandflash_config \ +tny_a9260_eeprom_config \ +tny_a9260_config : unconfig + @mkdir -p $(obj)include + @if [ $(findstring _nandflash,$@) ] ; then \ + echo #define CONFIG_ENV_IS_IN_NAND $(obj)include/config.h ; \ + else \ + echo #define CONFIG_ENV_IS_IN_EEPROM $(obj)include/config.h ; \ + fi; + @if [ $(findstring _a9g20,$@) ] ; then \ + echo #define CONFIG_TNY_A9G20 $(obj)include/config.h ; \ + else \ + echo #define CONFIG_TNY_A9260 $(obj)include/config.h ; \ + fi; + @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 Please do not add such scripting to the top level Makefile. Perform it in your board config file instead. For an example, please see http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499 Thanks for the pointer. As the patch is already part of Jean-Christophe's ARM pull request, do you mind if I provide a patch on top of the current one to fix the issue, or do you want me to resubmit the whole patch ? Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
On 12:37 Fri 07 Aug , Albin Tonnerre wrote: The Calao TNY-A9260 and TNY-9G20 are boards manufactured and sold by Calao Systems http://www.calao-systems.com. Their components are very similar to the AT91SAM9260EK board, so their configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, no ethernet. They also can use SPI EEPROM to store the environment. Signed-off-by: Albin Tonnerre albin.tonne...@free-electrons.com --- MAINTAINERS |4 + MAKEALL |1 + Makefile | 19 board/calao/tny_a9260/Makefile | 55 ++ board/calao/tny_a9260/config.mk |1 + board/calao/tny_a9260/spi.c | 50 + board/calao/tny_a9260/tny_a9260.c| 110 cpu/arm926ejs/at91/at91sam9260_devices.c |2 +- include/configs/tny_a9260.h | 164 ++ 9 files changed, 405 insertions(+), 1 deletions(-) create mode 100644 board/calao/tny_a9260/Makefile create mode 100644 board/calao/tny_a9260/config.mk create mode 100644 board/calao/tny_a9260/spi.c create mode 100644 board/calao/tny_a9260/tny_a9260.c create mode 100644 include/configs/tny_a9260.h Acked-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
Some general comment
please add space before and after '*' co
and the ligne length limit in 80 chars
+/* Env, bootstrap and u-boot in NAND */
+#ifdef CONFIG_ENV_IS_IN_NAND
+#define CONFIG_ENV_OFFSET 0x6
+#define CONFIG_ENV_OFFSET_REDUND 0x8
+#define CONFIG_ENV_SIZE 0x2
+#endif
+
+#define CONFIG_BOOTCOMMAND nboot 0x2100 0 40
+#define CONFIG_BOOTARGS console=ttyS0,115200 \
+ root=/dev/mtdblock1 \
+
mtdparts=atmel_nand:16M(kernel)ro, \
+ 120M(rootfs),-(other)
\
+ rw rootfstype=jffs2
here as example
+
+#define CONFIG_BAUDRATE 115200
+#define CONFIG_SYS_BAUDRATE_TABLE{115200 , 19200, 38400, 57600, 9600 }
+
+#define CONFIG_SYS_PROMPTU-Boot
+#define CONFIG_SYS_CBSIZE256
+#define CONFIG_SYS_MAXARGS 16
+#define CONFIG_SYS_PBSIZE(CONFIG_SYS_CBSIZE +
sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_LONGHELP 1
+#define CONFIG_CMDLINE_EDITING 1
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LENROUND(3 * CONFIG_ENV_SIZE +
128*1024, 0x1000)
+#define CONFIG_SYS_GBL_DATA_SIZE 128 /* 128 bytes for initial data */
+
+#define CONFIG_STACKSIZE (32*1024) /* regular stack */
here too etc..
+
+#ifdef CONFIG_USE_IRQ
+#error CONFIG_USE_IRQ not supported
+#endif
Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
On Wed, Aug 05, 2009 at 09:30:11PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : Some general comment please add space before and after '*' co and the ligne length limit in 80 chars Fine. Please note that you could have pointed this out earlier, though. That would have saved both of us some time. Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
On 21:45 Wed 05 Aug , Albin Tonnerre wrote: On Wed, Aug 05, 2009 at 09:30:11PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : Some general comment please add space before and after '*' co and the ligne length limit in 80 chars Fine. Please note that you could have pointed this out earlier, though. That would have saved both of us some time. this part was updated between the 2 versions of the patch so I put a comment if you have one line which is a few more than 80 chars ok but now you increase it's number so I notice you about it otherwise the patch is clean Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
