Re: [U-Boot] [PATCH 2/2 v2] gpio_led: add gpio_request to __led_init
On 06/16/2010 09:29 AM, Scott McNutt wrote: Applied to: git://git.denx.de/u-boot-nios.git next Thanks, --Scott Dear Scott, Would you please send a pull request to Wolfgang? Best regards, Thomas Thomas Chou wrote: This patch adds the gpio usage request. The polarity is changed to positive as suggested by Mike Frysinger. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2: fix typo, change led polarity drivers/misc/gpio_led.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c index acd6a90..3fedddc 100644 --- a/drivers/misc/gpio_led.c +++ b/drivers/misc/gpio_led.c @@ -2,26 +2,22 @@ * Status LED driver based on GPIO access conventions of Linux * * Copyright (C) 2010 Thomas Chou tho...@wytron.com.tw - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. + * Licensed under the GPL-2 or later. */ #include common.h #include status_led.h #include asm/gpio.h -/* assume led is active low */ - void __led_init(led_id_t mask, int state) { - gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1); + gpio_request(mask, gpio_led); + gpio_direction_output(mask, state == STATUS_LED_ON); } void __led_set(led_id_t mask, int state) { - gpio_set_value(mask, (state == STATUS_LED_ON) ? 0 : 1); + gpio_set_value(mask, state == STATUS_LED_ON); } void __led_toggle(led_id_t mask) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 v2] gpio_led: add gpio_request to __led_init
Applied to: git://git.denx.de/u-boot-nios.git next Thanks, --Scott Thomas Chou wrote: This patch adds the gpio usage request. The polarity is changed to positive as suggested by Mike Frysinger. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2: fix typo, change led polarity drivers/misc/gpio_led.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c index acd6a90..3fedddc 100644 --- a/drivers/misc/gpio_led.c +++ b/drivers/misc/gpio_led.c @@ -2,26 +2,22 @@ * Status LED driver based on GPIO access conventions of Linux * * Copyright (C) 2010 Thomas Chou tho...@wytron.com.tw - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. + * Licensed under the GPL-2 or later. */ #include common.h #include status_led.h #include asm/gpio.h -/* assume led is active low */ - void __led_init(led_id_t mask, int state) { - gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1); + gpio_request(mask, gpio_led); + gpio_direction_output(mask, state == STATUS_LED_ON); } void __led_set(led_id_t mask, int state) { - gpio_set_value(mask, (state == STATUS_LED_ON) ? 0 : 1); + gpio_set_value(mask, state == STATUS_LED_ON); } void __led_toggle(led_id_t mask) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot