Re: [U-Boot] [PATCH 2/2 v7] Add support for MINI2440 (s3c2440).

2012-04-30 Thread Marek Vasut
Dear Gabriel Huau,

 Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr
 ---
 Changes for v2:
   - Coding style cleanup
   - Remove unnecessary files modification
   - Remove unnecessary board configuration set
 
 Changes for v3:
   - Coding style cleanup
   - Move some macro definition from lowlevel_init.S
 to a new header
   - Remove some magic bloat with I/O board initialization
   - Add a pll_delay and replace loop by it
   - Somme cleanup in the configuration file
   - Cancel modifications on an SoC specific header
   - Add my name to copyright
 
 Changes for v4:
   - Move dram init to dram_init() instead low_levelinit
   - Remove u  -boot env from configuration file and change
 the address of initial SP
   - Remove PLL init, now it's SoC specific
 
 Changes for v5:
   - Clean up configuration file
   - Add a MAINTAINERS entry
   - Add a README.mini2440 file
   - Use gpio/iomux interface in case of magic numbers
   - Use get_ram_size()
 
 Changes for v6:
   - Coding style cleanup
   - Remove some unused define in the board config
 
 Changes for v7:
   - Cleanup coding style
   - Changement of the commit message
 
  MAINTAINERS   |4 +
  board/friendlyarm/mini2440/Makefile   |   44 
  board/friendlyarm/mini2440/mini2440.c |  134 
  board/friendlyarm/mini2440/mini2440.h |  144 +
  boards.cfg|1 +
  doc/README.mini2440   |   28 +
  include/configs/mini2440.h|  186
 + 7 files changed, 541 insertions(+)
  create mode 100644 board/friendlyarm/mini2440/Makefile
  create mode 100644 board/friendlyarm/mini2440/mini2440.c
  create mode 100644 board/friendlyarm/mini2440/mini2440.h
  create mode 100644 doc/README.mini2440
  create mode 100644 include/configs/mini2440.h
 
 diff --git a/MAINTAINERS b/MAINTAINERS
 index 708ded7..2611fb5 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -566,6 +566,10 @@ Unknown / orphaned boards:
  #Board   CPU #
  #
 
 +Gabriel HUAU cont...@huau-gabriel.fr
 +
 + mini2440s3c2440
 +
  Albert ARIBAUD albert.u.b...@aribaud.net
 
   edminiv2ARM926EJS (Orion5x SoC)
 diff --git a/board/friendlyarm/mini2440/Makefile
 b/board/friendlyarm/mini2440/Makefile new file mode 100644
 index 000..b88e569
 --- /dev/null
 +++ b/board/friendlyarm/mini2440/Makefile
 @@ -0,0 +1,44 @@
 +#
 +# (C) Copyright 2012
 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
 +#
 +# See file CREDITS for list of people who contributed to this
 +# project.
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = $(obj)lib$(BOARD).o
 +
 +COBJS:= mini2440.o
 +
 +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 +OBJS := $(addprefix $(obj),$(COBJS))
 +SOBJS:= $(addprefix $(obj),$(SOBJS))
 +
 +$(LIB):  $(obj).depend $(OBJS) $(SOBJS)
 + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
 +
 +#
 +
 +# defines $(obj).depend target
 +include $(SRCTREE)/rules.mk
 +
 +sinclude $(obj).depend
 +
 +#
 diff --git a/board/friendlyarm/mini2440/mini2440.c
 b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
 index 000..e97d981
 --- /dev/null
 +++ b/board/friendlyarm/mini2440/mini2440.c
 @@ -0,0 +1,134 @@
 +/*
 + * (C) Copyright 2002
 + * Sysgo Real-Time Solutions, GmbH www.elinos.com
 + * Marius Groeger mgroe...@sysgo.de
 + *
 + * (C) Copyright 2002
 + * David Mueller, ELSOFT AG, d.muel...@elsoft.ch
 + *
 + * (C) Copyright 2009
 + * Michel Pollet buser...@gmail.com
 + *
 + * (C) Copyright 2012
 + * Gabriel Huau cont...@huau-gabriel.fr
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + 

Re: [U-Boot] [PATCH 2/2 v7] Add support for MINI2440 (s3c2440).

2012-04-30 Thread Gabriel Huau
On Mon, Apr 30, 2012 at 03:21:49PM +0200, Marek Vasut wrote:
 Dear Gabriel Huau,
 
  +
  +/*
  + * Miscellaneous configurable options
  + */
  +#defineCONFIG_LONGHELP
  +#defineCONFIG_SYS_PROMPT   MINI2440 = 
  +#defineCONFIG_SYS_CBSIZE   256
  +#defineCONFIG_SYS_PBSIZE   
 (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
  +#defineCONFIG_SYS_MAXARGS  32
  +#define CONFIG_SYS_BARGSIZECONFIG_SYS_CBSIZE
 
 #define[tab] mixed with #define[space] ... also, please Cc Albert Aribaud for 
 the next round, he'll likely pick this up.
 

You gonna to kill me ... :P. checkpatch.pl didn't see this obfuscation
;).
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/2 v7] Add support for MINI2440 (s3c2440).

2012-04-30 Thread Marek Vasut
Dear Gabriel Huau,

 On Mon, Apr 30, 2012 at 03:21:49PM +0200, Marek Vasut wrote:
  Dear Gabriel Huau,
  
   +
   +/*
   + * Miscellaneous configurable options
   + */
   +#define  CONFIG_LONGHELP
   +#define  CONFIG_SYS_PROMPT   MINI2440 = 
   +#define  CONFIG_SYS_CBSIZE   256
   +#define  CONFIG_SYS_PBSIZE
  
  (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
  
   +#define  CONFIG_SYS_MAXARGS  32
   +#define CONFIG_SYS_BARGSIZE  CONFIG_SYS_CBSIZE
  
  #define[tab] mixed with #define[space] ... also, please Cc Albert Aribaud
  for the next round, he'll likely pick this up.
 
 You gonna to kill me ... :P. checkpatch.pl didn't see this obfuscation
 ;).

Fix checkpatch or report it ... this might be a worthy addition.

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot