Re: [U-Boot] [PATCH 2/3 v2] devkit3250: add Timll DevKit3250 board initial support
On 15.11.2011 09:48, Igor Grinberg wrote: > On 11/15/11 09:25, Vladimir Zapolskiy wrote: >> Hi Igor, >> >> On 15.11.2011 08:42, Igor Grinberg wrote: >>> Hi Vladimir, >>> >>> On 11/14/11 19:43, Vladimir Zapolskiy wrote: This change adds a basic support for Embest/Timll DevKit3250 board, NOR and UART are the only supported peripherals for a moment. The board doesn't require low-level init, because the initial SDRAM and GPIO configuration is performed during kickstart bootloader execution. Signed-off-by: Vladimir Zapolskiy --- Changes from v1 to v2: * corrected address in GPLv2+ licence header in files >>> >>> I think you should remove the address part completely, >>> because next time it changes, will you be around to fix it? >> I promise I'll be around, that's why I desire to become a maintainer of this >> board. > > Nice! Though I don't think you can foresee the future or do you? That's a rhetorical question, wasn't it? :) >> >>> I know that there are many files already with address, but >>> to make a big change it is better to start it from small - >>> say all new coming patches. >> Well, my small contribution is verifying address in license header found in >> new files. > > Thanks, that is fare enough! > I want to make sure you understand, that having the right > address in the license statement is not a blocker. > I hope that Albert being ARM custodian thinks similarly, because for a long time I didn't get any feedback about my change (your comment is the single one given from October 25), and by some reason it is still not integrated... >> >> I'd like to invite Wolfgang into discussion to get his opinion about the >> topic. Well, I do not feel myself as a lawer to allege that removing address >> info from the license notice is ok. Has it already been discussed in the >> mailing list? > > Actually, you don't have to be a lawyer to verify > if there is a requirement to have the postal address > (that changes from time to time) in the license statement. > AFAIK, there is no such requirement and the fact that huge > amount of files has a wrong postal address just emphasizes > this. > > What I'm proposing here is a way to spare the effort of changing > the postal address in the future. And if no one cares for the > right address, then why bother writing it in the source code? > To make the source code larger? > > And yes of course, I would like to here what Wolfgang has to say > about this. Actually this topic might be discussed in a separate mail thread. >> * removed clean and distclean targets from board makefile * do not set machine id explicitly, if CONFIG_MACH_TYPE is defined * minor indentation cleanups board/timll/devkit3250/Makefile | 44 + board/timll/devkit3250/devkit3250.c | 71 boards.cfg |3 +- include/configs/devkit3250.h| 121 +++ 4 files changed, 238 insertions(+), 1 deletions(-) create mode 100644 board/timll/devkit3250/Makefile create mode 100644 board/timll/devkit3250/devkit3250.c create mode 100644 include/configs/devkit3250.h >> >> [snip] >> > -- With best wishes, Vladimir ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3 v2] devkit3250: add Timll DevKit3250 board initial support
On 11/15/11 09:25, Vladimir Zapolskiy wrote: > Hi Igor, > > On 15.11.2011 08:42, Igor Grinberg wrote: >> Hi Vladimir, >> >> On 11/14/11 19:43, Vladimir Zapolskiy wrote: >>> This change adds a basic support for Embest/Timll DevKit3250 board, >>> NOR and UART are the only supported peripherals for a moment. The board >>> doesn't require low-level init, because the initial SDRAM and GPIO >>> configuration is performed during kickstart bootloader execution. >>> >>> Signed-off-by: Vladimir Zapolskiy >>> --- >>> Changes from v1 to v2: >>> * corrected address in GPLv2+ licence header in files >> >> I think you should remove the address part completely, >> because next time it changes, will you be around to fix it? > I promise I'll be around, that's why I desire to become a maintainer of this > board. Nice! Though I don't think you can foresee the future or do you? > >> I know that there are many files already with address, but >> to make a big change it is better to start it from small - >> say all new coming patches. > Well, my small contribution is verifying address in license header found in > new files. Thanks, that is fare enough! I want to make sure you understand, that having the right address in the license statement is not a blocker. > > I'd like to invite Wolfgang into discussion to get his opinion about the > topic. Well, I do not feel myself as a lawer to allege that removing address > info from the license notice is ok. Has it already been discussed in the > mailing list? Actually, you don't have to be a lawyer to verify if there is a requirement to have the postal address (that changes from time to time) in the license statement. AFAIK, there is no such requirement and the fact that huge amount of files has a wrong postal address just emphasizes this. What I'm proposing here is a way to spare the effort of changing the postal address in the future. And if no one cares for the right address, then why bother writing it in the source code? To make the source code larger? And yes of course, I would like to here what Wolfgang has to say about this. > >>> * removed clean and distclean targets from board makefile >>> * do not set machine id explicitly, if CONFIG_MACH_TYPE is defined >>> * minor indentation cleanups >>> >>> board/timll/devkit3250/Makefile | 44 + >>> board/timll/devkit3250/devkit3250.c | 71 >>> boards.cfg |3 +- >>> include/configs/devkit3250.h| 121 >>> +++ >>> 4 files changed, 238 insertions(+), 1 deletions(-) >>> create mode 100644 board/timll/devkit3250/Makefile >>> create mode 100644 board/timll/devkit3250/devkit3250.c >>> create mode 100644 include/configs/devkit3250.h >>> > > [snip] > -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3 v2] devkit3250: add Timll DevKit3250 board initial support
Hi Igor, On 15.11.2011 08:42, Igor Grinberg wrote: > Hi Vladimir, > > On 11/14/11 19:43, Vladimir Zapolskiy wrote: >> This change adds a basic support for Embest/Timll DevKit3250 board, >> NOR and UART are the only supported peripherals for a moment. The board >> doesn't require low-level init, because the initial SDRAM and GPIO >> configuration is performed during kickstart bootloader execution. >> >> Signed-off-by: Vladimir Zapolskiy >> --- >> Changes from v1 to v2: >> * corrected address in GPLv2+ licence header in files > > I think you should remove the address part completely, > because next time it changes, will you be around to fix it? I promise I'll be around, that's why I desire to become a maintainer of this board. > I know that there are many files already with address, but > to make a big change it is better to start it from small - > say all new coming patches. Well, my small contribution is verifying address in license header found in new files. I'd like to invite Wolfgang into discussion to get his opinion about the topic. Well, I do not feel myself as a lawer to allege that removing address info from the license notice is ok. Has it already been discussed in the mailing list? >> * removed clean and distclean targets from board makefile >> * do not set machine id explicitly, if CONFIG_MACH_TYPE is defined >> * minor indentation cleanups >> >> board/timll/devkit3250/Makefile | 44 + >> board/timll/devkit3250/devkit3250.c | 71 >> boards.cfg |3 +- >> include/configs/devkit3250.h| 121 >> +++ >> 4 files changed, 238 insertions(+), 1 deletions(-) >> create mode 100644 board/timll/devkit3250/Makefile >> create mode 100644 board/timll/devkit3250/devkit3250.c >> create mode 100644 include/configs/devkit3250.h >> [snip] -- With best wishes, Vladimir ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3 v2] devkit3250: add Timll DevKit3250 board initial support
Hi Vladimir,
On 11/14/11 19:43, Vladimir Zapolskiy wrote:
> This change adds a basic support for Embest/Timll DevKit3250 board,
> NOR and UART are the only supported peripherals for a moment. The board
> doesn't require low-level init, because the initial SDRAM and GPIO
> configuration is performed during kickstart bootloader execution.
>
> Signed-off-by: Vladimir Zapolskiy
> ---
> Changes from v1 to v2:
> * corrected address in GPLv2+ licence header in files
I think you should remove the address part completely,
because next time it changes, will you be around to fix it?
I know that there are many files already with address, but
to make a big change it is better to start it from small -
say all new coming patches.
> * removed clean and distclean targets from board makefile
> * do not set machine id explicitly, if CONFIG_MACH_TYPE is defined
> * minor indentation cleanups
>
> board/timll/devkit3250/Makefile | 44 +
> board/timll/devkit3250/devkit3250.c | 71
> boards.cfg |3 +-
> include/configs/devkit3250.h| 121
> +++
> 4 files changed, 238 insertions(+), 1 deletions(-)
> create mode 100644 board/timll/devkit3250/Makefile
> create mode 100644 board/timll/devkit3250/devkit3250.c
> create mode 100644 include/configs/devkit3250.h
>
> diff --git a/board/timll/devkit3250/Makefile b/board/timll/devkit3250/Makefile
> new file mode 100644
> index 000..ea7827c
> --- /dev/null
> +++ b/board/timll/devkit3250/Makefile
> @@ -0,0 +1,44 @@
> +#
> +# Copyright (C) 2011 by Vladimir Zapolskiy
> +# Copyright (C) 2008, Guennadi Liakhovetski
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301, USA.
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB = $(obj)lib$(BOARD).o
> +
> +COBJS:= devkit3250.o
> +
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
> +SOBJS:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB): $(obj).depend $(OBJS) $(SOBJS)
> + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +#
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#
> diff --git a/board/timll/devkit3250/devkit3250.c
> b/board/timll/devkit3250/devkit3250.c
> new file mode 100644
> index 000..461012d
> --- /dev/null
> +++ b/board/timll/devkit3250/devkit3250.c
> @@ -0,0 +1,71 @@
> +/*
> + * Embest/Timll DevKit3250 board support
> + *
> + * Copyright (C) 2011 Vladimir Zapolskiy
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301, USA.
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +static struct emc_t *emc = (struct emc_t *)EMC_BASE;
> +
> +int board_early_init_f(void)
> +{
> + lpc32xx_uart_init(CONFIG_SYS_LPC32XX_UART);
> +
> + return 0;
> +}
> +
> +int board_init(void)
> +{
> + /*
> + * It might be necessary to flush data cache, if U-boot is loaded
> + * from kickstart bootloader, e.g. from S1L loader
> + */
> + flush_cache(0, 0);
> +
> + /* adress of boot parameters */
> + gd->bd->bi_boot_params = CONFIG_ENV_ADDR;
> +
> +#ifdef CONFIG_SYS_FLASH_CFI
> + /* Use 16-bit memory interface for NOR Flash */
> + emc->stat[0].config = EMC_STAT_CONFIG_PB | EMC_STAT_CONFIG_16BIT;
> +
> + /* Change the NOR t
