Re: [U-Boot] [PATCH 2/4 v3] musb: Add Phy programming for usingexternal Vbus

2011-07-05 Thread Orjan Friberg
On 2010-06-10 07:50, Ajay Kumar Gupta wrote:
> MUSB PHY on OMAP3EVM Rev>= E uses external Vbus supply to support
> 500mA of power.We need to program MUSB PHY to use external Vbus
> for this purpose.
>
> Adding 'extvbus' member in musb_config structure which should be set
> by all the boards where MUSB interface is using external Vbus supply.

Ajay,

How does the DRVVBUS bit behave on the OMAP3 EVM board on issuing the 
'usb reset' command (with musb_cfg.extvbus being set)?  This post has a 
few more details, but in short it seems that DRVVBUS is automatically 
set by the TPS chip when doing the bus reset:

   http://lists.denx.de/pipermail/u-boot/2011-June/095221.html

(And indeed, on a board with *no* external vbus, setting 
musb_cfg.extvbus and reading from a memory stick works just fine.)

I checked the u-boot in the current DVSDK (4.02.00.06) and the git repo 
for u-boot-ti and they all have the same construct.

Thanks,
Orjan

-- 
Orjan Friberg
FlatFrog Laboratories AB
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4 v3] musb: Add Phy programming for usingexternal Vbus

2011-07-05 Thread Gupta, Ajay Kumar
Hello,
>> MUSB PHY on OMAP3EVM Rev>= E uses external Vbus supply to support
>> 500mA of power.We need to program MUSB PHY to use external Vbus
>> for this purpose.
>>
>> Adding 'extvbus' member in musb_config structure which should be set
>> by all the boards where MUSB interface is using external Vbus supply.
>
>Ajay,
>
>How does the DRVVBUS bit behave on the OMAP3 EVM board on issuing the
>'usb reset' command (with musb_cfg.extvbus being set)?
OMAP3EVM doesn't use TPS PHY but it has ISP1507 PHY and uses external Vbus
And so it needs extvbus programming (musb_cfg.extvbus =1)in OTG_CTRL
register. As for as I know it is not needed for boards using usb PHY on TPS
device.


>  This post has a
>few more details, but in short it seems that DRVVBUS is automatically
>set by the TPS chip when doing the bus reset:

Looks like TPS sets the extvbus and so musb_cfg.extvbus doesn't have
Any effect.

Ajay
>
>   http://lists.denx.de/pipermail/u-boot/2011-June/095221.html
>
>(And indeed, on a board with *no* external vbus, setting
>musb_cfg.extvbus and reading from a memory stick works just fine.)
>
>I checked the u-boot in the current DVSDK (4.02.00.06) and the git repo
>for u-boot-ti and they all have the same construct.
>
>Thanks,
>Orjan
>
>--
>Orjan Friberg
>FlatFrog Laboratories AB
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4 v3] musb: Add Phy programming for usingexternal Vbus

2011-07-05 Thread Orjan Friberg
On 2011-07-05 13:15, Gupta, Ajay Kumar wrote:
> OMAP3EVM doesn't use TPS PHY but it has ISP1507 PHY and uses external Vbus
> And so it needs extvbus programming (musb_cfg.extvbus =1)in OTG_CTRL
> register. As for as I know it is not needed for boards using usb PHY on TPS
> device.

Can you clarify what you mean by "not needed for boards using usb PHY on 
TPS device"?  How does that differ from the ISP1507?  From what I'm 
reading, the ISP1507 does have an integrated 5V charge pump.  Or is it 
simply a matter of how the board is designed?

(On our custom board, we have added an external vbus supply to be able 
to draw > 100 mA.)

Thanks,
Orjan

-- 
Orjan Friberg
FlatFrog Laboratories AB
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4 v3] musb: Add Phy programming for usingexternal Vbus

2011-07-05 Thread Gupta, Ajay Kumar
Hi,
>On 2011-07-05 13:15, Gupta, Ajay Kumar wrote:
>> OMAP3EVM doesn't use TPS PHY but it has ISP1507 PHY and uses external
>Vbus
>> And so it needs extvbus programming (musb_cfg.extvbus =1)in OTG_CTRL
>> register. As for as I know it is not needed for boards using usb PHY on
>TPS
>> device.
>
>Can you clarify what you mean by "not needed for boards using usb PHY on
>TPS device"?
This comment was more for boards such as Beagle which uses TPS device and
Uses internal charge pump of PHY.

>  How does that differ from the ISP1507?  From what I'm
>reading, the ISP1507 does have an integrated 5V charge pump.  Or is it
>simply a matter of how the board is designed?
Correct. OMAP3EVM (Rev-G) doesn't use internal charge pump but external
Vbus and thus we need to tell the PHY about this using BUS_CTRL.EXTVBUS
Register (Sorry I wrote OTG_CTRL wrongly in previous post)

>
>(On our custom board, we have added an external vbus supply to be able
>to draw > 100 mA.)
So it seems you are using PHY inside TPS659x but external Vbus for which
I think you need to,
1. Explicitly set "OTG_CTRL.D5 = 0" so that PHY doesn't drive 5V.
2. Do not set musb_cfg.extvbus

I have not seen anyone with this option on TPS PHY so not sure of above
Steps would work.

Thanks,
Ajay
>
>Thanks,
>Orjan
>
>--
>Orjan Friberg
>FlatFrog Laboratories AB
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4 v3] musb: Add Phy programming for usingexternal Vbus

2011-07-06 Thread Orjan Friberg
On 2011-07-05 16:16, Gupta, Ajay Kumar wrote:
>> (On our custom board, we have added an external vbus supply to be able
>> to draw>  100 mA.)
> So it seems you are using PHY inside TPS659x but external Vbus for which
> I think you need to,
> 1. Explicitly set "OTG_CTRL.D5 = 0" so that PHY doesn't drive 5V.
> 2. Do not set musb_cfg.extvbus

Great, thanks for clarifying (and agreed on all points).

It seems the best I can do is turn off DRVVBUS as soon as the chip has 
entered host mode (and turned thus it on).

Thanks,
Orjan

-- 
Orjan Friberg
FlatFrog Laboratories AB
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot