Re: [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC
Hallo Wolfgang Am 22.04.2010 14:51, schrieb Wolfgang Denk: extern struct serial_device serial0_device; extern struct serial_device serial1_device; #if defined(CONFIG_SYS_NS16550_SERIAL) diff --git a/tools/Makefile b/tools/Makefile index 749d994..b2e73b2 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -118,6 +118,9 @@ endif ifeq ($(VENDOR),ronetix) LOGO_BMP= logos/ronetix.bmp endif +ifeq ($(VENDOR),syteco) +LOGO_BMP= logos/syteco.bmp +endif Please keep list sorted. S is behind R in alphabet as you know for sure. So, can you explain which list should be kept sorted? Regards, Matthias ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC
Dear =?ISO-8859-1?Q?Matthias_Wei=DFer?=, In message 4bdeb5b1.6000...@arcor.de you wrote: Am 22.04.2010 14:51, schrieb Wolfgang Denk: extern struct serial_device serial0_device; extern struct serial_device serial1_device; #if defined(CONFIG_SYS_NS16550_SERIAL) diff --git a/tools/Makefile b/tools/Makefile index 749d994..b2e73b2 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -118,6 +118,9 @@ endif ifeq ($(VENDOR),ronetix) LOGO_BMP= logos/ronetix.bmp endif +ifeq ($(VENDOR),syteco) +LOGO_BMP= logos/syteco.bmp +endif Please keep list sorted. S is behind R in alphabet as you know for sure. So, can you explain which list should be kept sorted? Braino on my side. Please ignore this part of the comments. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de One planet is all you get. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC
Dear Matthias Weisser, In message 1271932257-14618-4-git-send-email-weiss...@arcor.de you wrote: This patch adds support for the jadecpu board using the MB86R01 'Jade' SoC from Fujitsu. Signed-off-by: Matthias Weisser weiss...@arcor.de --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/syteco/jadecpu/Makefile| 55 +++ board/syteco/jadecpu/config.mk |1 + board/syteco/jadecpu/jadecpu.c | 198 board/syteco/jadecpu/lowlevel_init.S | 279 ++ common/serial.c |3 +- include/configs/jadecpu.h| 189 +++ include/serial.h |3 +- tools/Makefile |3 + tools/logos/syteco.bmp | Bin 0 - 11414 bytes 12 files changed, 737 insertions(+), 2 deletions(-) create mode 100644 board/syteco/jadecpu/Makefile create mode 100644 board/syteco/jadecpu/config.mk create mode 100644 board/syteco/jadecpu/jadecpu.c create mode 100644 board/syteco/jadecpu/lowlevel_init.S create mode 100644 include/configs/jadecpu.h create mode 100644 tools/logos/syteco.bmp diff --git a/MAINTAINERS b/MAINTAINERS index 04c8730..ac0ed62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -776,6 +776,10 @@ Prafulla Wadaskar prafu...@marvell.com rd6281a ARM926EJS (Kirkwood SoC) sheevaplug ARM926EJS (Kirkwood SoC) +Matthias Weisser matthias.weis...@graf-syteco.de + + jadecpu ARM926EJS (MB86R01 SoC) + Richard Woodruff r-woodru...@ti.com omap2420h4 ARM1136EJS diff --git a/MAKEALL b/MAKEALL index fb1f7a3..5ee9678 100755 --- a/MAKEALL +++ b/MAKEALL @@ -561,6 +561,7 @@ LIST_ARM9= \ edb9315 \ edb9315a\ imx27lite \ + jadecpu \ lpd7a400\ mv88f6281gtw_ge \ mx1ads \ diff --git a/Makefile b/Makefile index 0381c81..4fdd216 100644 --- a/Makefile +++ b/Makefile @@ -2834,6 +2834,9 @@ CPU9260_config : unconfig @echo #define CONFIG_$(@:_config=) 1 $(obj)include/config.h @$(MKCONFIG) -a cpu9260 arm arm926ejs cpu9260 eukrea at91 +jadecpu_config : unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs jadecpu syteco mb86r0x + meesc_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs meesc esd at91 diff --git a/board/syteco/jadecpu/Makefile b/board/syteco/jadecpu/Makefile new file mode 100644 index 000..87d2234 --- /dev/null +++ b/board/syteco/jadecpu/Makefile @@ -0,0 +1,55 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# (C) Copyright 2008 +# Stelian Pop stelian@leadtechdesign.com +# Lead Tech Design www.leadtechdesign.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS-y += jadecpu.o +SOBJS:= lowlevel_init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/syteco/jadecpu/config.mk b/board/syteco/jadecpu/config.mk new file mode 100644 index 000..c661f0b --- /dev/null +++ b/board/syteco/jadecpu/config.mk @@ -0,0 +1 @@ +TEXT_BASE = 0x4600 diff --git a/board/syteco/jadecpu/jadecpu.c b/board/syteco/jadecpu/jadecpu.c new file mode 100644 index 000..ecc6742 --- /dev/null +++ b/board/syteco/jadecpu/jadecpu.c @@ -0,0 +1,198 @@ +/* + * (c) 2010 Graf-Syteco,
Re: [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC
Am 22.04.2010 14:51, schrieb Wolfgang Denk:
+if ((in_word 0xC0) == 0xC0) {
+setenv(stdin, serial);
+setenv(stdout, serial);
+setenv(stderr, serial);
+setenv(bootdelay, 10);
+} else if ((in_word 0xC0) != 0) {
+setenv(stdout, vga);
+setenv(bootcmd, mw.l 0x4000 0 1024; usb start;
+fatls usb 0; fatload usb 0 0x4000 mcq5resq.bin;
+bootelf 0x4000; bootelf 0x1008);
+setenv(bootdelay, 5);
I consider such mandatory settings of behaviour-critical variables as
bootcmd and bootdelay bad style. I recommend to use oither
variables instead, and to use these as defaults, so the user still has
a choice to define his own bootcmd which does not get overwritten at
each boot.
OK. I think this will be the approach you mentioned:
setenv bootcmd '${gs_bootcmd}'
setenv gs_bootcmd bootelf 0x...
Is the redirection of the console OK as it is done in the above code?
Regards,
Matthias
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC
Dear =?ISO-8859-1?Q?Matthias_Wei=DFer?=,
In message 4bd04c64.20...@arcor.de you wrote:
Am 22.04.2010 14:51, schrieb Wolfgang Denk:
+ if ((in_word 0xC0) == 0xC0) {
+ setenv(stdin, serial);
+ setenv(stdout, serial);
+ setenv(stderr, serial);
+ setenv(bootdelay, 10);
+ } else if ((in_word 0xC0) != 0) {
+ setenv(stdout, vga);
+ setenv(bootcmd, mw.l 0x4000 0 1024; usb start;
+ fatls usb 0; fatload usb 0 0x4000 mcq5resq.bin;
+ bootelf 0x4000; bootelf 0x1008);
+ setenv(bootdelay, 5);
I consider such mandatory settings of behaviour-critical variables as
bootcmd and bootdelay bad style. I recommend to use oither
variables instead, and to use these as defaults, so the user still has
a choice to define his own bootcmd which does not get overwritten at
each boot.
OK. I think this will be the approach you mentioned:
setenv bootcmd '${gs_bootcmd}'
setenv gs_bootcmd bootelf 0x...
Right.
Is the redirection of the console OK as it is done in the above code?
I have to admit that I don't exactly like it (because you will never
know which exact state the system is in, especially if it's not
working - I prefer static states and manual, permanent switching),
but I will not object here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
An organization dries up if you don't challenge it with growth.
- Mark Shepherd, former President and CEO of Texas Instruments
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
