Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
Hi Marek, Dear Fabio Estevam, On Wed, May 2, 2012 at 7:14 PM, Marek Vasut ma...@denx.de wrote: This solves issues when larger amount of DRAM is used. Shouldn't we check if we are using a large amount of DRAM? If we don't check then even boards with small amount of RAM would have this additional delay. I'm afraid this worked on boards with a small amound of RAM by sheer accident (or good will of the DRAM), time to play safe and fix this. Can you please comment on why we are waiting and why we are waiting exactly this long? Can we maybe poll the needed time somehow? Thanks Detlev -- Less talking -- more hacking -- Olin Shivers -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
Dear Detlev Zundel, Hi Marek, Dear Fabio Estevam, On Wed, May 2, 2012 at 7:14 PM, Marek Vasut ma...@denx.de wrote: This solves issues when larger amount of DRAM is used. Shouldn't we check if we are using a large amount of DRAM? If we don't check then even boards with small amount of RAM would have this additional delay. I'm afraid this worked on boards with a small amound of RAM by sheer accident (or good will of the DRAM), time to play safe and fix this. Can you please comment on why we are waiting and why we are waiting exactly this long? Can we maybe poll the needed time somehow? We need to wait for the CPU clock to stabilize. I think there is a bit for that that we can poll, indeed. It's in my queue to revise the memory init code eventually actually, because I think I can make it even faster and fix some rough edges that are still there. Thanks Detlev Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
Dear Detlev Zundel, Hi Marek, [...] Can you please comment on why we are waiting and why we are waiting exactly this long? Can we maybe poll the needed time somehow? We need to wait for the CPU clock to stabilize. This would be a worthwhile comment in the code. Indeed, will do I think there is a bit for that that we can poll, indeed. And _that_ is even better ;) I'm not doing this in this patch, I want a stable implementation here and I can break it later ;-) It's in my queue to revise the memory init code eventually actually, because I think I can make it even faster and fix some rough edges that are still there. Thanks! Detlev Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
Dear Detlev Zundel, Hi Marek, [...] Can you please comment on why we are waiting and why we are waiting exactly this long? Can we maybe poll the needed time somehow? We need to wait for the CPU clock to stabilize. This would be a worthwhile comment in the code. I think there is a bit for that that we can poll, indeed. And _that_ is even better ;) And I was wrong, there isn't ... I made a dip into the manual and there's nothing :/ So this patch will have to do It's in my queue to revise the memory init code eventually actually, because I think I can make it even faster and fix some rough edges that are still there. Thanks! Detlev Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
On Wed, May 2, 2012 at 7:14 PM, Marek Vasut ma...@denx.de wrote: This solves issues when larger amount of DRAM is used. Shouldn't we check if we are using a large amount of DRAM? If we don't check then even boards with small amount of RAM would have this additional delay. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init
Dear Fabio Estevam, On Wed, May 2, 2012 at 7:14 PM, Marek Vasut ma...@denx.de wrote: This solves issues when larger amount of DRAM is used. Shouldn't we check if we are using a large amount of DRAM? If we don't check then even boards with small amount of RAM would have this additional delay. I'm afraid this worked on boards with a small amound of RAM by sheer accident (or good will of the DRAM), time to play safe and fix this. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
