Re: [U-Boot] [PATCH 4/4] cmd_mac: fix help for 'mac read'
Dear Michael Jones, In message 1310717371-1677-5-git-send-email-michael.jo...@matrix-vision.de you wrote: In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- common/cmd_mac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Der Irrtum wiederholt sich immerfort in der Tat. Deshalb muß man das Wahre unermüdlich in Worten wiederholen. - Goethe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] cmd_mac: fix help for 'mac read'
Hi Detlev, On 07/15/2011 05:17 PM, Detlev Zundel wrote: Michael Jones michael.jo...@matrix-vision.de writes: In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Detlev Zundel d...@denx.de Thanks for the ack. Do you know when I can expect these to get merged in? MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] cmd_mac: fix help for 'mac read'
Hi Michael, Hi Detlev, On 07/15/2011 05:17 PM, Detlev Zundel wrote: Michael Jones michael.jo...@matrix-vision.de writes: In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Detlev Zundel d...@denx.de Thanks for the ack. Do you know when I can expect these to get merged in? As we currently lack a network maintainer, these patches fall into the and all the rest category picked up sequentially by Wolfgang. I expect that to happen Real Soon (tm) now. On the other hand, please do not forget that we _intentionally_ allow for some time to pass before the patches are merged in order to allow for review on the mailing list and to prevent potentially merge/revert/change/merge cycles. Cheers Detlev -- The management question ... is not _whether_ to build a pilot system and throw it away. You _will_ do that. The only question is whether to plan in advance to build a throwaway, or to promise to deliver the throwaway to customers. - Fred Brooks, The Mythical Man Month -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] cmd_mac: fix help for 'mac read'
Hi Detlev, Thanks for the reply. On 07/27/2011 03:54 PM, Detlev Zundel wrote: Hi Michael, Hi Detlev, On 07/15/2011 05:17 PM, Detlev Zundel wrote: Michael Jones michael.jo...@matrix-vision.de writes: In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Detlev Zundel d...@denx.de Thanks for the ack. Do you know when I can expect these to get merged in? As we currently lack a network maintainer, these patches fall into the and all the rest category picked up sequentially by Wolfgang. I expect that to happen Real Soon (tm) now. That's exactly what I wanted to know- it seemed there wasn't a custodian whom I needed to cc:, and I didn't know who would end up merging them. On the other hand, please do not forget that we _intentionally_ allow for some time to pass before the patches are merged in order to allow for review on the mailing list and to prevent potentially merge/revert/change/merge cycles. Sure, and that makes sense. I just wanted to get a feel for what kind of time scale that was in general. Obviously these are not important patches. Cheers Detlev thanks, Michael MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] cmd_mac: fix help for 'mac read'
Michael Jones michael.jo...@matrix-vision.de writes: In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Detlev Zundel d...@denx.de -- Der Kluge tue gleich anfangs, was der Dumme erst am Ende. --- Baltasar Gracian -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot