Re: [U-Boot] [PATCH 4/4 V2] EXYNOS: Move files from board/samsung to arch/arm.
Hi Minkyu Kang,
On Tue, Jul 2, 2013 at 11:25 AM, Minkyu Kang wrote:
> Dear Rajeshwari,
>
> On 01/07/13 19:02, Rajeshwari Shinde wrote:
>> This patch performs the following:
>>
>> 1) Convert the assembly code for memory and clock initialization to C code.
>> 2) Move the memory and clock init codes from board/samsung to arch/arm
>> 3) Creat a common lowlevel_init file across Exynos4 and Exynos5. Converted
>>the common lowlevel_init from assembly to C-code
>> 4) Made spl_boot.c and tzpc_init.c common for both exynos4 and exynos5.
>> 5) Enable CONFIG_SKIP_LOWLEVEL_INIT as stack pointer initialisation is
>> already
>>done in _main.
>> 6) exynos-uboot-spl.lds made common across SMDKV310, Origen and SMDK5250.
>>
>> TEST: Tested SD-MMC boot on SMDK5250 and Origen.
>> Tested USB and SPI boot on SMDK5250
>> Compile tested for SMDKV310.
>>
>> Signed-off-by: Rajeshwari Shinde
>> ---
>> Changes in V2:
>> - Rebased on latest u-boot-samsung tree.
>> - Incorporated review comments from Minkyu Kang.
>> arch/arm/cpu/armv7/exynos/Makefile | 17 +-
>> .../arm/cpu/armv7/exynos}/clock_init.h |0
>> arch/arm/cpu/armv7/exynos/clock_init_exynos4.c | 94 +
>> .../arm/cpu/armv7/exynos/clock_init_exynos5.c | 27 +-
>> arch/arm/cpu/armv7/exynos/common_setup.h | 43 ++
>> .../arm/cpu/armv7/exynos}/dmc_common.c |7 +-
>> .../arm/cpu/armv7/exynos}/dmc_init_ddr3.c | 17 +-
>> arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c | 295 ++
>> .../arm/cpu/armv7/exynos/exynos4_setup.h | 97 +-
>> .../arm/cpu/armv7/exynos/exynos5_setup.h | 28 +-
>> arch/arm/cpu/armv7/exynos/lowlevel_init.c | 72
>> .../arm/cpu/armv7/exynos}/spl_boot.c | 77 +++-
>> board/samsung/origen/Makefile | 11 +-
>> board/samsung/origen/lowlevel_init.S | 357 -
>> board/samsung/origen/mem_setup.S | 421
>>
>> board/samsung/origen/mmc_boot.c| 58 ---
>> board/samsung/smdk5250/Makefile| 14 +-
>> board/samsung/smdkv310/Makefile| 10 +-
>> board/samsung/smdkv310/lowlevel_init.S | 414
>> ---
>> board/samsung/smdkv310/mem_setup.S | 365 -
>> board/samsung/smdkv310/mmc_boot.c | 60 ---
>> include/configs/exynos5250-dt.h|8 +-
>> include/configs/origen.h |9 +-
>> include/configs/smdkv310.h |8 +-
>> 24 files changed, 743 insertions(+), 1766 deletions(-)
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/clock_init.h
>> (100%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/clock_init_exynos4.c
>> rename board/samsung/smdk5250/clock_init.c =>
>> arch/arm/cpu/armv7/exynos/clock_init_exynos5.c (97%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/common_setup.h
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/dmc_common.c
>> (97%)
>> rename {board/samsung/smdk5250 =>
>> arch/arm/cpu/armv7/exynos}/dmc_init_ddr3.c (96%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c
>> rename board/samsung/origen/origen_setup.h =>
>> arch/arm/cpu/armv7/exynos/exynos4_setup.h (86%)
>> rename board/samsung/smdk5250/setup.h =>
>> arch/arm/cpu/armv7/exynos/exynos5_setup.h (96%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel_init.c
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/spl_boot.c
>> (73%)
>> delete mode 100644 board/samsung/origen/lowlevel_init.S
>> delete mode 100644 board/samsung/origen/mem_setup.S
>> delete mode 100644 board/samsung/origen/mmc_boot.c
>> delete mode 100644 board/samsung/smdkv310/lowlevel_init.S
>> delete mode 100644 board/samsung/smdkv310/mem_setup.S
>> delete mode 100644 board/samsung/smdkv310/mmc_boot.c
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/Makefile
>> b/arch/arm/cpu/armv7/exynos/Makefile
>> index b2f9152..4661155 100644
>> --- a/arch/arm/cpu/armv7/exynos/Makefile
>> +++ b/arch/arm/cpu/armv7/exynos/Makefile
>> @@ -22,10 +22,19 @@ include $(TOPDIR)/config.mk
>>
>> LIB = $(obj)lib$(SOC).o
>>
>> -COBJS+= clock.o power.o soc.o system.o pinmux.o tzpc.o
>> -
>> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
>> -OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
>> +COBJS-y += clock.o power.o soc.o system.o pinmux.o tzpc.o
>> +
>> +ifdef CONFIG_SPL_BUILD
>> +COBJS-$(CONFIG_EXYNOS5) += clock_init_exynos5.o
>> +COBJS-$(CONFIG_EXYNOS5) += dmc_common.o dmc_init_ddr3.o
>> +COBJS-$(CONFIG_EXYNOS4210)+= dmc_init_exynos4.o clock_init_exynos4.o
>> +COBJS-y += spl_boot.o
>> +COBJS-y += lowlevel_init.o
>> +endif
>> +
>> +COBJS := $(COBJS-y)
>> +SRCS := $(COBJS:.o=.c)
>> +OBJS := $(addprefix $(obj),$(COBJS))
>>
>> all: $(obj).depend $(LIB)
>>
>>
Re: [U-Boot] [PATCH 4/4 V2] EXYNOS: Move files from board/samsung to arch/arm.
Hi Minkyu Kang,
Thank you for comments
On Tue, Jul 2, 2013 at 11:25 AM, Minkyu Kang wrote:
> Dear Rajeshwari,
>
> On 01/07/13 19:02, Rajeshwari Shinde wrote:
>> This patch performs the following:
>>
>> 1) Convert the assembly code for memory and clock initialization to C code.
>> 2) Move the memory and clock init codes from board/samsung to arch/arm
>> 3) Creat a common lowlevel_init file across Exynos4 and Exynos5. Converted
>>the common lowlevel_init from assembly to C-code
>> 4) Made spl_boot.c and tzpc_init.c common for both exynos4 and exynos5.
>> 5) Enable CONFIG_SKIP_LOWLEVEL_INIT as stack pointer initialisation is
>> already
>>done in _main.
>> 6) exynos-uboot-spl.lds made common across SMDKV310, Origen and SMDK5250.
>>
>> TEST: Tested SD-MMC boot on SMDK5250 and Origen.
>> Tested USB and SPI boot on SMDK5250
>> Compile tested for SMDKV310.
>>
>> Signed-off-by: Rajeshwari Shinde
>> ---
>> Changes in V2:
>> - Rebased on latest u-boot-samsung tree.
>> - Incorporated review comments from Minkyu Kang.
>> arch/arm/cpu/armv7/exynos/Makefile | 17 +-
>> .../arm/cpu/armv7/exynos}/clock_init.h |0
>> arch/arm/cpu/armv7/exynos/clock_init_exynos4.c | 94 +
>> .../arm/cpu/armv7/exynos/clock_init_exynos5.c | 27 +-
>> arch/arm/cpu/armv7/exynos/common_setup.h | 43 ++
>> .../arm/cpu/armv7/exynos}/dmc_common.c |7 +-
>> .../arm/cpu/armv7/exynos}/dmc_init_ddr3.c | 17 +-
>> arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c | 295 ++
>> .../arm/cpu/armv7/exynos/exynos4_setup.h | 97 +-
>> .../arm/cpu/armv7/exynos/exynos5_setup.h | 28 +-
>> arch/arm/cpu/armv7/exynos/lowlevel_init.c | 72
>> .../arm/cpu/armv7/exynos}/spl_boot.c | 77 +++-
>> board/samsung/origen/Makefile | 11 +-
>> board/samsung/origen/lowlevel_init.S | 357 -
>> board/samsung/origen/mem_setup.S | 421
>>
>> board/samsung/origen/mmc_boot.c| 58 ---
>> board/samsung/smdk5250/Makefile| 14 +-
>> board/samsung/smdkv310/Makefile| 10 +-
>> board/samsung/smdkv310/lowlevel_init.S | 414
>> ---
>> board/samsung/smdkv310/mem_setup.S | 365 -
>> board/samsung/smdkv310/mmc_boot.c | 60 ---
>> include/configs/exynos5250-dt.h|8 +-
>> include/configs/origen.h |9 +-
>> include/configs/smdkv310.h |8 +-
>> 24 files changed, 743 insertions(+), 1766 deletions(-)
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/clock_init.h
>> (100%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/clock_init_exynos4.c
>> rename board/samsung/smdk5250/clock_init.c =>
>> arch/arm/cpu/armv7/exynos/clock_init_exynos5.c (97%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/common_setup.h
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/dmc_common.c
>> (97%)
>> rename {board/samsung/smdk5250 =>
>> arch/arm/cpu/armv7/exynos}/dmc_init_ddr3.c (96%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c
>> rename board/samsung/origen/origen_setup.h =>
>> arch/arm/cpu/armv7/exynos/exynos4_setup.h (86%)
>> rename board/samsung/smdk5250/setup.h =>
>> arch/arm/cpu/armv7/exynos/exynos5_setup.h (96%)
>> create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel_init.c
>> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/spl_boot.c
>> (73%)
>> delete mode 100644 board/samsung/origen/lowlevel_init.S
>> delete mode 100644 board/samsung/origen/mem_setup.S
>> delete mode 100644 board/samsung/origen/mmc_boot.c
>> delete mode 100644 board/samsung/smdkv310/lowlevel_init.S
>> delete mode 100644 board/samsung/smdkv310/mem_setup.S
>> delete mode 100644 board/samsung/smdkv310/mmc_boot.c
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/Makefile
>> b/arch/arm/cpu/armv7/exynos/Makefile
>> index b2f9152..4661155 100644
>> --- a/arch/arm/cpu/armv7/exynos/Makefile
>> +++ b/arch/arm/cpu/armv7/exynos/Makefile
>> @@ -22,10 +22,19 @@ include $(TOPDIR)/config.mk
>>
>> LIB = $(obj)lib$(SOC).o
>>
>> -COBJS+= clock.o power.o soc.o system.o pinmux.o tzpc.o
>> -
>> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
>> -OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
>> +COBJS-y += clock.o power.o soc.o system.o pinmux.o tzpc.o
>> +
>> +ifdef CONFIG_SPL_BUILD
>> +COBJS-$(CONFIG_EXYNOS5) += clock_init_exynos5.o
>> +COBJS-$(CONFIG_EXYNOS5) += dmc_common.o dmc_init_ddr3.o
>> +COBJS-$(CONFIG_EXYNOS4210)+= dmc_init_exynos4.o clock_init_exynos4.o
>> +COBJS-y += spl_boot.o
>> +COBJS-y += lowlevel_init.o
>> +endif
>> +
>> +COBJS := $(COBJS-y)
>> +SRCS := $(COBJS:.o=.c)
>> +OBJS := $(addprefix $(obj),$(COBJS))
>>
>> all: $(o
Re: [U-Boot] [PATCH 4/4 V2] EXYNOS: Move files from board/samsung to arch/arm.
Dear Rajeshwari,
On 01/07/13 19:02, Rajeshwari Shinde wrote:
> This patch performs the following:
>
> 1) Convert the assembly code for memory and clock initialization to C code.
> 2) Move the memory and clock init codes from board/samsung to arch/arm
> 3) Creat a common lowlevel_init file across Exynos4 and Exynos5. Converted
>the common lowlevel_init from assembly to C-code
> 4) Made spl_boot.c and tzpc_init.c common for both exynos4 and exynos5.
> 5) Enable CONFIG_SKIP_LOWLEVEL_INIT as stack pointer initialisation is already
>done in _main.
> 6) exynos-uboot-spl.lds made common across SMDKV310, Origen and SMDK5250.
>
> TEST: Tested SD-MMC boot on SMDK5250 and Origen.
> Tested USB and SPI boot on SMDK5250
> Compile tested for SMDKV310.
>
> Signed-off-by: Rajeshwari Shinde
> ---
> Changes in V2:
> - Rebased on latest u-boot-samsung tree.
> - Incorporated review comments from Minkyu Kang.
> arch/arm/cpu/armv7/exynos/Makefile | 17 +-
> .../arm/cpu/armv7/exynos}/clock_init.h |0
> arch/arm/cpu/armv7/exynos/clock_init_exynos4.c | 94 +
> .../arm/cpu/armv7/exynos/clock_init_exynos5.c | 27 +-
> arch/arm/cpu/armv7/exynos/common_setup.h | 43 ++
> .../arm/cpu/armv7/exynos}/dmc_common.c |7 +-
> .../arm/cpu/armv7/exynos}/dmc_init_ddr3.c | 17 +-
> arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c | 295 ++
> .../arm/cpu/armv7/exynos/exynos4_setup.h | 97 +-
> .../arm/cpu/armv7/exynos/exynos5_setup.h | 28 +-
> arch/arm/cpu/armv7/exynos/lowlevel_init.c | 72
> .../arm/cpu/armv7/exynos}/spl_boot.c | 77 +++-
> board/samsung/origen/Makefile | 11 +-
> board/samsung/origen/lowlevel_init.S | 357 -
> board/samsung/origen/mem_setup.S | 421
>
> board/samsung/origen/mmc_boot.c| 58 ---
> board/samsung/smdk5250/Makefile| 14 +-
> board/samsung/smdkv310/Makefile| 10 +-
> board/samsung/smdkv310/lowlevel_init.S | 414 ---
> board/samsung/smdkv310/mem_setup.S | 365 -
> board/samsung/smdkv310/mmc_boot.c | 60 ---
> include/configs/exynos5250-dt.h|8 +-
> include/configs/origen.h |9 +-
> include/configs/smdkv310.h |8 +-
> 24 files changed, 743 insertions(+), 1766 deletions(-)
> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/clock_init.h
> (100%)
> create mode 100644 arch/arm/cpu/armv7/exynos/clock_init_exynos4.c
> rename board/samsung/smdk5250/clock_init.c =>
> arch/arm/cpu/armv7/exynos/clock_init_exynos5.c (97%)
> create mode 100644 arch/arm/cpu/armv7/exynos/common_setup.h
> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/dmc_common.c
> (97%)
> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/dmc_init_ddr3.c
> (96%)
> create mode 100644 arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c
> rename board/samsung/origen/origen_setup.h =>
> arch/arm/cpu/armv7/exynos/exynos4_setup.h (86%)
> rename board/samsung/smdk5250/setup.h =>
> arch/arm/cpu/armv7/exynos/exynos5_setup.h (96%)
> create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel_init.c
> rename {board/samsung/smdk5250 => arch/arm/cpu/armv7/exynos}/spl_boot.c (73%)
> delete mode 100644 board/samsung/origen/lowlevel_init.S
> delete mode 100644 board/samsung/origen/mem_setup.S
> delete mode 100644 board/samsung/origen/mmc_boot.c
> delete mode 100644 board/samsung/smdkv310/lowlevel_init.S
> delete mode 100644 board/samsung/smdkv310/mem_setup.S
> delete mode 100644 board/samsung/smdkv310/mmc_boot.c
>
> diff --git a/arch/arm/cpu/armv7/exynos/Makefile
> b/arch/arm/cpu/armv7/exynos/Makefile
> index b2f9152..4661155 100644
> --- a/arch/arm/cpu/armv7/exynos/Makefile
> +++ b/arch/arm/cpu/armv7/exynos/Makefile
> @@ -22,10 +22,19 @@ include $(TOPDIR)/config.mk
>
> LIB = $(obj)lib$(SOC).o
>
> -COBJS+= clock.o power.o soc.o system.o pinmux.o tzpc.o
> -
> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
> +COBJS-y += clock.o power.o soc.o system.o pinmux.o tzpc.o
> +
> +ifdef CONFIG_SPL_BUILD
> +COBJS-$(CONFIG_EXYNOS5) += clock_init_exynos5.o
> +COBJS-$(CONFIG_EXYNOS5) += dmc_common.o dmc_init_ddr3.o
> +COBJS-$(CONFIG_EXYNOS4210)+= dmc_init_exynos4.o clock_init_exynos4.o
> +COBJS-y += spl_boot.o
> +COBJS-y += lowlevel_init.o
> +endif
> +
> +COBJS := $(COBJS-y)
> +SRCS := $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
>
> all: $(obj).depend $(LIB)
>
> diff --git a/board/samsung/smdk5250/clock_init.h
> b/arch/arm/cpu/armv7/exynos/clock_init.h
> similarity index 100%
> rename from board/samsung/smdk5250/clock_init.h
> rena
