Re: [U-Boot] [PATCH 4/7] tegra30: fdt: add SPI SLINK nodes

2013-01-11 Thread Allen Martin 
On Fri, Jan 11, 2013 at 04:17:18PM -0800, Stephen Warren wrote:
> On 01/11/2013 11:44 AM, Allen Martin wrote:
> > Add tegra30 SPI SLINK nodes to fdt.
> 
> > diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi
> 
> > /* PERIPH_ID_I2C_DVC, CLK_M */
> > clocks = <&tegra_car 47>;
> > };
> > +   spi@7000d400 {
> 
> Blank line needed before the new node.

ok

> 
> > +   compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
> > +   reg = <0x7000d400 0x200>;
> 
> I can't tell if the sort order is correct here; not enough context in
> the diff.

It's not, I'll fix.

> 
> > +   interrupts = <0 59 0x04>;
> > +   nvidia,dma-request-selector = <&apbdma 15>;
> > +   spi-max-frequency = <2500>;
> 
> Same comment about that property being board-specific.

ok

> 
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   status = "disabled";
> > +   /* PERIPH_ID_SBC1, PLLP_OUT0 */
> > +   clocks = <&tegra_car 41>;
> > +   };
> 

-Allen
-- 
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/7] tegra30: fdt: add SPI SLINK nodes

2013-01-11 Thread Stephen Warren 
On 01/11/2013 11:44 AM, Allen Martin wrote:
> Add tegra30 SPI SLINK nodes to fdt.

> diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi

>   /* PERIPH_ID_I2C_DVC, CLK_M */
>   clocks = <&tegra_car 47>;
>   };
> + spi@7000d400 {

Blank line needed before the new node.

> + compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
> + reg = <0x7000d400 0x200>;

I can't tell if the sort order is correct here; not enough context in
the diff.

> + interrupts = <0 59 0x04>;
> + nvidia,dma-request-selector = <&apbdma 15>;
> + spi-max-frequency = <2500>;

Same comment about that property being board-specific.

> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + /* PERIPH_ID_SBC1, PLLP_OUT0 */
> + clocks = <&tegra_car 41>;
> + };

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot