Re: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available

[Stephen Warren]

On 03/02/2016 05:25 PM, Simon Glass wrote:

Hi Stephen,

On 29 February 2016 at 16:39, Stephen Warren  wrote:

On 02/25/2016 09:00 PM, Simon Glass wrote:


Don't try to run commands when not supported.




diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c




+int board_run_command(const char *cmdline)
+{
+   printf("## Commands are disabled. Please enable
CONFIG_CMDLINE.\n");
+
+   return 1;
+}
+



Isn't this part of patch 5/9?


No - this is the sandbox support. That patch merely declares the
function in a header. Any board can implement it, and each would do so
in a separate patch.


OK, but this patch implements the function before there's a prototype 
for it in the header. That doesn't seem like the correct order.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available

[Simon Glass]

Hi Stephen,

On 29 February 2016 at 16:39, Stephen Warren  wrote:
> On 02/25/2016 09:00 PM, Simon Glass wrote:
>>
>> Don't try to run commands when not supported.
>
>
>> diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
>
>
>> +int board_run_command(const char *cmdline)
>> +{
>> +   printf("## Commands are disabled. Please enable
>> CONFIG_CMDLINE.\n");
>> +
>> +   return 1;
>> +}
>> +
>
>
> Isn't this part of patch 5/9?

No - this is the sandbox support. That patch merely declares the
function in a header. Any board can implement it, and each would do so
in a separate patch.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available

[Stephen Warren]

On 02/25/2016 09:00 PM, Simon Glass wrote:

Don't try to run commands when not supported.



diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c



+int board_run_command(const char *cmdline)
+{
+   printf("## Commands are disabled. Please enable CONFIG_CMDLINE.\n");
+
+   return 1;
+}
+


Isn't this part of patch 5/9?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available

[Tom Rini]

On Thu, Feb 25, 2016 at 09:00:51PM -0700, Simon Glass wrote:

> Don't try to run commands when not supported.
> 
> Signed-off-by: Simon Glass 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot