Re: [U-Boot] [PATCH 5/9] openrisc: Add board info printout to cmd_bdinfo

2011-11-21 Thread Marek Vasut 
> On Mon, Nov 21, 2011 at 11:53:32PM +0100, Marek Vasut wrote:
> > > +int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const
> > > argv[]) +{
> > > + bd_t *bd = gd->bd;
> > > +
> > > + print_num("mem start",  (ulong)bd->bi_memstart);
> > > + print_lnum("mem size",  (u64)bd->bi_memsize);
> > > + print_num("flash start",(ulong)bd->bi_flashstart);
> > > + print_num("flash size", (ulong)bd->bi_flashsize);
> > > + print_num("flash offset",   (ulong)bd->bi_flashoffset);
> > > +
> > > +#if defined(CONFIG_CMD_NET)
> > > + print_eth(0);
> > > + printf("ip_addr = %pI4\n", &bd->bi_ip_addr);
> > > +#endif
> > > +
> > > + printf("baudrate= %ld bps\n", bd->bi_baudrate);
> > 
> > Would consistent format of the printed data be a problem ? ;-)
> 
> I'm sorry, I don't think I understand what you are referring to here.
> When printed, they are all lined up.
> If I haven't missed something, every arch does the printing like that.

Ok, then that's good.

> 
> Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/9] openrisc: Add board info printout to cmd_bdinfo

2011-11-21 Thread Stefan Kristiansson 
On Mon, Nov 21, 2011 at 11:53:32PM +0100, Marek Vasut wrote:
> > +int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> > +{
> > +   bd_t *bd = gd->bd;
> > +
> > +   print_num("mem start",  (ulong)bd->bi_memstart);
> > +   print_lnum("mem size",  (u64)bd->bi_memsize);
> > +   print_num("flash start",(ulong)bd->bi_flashstart);
> > +   print_num("flash size", (ulong)bd->bi_flashsize);
> > +   print_num("flash offset",   (ulong)bd->bi_flashoffset);
> > +
> > +#if defined(CONFIG_CMD_NET)
> > +   print_eth(0);
> > +   printf("ip_addr = %pI4\n", &bd->bi_ip_addr);
> > +#endif
> > +
> > +   printf("baudrate= %ld bps\n", bd->bi_baudrate);
> 
> Would consistent format of the printed data be a problem ? ;-)
> 

I'm sorry, I don't think I understand what you are referring to here.
When printed, they are all lined up.
If I haven't missed something, every arch does the printing like that.

Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/9] openrisc: Add board info printout to cmd_bdinfo

2011-11-21 Thread Marek Vasut 
> Signed-off-by: Stefan Kristiansson 
> ---
>  common/cmd_bdinfo.c |   22 ++
>  1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index 688b238..1cd69b5 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -460,6 +460,28 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[]) return 0;
>  }
> 
> +#elif defined(CONFIG_OPENRISC)
> +
> +int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> + bd_t *bd = gd->bd;
> +
> + print_num("mem start",  (ulong)bd->bi_memstart);
> + print_lnum("mem size",  (u64)bd->bi_memsize);
> + print_num("flash start",(ulong)bd->bi_flashstart);
> + print_num("flash size", (ulong)bd->bi_flashsize);
> + print_num("flash offset",   (ulong)bd->bi_flashoffset);
> +
> +#if defined(CONFIG_CMD_NET)
> + print_eth(0);
> + printf("ip_addr = %pI4\n", &bd->bi_ip_addr);
> +#endif
> +
> + printf("baudrate= %ld bps\n", bd->bi_baudrate);

Would consistent format of the printed data be a problem ? ;-)

> +
> + return 0;
> +}
> +
>  #else
>   #error "a case for this architecture does not exist!"
>  #endif
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot