Re: [U-Boot] [PATCH RESEND 4/5] trats: new USB hardware init interface

[Mateusz Zalega]

On 08/09/13 11:30, Jaehoon Chung wrote:
>> +int board_usb_init(enum board_usb_init_type what_to_init)
>>  {
>>  debug("USB_udc_probe\n");
>>  s3c_udc_probe(&s5pc210_otg_data);
>> +return 0;
> Always return 0?
>>  }

You're right, it could pass return value from s3c_udc_probe.

Thanks,

-- 
Mateusz Zalega
Samsung R&D Institute Poland (SRPOL) | Kernel and System Framework group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH RESEND 4/5] trats: new USB hardware init interface

[Jaehoon Chung]

On 08/06/2013 07:50 PM, Mateusz Zalega wrote:
> This commit changes name of an existing initialization function to
> board_usb_init(), so that such functions could be reached by every
> USB driver and command (ie. do_dfu()).
> 
> Signed-off-by: Mateusz Zalega 
> ---
>  board/samsung/trats/trats.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index c8698f3..f8d4b0c 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -26,6 +26,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  
>  #include "setup.h"
> @@ -488,10 +489,11 @@ struct s3c_plat_otg_data s5pc210_otg_data = {
>   .usb_flags  = PHY0_SLEEP,
>  };
>  
> -void board_usb_init(void)
> +int board_usb_init(enum board_usb_init_type what_to_init)
>  {
>   debug("USB_udc_probe\n");
>   s3c_udc_probe(&s5pc210_otg_data);
> + return 0;
Always return 0?
>  }
>  #endif
>  
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot