Re: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common
On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and soc to print more information there seems to be things that all arches print ... like memory and flash information. perhaps that should be left in the common bdinfo(). +void board_bdinfo(cmd_tbl_t *, int, int, char **) __attribute((weak)); +void soc_bdinfo(cmd_tbl_t *, int, int, char **) __attribute((weak)); __attribute__ +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) + if(soc_bdinfo) + if(board_bdinfo) you've got random whitespace damage all over this patch ... thanks -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common
On 14:36 Wed 12 Nov , Mike Frysinger wrote: On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and soc to print more information there seems to be things that all arches print ... like memory and flash information. perhaps that should be left in the common bdinfo(). I've prefered to let arch print this how they wish +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) + if(soc_bdinfo) + if(board_bdinfo) you've got random whitespace damage all over this patch ... I known, but I not suposed to fix PPC whitespace in the patch I've an other one when everyone will agree on this one Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common
On Wed, Nov 12, 2008 at 2:45 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 14:36 Wed 12 Nov , Mike Frysinger wrote: On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and soc to print more information there seems to be things that all arches print ... like memory and flash information. perhaps that should be left in the common bdinfo(). I've prefered to let arch print this how they wish +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) + if(soc_bdinfo) + if(board_bdinfo) you've got random whitespace damage all over this patch ... I known, but I not suposed to fix PPC whitespace in the patch I've an other one when everyone will agree on this one i wasnt talking about PPC whitespace. i was talking about code you added. the code in the common bdinfo.c did not exist until you added it. the function decls in the arch bdinfo.c's did not exist until you added them. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common
On 14:55 Wed 12 Nov , Mike Frysinger wrote: On Wed, Nov 12, 2008 at 2:45 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 14:36 Wed 12 Nov , Mike Frysinger wrote: On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and soc to print more information there seems to be things that all arches print ... like memory and flash information. perhaps that should be left in the common bdinfo(). I've prefered to let arch print this how they wish +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) + if(soc_bdinfo) + if(board_bdinfo) you've got random whitespace damage all over this patch ... I known, but I not suposed to fix PPC whitespace in the patch I've an other one when everyone will agree on this one i wasnt talking about PPC whitespace. i was talking about code you added. the code in the common bdinfo.c did not exist until you added it. the function decls in the arch bdinfo.c's did not exist until you added them. sorry do see what you talk about please show in the patch Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
