Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
On 14/01/2012 15:25, Tom Rini wrote: > So what happened is I accidentally put this board into u-boot-ti/next > a while back, before the USB changes went in, without realizing it. > The reason the USB changes haven't gone in, still, is that they've > been made more generic (as the IP block is shared between these boards > and omap4/5). For that part of the problem perhaps we should turn off > the USB portion of the board for now? Ok - I will sent a patch to turn USB off, until EHCI omap flows into mainline. Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
On Sat, Jan 14, 2012 at 1:47 AM, Albert ARIBAUD wrote: > (re-sent due to the U-Boot MX rejecting my provider's servers -- again) > > Hi Stefano, > > Le 01/12/2011 10:56, Stefano Babic a écrit : >> >> The twister board is a development board using >> the TAM3517 SOM. > > > I see this match made it in IMX then ARM, but it seems not to build here > either with ELDK 4.2 or linaro (Ubuntu) cross tool chains: > >> Configuring for twister board... >> omap_gpmc.c:33:30: attention : ‘hw_nand_oob’ defined but not used >> [-Wunused-variable] >> omap_gpmc.c:78:13: attention : ‘omap_hwecc_init’ defined but not used >> [-Wunused-function] >> omap_gpmc.c:116:12: attention : ‘omap_correct_data’ defined but not used >> [-Wunused-function] >> omap_gpmc.c:182:12: attention : ‘omap_calculate_ecc’ defined but not used >> [-Wunused-function] >> omap_gpmc.c:208:13: attention : ‘omap_enable_hwecc’ defined but not used >> [-Wunused-function] >> drivers/usb/host/libusb_host.o: In function `usb_lowlevel_stop': >> /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:806: undefined >> reference to `ehci_hcd_stop' >> drivers/usb/host/libusb_host.o: In function `usb_lowlevel_init': >> /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:814: undefined >> reference to `ehci_hcd_init' >> arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 >> assertion fail ../../bfd/elf32-arm.c:7498 >> arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 >> assertion fail ../../bfd/elf32-arm.c:7498 >> arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 >> assertion fail ../../bfd/elf32-arm.c:13828 >> /bin/sh : ligne 1 : 23855 Erreur de segmentation arm-linux-gnueabi-ld >> -pie -T u-boot.lds -Bstatic -Ttext 0x80008000 $UNDEF_SYM >> arch/arm/cpu/armv7/start.o --start-group api/libapi.o >> arch/arm/cpu/armv7/libarmv7.o >> arch/arm/cpu/armv7/omap-common/libomap-common.o >> arch/arm/cpu/armv7/omap3/libomap3.o arch/arm/lib/libarm.o common/libcommon.o >> disk/libdisk.o drivers/bios_emulator/libatibiosemu.o >> drivers/block/libblock.o drivers/dma/libdma.o drivers/fpga/libfpga.o >> drivers/gpio/libgpio.o drivers/hwmon/libhwmon.o drivers/i2c/libi2c.o >> drivers/input/libinput.o drivers/misc/libmisc.o drivers/mmc/libmmc.o >> drivers/mtd/libmtd.o drivers/mtd/nand/libnand.o >> drivers/mtd/onenand/libonenand.o drivers/mtd/spi/libspi_flash.o >> drivers/mtd/ubi/libubi.o drivers/net/libnet.o drivers/net/phy/libphy.o >> drivers/pci/libpci.o drivers/pcmcia/libpcmcia.o drivers/power/libpower.o >> drivers/rtc/librtc.o drivers/serial/libserial.o drivers/spi/libspi.o >> drivers/twserial/libtws.o drivers/usb/eth/libusb_eth.o drivers/usb > > > /gadget/libusb_gadget.o drivers/usb/host/libusb_host.o > drivers/usb/musb/libusb_musb.o drivers/usb/phy/libusb_phy.o > drivers/usb/ulpi/libusb_ulpi.o drivers/video/libvideo.o > drivers/watchdog/libwatchdog.o fs/cramfs/libcramfs.o fs/ext2/libext2fs.o > fs/fat/libfat.o fs/fdos/libfdos.o fs/jffs2/libjffs2.o > fs/reiserfs/libreiserfs.o fs/ubifs/libubifs.o fs/yaffs2/libyaffs2.o > lib/libfdt/libfdt.o lib/libgeneric.o lib/lzma/liblzma.o lib/lzo/liblzo.o > lib/zlib/libz.o net/libnet.o post/libpost.o > board/technexion/twister/libtwister.o --end-group > /home/uboot/src/u-boot-arm/arch/arm/lib/eabi_compat.o -L > /usr/lib/gcc/arm-linux-gnueabi/4.6.1 -lgcc -Map u-boot.map -o u-boot >> >> make: *** [u-boot] Erreur 139 >> make: *** Attente des tâches non terminées >> arm-linux-gnueabi-size: ./u-boot: File format not recognized >> >> - SUMMARY >> Boards compiled: 1 >> Boards with warnings or errors: 1 ( twister ) >> -- > > > The above was tried on 10a4fa9e22b9677819b3901a87eec05875b346ad (the current > u-boot-arm/master, but trying various commits in between it and > 92e30c07e02b84a3b63205fcb29ac57defd043f6 (creation of twister), I find no > commit where it builds. > > Stefano, can you have a look at this? So what happened is I accidentally put this board into u-boot-ti/next a while back, before the USB changes went in, without realizing it. The reason the USB changes haven't gone in, still, is that they've been made more generic (as the IP block is shared between these boards and omap4/5). For that part of the problem perhaps we should turn off the USB portion of the board for now? -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
Le 14/01/2012 11:15, Stefano Babic a écrit : On 14/01/2012 11:06, Albert ARIBAUD wrote: Board then compiles but with warnings for 4 declared but unused symbols. I see also the warnings, they are related to a couple of drivers (NAND). They need a clean-up patch to fix them. Considering that all it does is adding a new EHCI driver, the worst impact it can have is to not function properly for boards using it, which at the moment means omap3_beagle and tam3517; but it won't affect USB on existing boards. But then I wonder why twister needs it at all, as it does not have a single USB config option in its header config file... Well, that is not true... I can at least sent my tested-by - it was nice if you can pick it up. *If* someone can explain to me why a patch that adds a new USB EHCI driver is needed by a board which does not have any "USB" in its config header file, I can explain this. The twister board is based on the Technexion TAM3517 SOM. There is a common configuration files for all boards (I have also added a second one) using this module with the TI AM3517 SOC: include/configs/tam3517-common.h Because pins for USB are fixed on the SOM, the USB configuration is made common to all boards. In tam3517-common.h you can find: /* EHCI */ #define CONFIG_OMAP3_GPIO_5 #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_OMAP #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO25 #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 #define CONFIG_USB_STORAGE Ok, got it. I had only read the twister entry in boards.cfg and thus I thought twister was 'simple' omap3. So that leaves this: and *unless Wolfgang says otherwise*, ..added Wolfgang in CC Oops. Thanks. :) Best regards, Stefano Babic Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
On 14/01/2012 11:06, Albert ARIBAUD wrote: > > Board then compiles but with warnings for 4 declared but unused symbols. I see also the warnings, they are related to a couple of drivers (NAND). They need a clean-up patch to fix them. > Considering that all it does is adding a new EHCI driver, the worst > impact it can have is to not function properly for boards using it, > which at the moment means omap3_beagle and tam3517; but it won't affect > USB on existing boards. > > But then I wonder why twister needs it at all, as it does not have a > single USB config option in its header config file... Well, that is not true... > >> I can at least sent my tested-by - it was nice if you can pick it up. > > *If* someone can explain to me why a patch that adds a new USB EHCI > driver is needed by a board which does not have any "USB" in its config > header file, I can explain this. The twister board is based on the Technexion TAM3517 SOM. There is a common configuration files for all boards (I have also added a second one) using this module with the TI AM3517 SOC: include/configs/tam3517-common.h Because pins for USB are fixed on the SOM, the USB configuration is made common to all boards. In tam3517-common.h you can find: /* EHCI */ #define CONFIG_OMAP3_GPIO_5 #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_OMAP #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO25 #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 #define CONFIG_USB_STORAGE > and *unless Wolfgang says otherwise*, ..added Wolfgang in CC Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
Hi Stefano, Le 14/01/2012 10:48, Stefano Babic a écrit : On 14/01/2012 09:47, Albert ARIBAUD wrote: (re-sent due to the U-Boot MX rejecting my provider's servers -- again) Hi Stefano, Hi Albert, hi Tom, drivers/usb/host/libusb_host.o: In function `usb_lowlevel_init': /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:814: undefined reference to `ehci_hcd_init' The twister board depends on several patches for the AM3517 processor previously senty by Ilya Yanok. One of them (maybe because it is USB related and should go into u-boot-usb) is missing. http://patchwork.ozlabs.org/patch/130952/ Board then compiles but with warnings for 4 declared but unused symbols. The patch is set to new and assigned to Remy, but he gived up as maintainer - nobody checks at it ;-(. Considering that all it does is adding a new EHCI driver, the worst impact it can have is to not function properly for boards using it, which at the moment means omap3_beagle and tam3517; but it won't affect USB on existing boards. But then I wonder why twister needs it at all, as it does not have a single USB config option in its header config file... I can at least sent my tested-by - it was nice if you can pick it up. *If* someone can explain to me why a patch that adds a new USB EHCI driver is needed by a board which does not have any "USB" in its config header file, and *unless Wolfgang says otherwise*, I agree to accept patch 130952 with your Tested-By. Best regards, Stefano Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
On 14/01/2012 09:47, Albert ARIBAUD wrote: > (re-sent due to the U-Boot MX rejecting my provider's servers -- again) > > Hi Stefano, > Hi Albert, hi Tom, >> drivers/usb/host/libusb_host.o: In function `usb_lowlevel_init': >> /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:814: undefined >> reference to `ehci_hcd_init' The twister board depends on several patches for the AM3517 processor previously senty by Ilya Yanok. One of them (maybe because it is USB related and should go into u-boot-usb) is missing. http://patchwork.ozlabs.org/patch/130952/ The patch is set to new and assigned to Remy, but he gived up as maintainer - nobody checks at it ;-(. I can at least sent my tested-by - it was nice if you can pick it up. Best regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board
(re-sent due to the U-Boot MX rejecting my provider's servers -- again) Hi Stefano, Le 01/12/2011 10:56, Stefano Babic a écrit : The twister board is a development board using the TAM3517 SOM. I see this match made it in IMX then ARM, but it seems not to build here either with ELDK 4.2 or linaro (Ubuntu) cross tool chains: Configuring for twister board... omap_gpmc.c:33:30: attention : ‘hw_nand_oob’ defined but not used [-Wunused-variable] omap_gpmc.c:78:13: attention : ‘omap_hwecc_init’ defined but not used [-Wunused-function] omap_gpmc.c:116:12: attention : ‘omap_correct_data’ defined but not used [-Wunused-function] omap_gpmc.c:182:12: attention : ‘omap_calculate_ecc’ defined but not used [-Wunused-function] omap_gpmc.c:208:13: attention : ‘omap_enable_hwecc’ defined but not used [-Wunused-function] drivers/usb/host/libusb_host.o: In function `usb_lowlevel_stop': /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:806: undefined reference to `ehci_hcd_stop' drivers/usb/host/libusb_host.o: In function `usb_lowlevel_init': /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:814: undefined reference to `ehci_hcd_init' arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 assertion fail ../../bfd/elf32-arm.c:7498 arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 assertion fail ../../bfd/elf32-arm.c:7498 arm-linux-gnueabi-ld: BFD (GNU Binutils for Ubuntu) 2.21.53.20110810 assertion fail ../../bfd/elf32-arm.c:13828 /bin/sh : ligne 1 : 23855 Erreur de segmentation arm-linux-gnueabi-ld -pie -T u-boot.lds -Bstatic -Ttext 0x80008000 $UNDEF_SYM arch/arm/cpu/armv7/start.o --start-group api/libapi.o arch/arm/cpu/armv7/libarmv7.o arch/arm/cpu/armv7/omap-common/libomap-common.o arch/arm/cpu/armv7/omap3/libomap3.o arch/arm/lib/libarm.o common/libcommon.o disk/libdisk.o drivers/bios_emulator/libatibiosemu.o drivers/block/libblock.o drivers/dma/libdma.o drivers/fpga/libfpga.o drivers/gpio/libgpio.o drivers/hwmon/libhwmon.o drivers/i2c/libi2c.o drivers/input/libinput.o drivers/misc/libmisc.o drivers/mmc/libmmc.o drivers/mtd/libmtd.o drivers/mtd/nand/libnand.o drivers/mtd/onenand/libonenand.o drivers/mtd/spi/libspi_flash.o drivers/mtd/ubi/libubi.o drivers/net/libnet.o drivers/net/phy/libphy.o drivers/pci/libpci.o drivers/pcmcia/libpcmcia.o drivers/power/libpower.o drivers/rtc/librtc.o drivers/serial/libserial.o drivers/spi/libspi.o drivers/twserial/libtws.o drivers/usb/eth/libusb_eth.o drivers/usb /gadget/libusb_gadget.o drivers/usb/host/libusb_host.o drivers/usb/musb/libusb_musb.o drivers/usb/phy/libusb_phy.o drivers/usb/ulpi/libusb_ulpi.o drivers/video/libvideo.o drivers/watchdog/libwatchdog.o fs/cramfs/libcramfs.o fs/ext2/libext2fs.o fs/fat/libfat.o fs/fdos/libfdos.o fs/jffs2/libjffs2.o fs/reiserfs/libreiserfs.o fs/ubifs/libubifs.o fs/yaffs2/libyaffs2.o lib/libfdt/libfdt.o lib/libgeneric.o lib/lzma/liblzma.o lib/lzo/liblzo.o lib/zlib/libz.o net/libnet.o post/libpost.o board/technexion/twister/libtwister.o --end-group /home/uboot/src/u-boot-arm/arch/arm/lib/eabi_compat.o -L /usr/lib/gcc/arm-linux-gnueabi/4.6.1 -lgcc -Map u-boot.map -o u-boot make: *** [u-boot] Erreur 139 make: *** Attente des tâches non terminées arm-linux-gnueabi-size: ./u-boot: File format not recognized - SUMMARY Boards compiled: 1 Boards with warnings or errors: 1 ( twister ) -- The above was tried on 10a4fa9e22b9677819b3901a87eec05875b346ad (the current u-boot-arm/master, but trying various commits in between it and 92e30c07e02b84a3b63205fcb29ac57defd043f6 (creation of twister), I find no commit where it builds. Stefano, can you have a look at this? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot