Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
On Thu, Jul 18, 2013 at 11:13 AM, Tom Rini wrote: > > Yes, I'm not terribly happy with what gets done for the shipping U-Boot > on BBB, but I understand you're trying to not have too special of a > binary used in programming versus distribution of the board. If the > vendor wants to ship software that says "when in doubt, it's likely this > board", that's OK for the vendor to do. Alrite, so we go with V3(current version) of the patch then. Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
On Mon, Jul 15, 2013 at 04:52:51PM +0200, Koen Kooi wrote:
>
> Op 15 jul. 2013, om 16:49 heeft Tom Rini het volgende
> geschreven:
>
> > On Mon, Jul 15, 2013 at 02:16:50PM +0200, Koen Kooi wrote:
> >>
> >> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
> >> geschreven:
> >>
> >>> For folks not using concatenated device tree with uImage, having
> >>> an handy function to find and load device tree is very handy.
> >>>
> >>> So introduce findfdt and loadfdt and run findfdt by default to make
> >>> it easier on user scripts.
> >>>
> >>> Signed-off-by: Nishanth Menon
> >>> ---
> >>> V3: Fixes typo mistake reported in
> >>> http://marc.info/?t=13735821236&r=1&w=2
> >>>
> >>> include/configs/omap3_beagle.h | 15 +++
> >>> 1 file changed, 15 insertions(+)
> >>>
> >>> diff --git a/include/configs/omap3_beagle.h
> >>> b/include/configs/omap3_beagle.h
> >>> index bdeee17..5ec8ade 100644
> >>> --- a/include/configs/omap3_beagle.h
> >>> +++ b/include/configs/omap3_beagle.h
> >>> @@ -210,6 +210,8 @@
> >>> #define CONFIG_EXTRA_ENV_SETTINGS \
> >>> "loadaddr=0x8020\0" \
> >>> "rdaddr=0x8100\0" \
> >>> + "fdt_high=0x\0" \
> >>> + "fdtaddr=0x80f8\0" \
> >>> "usbtty=cdc_acm\0" \
> >>> "bootfile=uImage\0" \
> >>> "ramdisk=ramdisk.gz\0" \
> >>> @@ -250,6 +252,17 @@
> >>> "omapdss.def_disp=${defaultdisplay} " \
> >>> "root=${nandroot} " \
> >>> "rootfstype=${nandrootfstype}\0" \
> >>> + "findfdt=" \
> >>> + "if test $beaglerev = AxBx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = Cx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = xMAB; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $beaglerev = xMC; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $fdtfile = undefined; then " \
> >>> + "echo WARNING: Could not determine device tree to use;
> >>> fi; \0" \
> >>
> >> With the remote chance of a future xM rev D, can you make the
> >> fallthrough be 'omap3-beagle-xm.dtb' intead of 'undefined'?
> >
> > I don't like that idea. On am335x_evm configs we have undefined and
> > then say "hey, it's undefined!" so it's clear that we don't know what to
> > do. That in theory future xM rev D might need a different device tree
> > for example.
>
> And that's patched out on the build that actually ships with the
> beaglebone and beaglebone black so it will fall back to BBB when it
> can't ID the board. You'll see that the u-boot bits that need the ID
> for the xM also fallback to the latest rev. I don't see why the
> boardfile and script need to have different behaviour.
Yes, I'm not terribly happy with what gets done for the shipping U-Boot
on BBB, but I understand you're trying to not have too special of a
binary used in programming versus distribution of the board. If the
vendor wants to ship software that says "when in doubt, it's likely this
board", that's OK for the vendor to do.
--
Tom
signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
Op 15 jul. 2013, om 16:49 heeft Tom Rini het volgende geschreven:
> On Mon, Jul 15, 2013 at 02:16:50PM +0200, Koen Kooi wrote:
>>
>> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
>> geschreven:
>>
>>> For folks not using concatenated device tree with uImage, having
>>> an handy function to find and load device tree is very handy.
>>>
>>> So introduce findfdt and loadfdt and run findfdt by default to make
>>> it easier on user scripts.
>>>
>>> Signed-off-by: Nishanth Menon
>>> ---
>>> V3: Fixes typo mistake reported in
>>> http://marc.info/?t=13735821236&r=1&w=2
>>>
>>> include/configs/omap3_beagle.h | 15 +++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>>> index bdeee17..5ec8ade 100644
>>> --- a/include/configs/omap3_beagle.h
>>> +++ b/include/configs/omap3_beagle.h
>>> @@ -210,6 +210,8 @@
>>> #define CONFIG_EXTRA_ENV_SETTINGS \
>>> "loadaddr=0x8020\0" \
>>> "rdaddr=0x8100\0" \
>>> + "fdt_high=0x\0" \
>>> + "fdtaddr=0x80f8\0" \
>>> "usbtty=cdc_acm\0" \
>>> "bootfile=uImage\0" \
>>> "ramdisk=ramdisk.gz\0" \
>>> @@ -250,6 +252,17 @@
>>> "omapdss.def_disp=${defaultdisplay} " \
>>> "root=${nandroot} " \
>>> "rootfstype=${nandrootfstype}\0" \
>>> + "findfdt=" \
>>> + "if test $beaglerev = AxBx; then " \
>>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
>>> + "if test $beaglerev = Cx; then " \
>>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
>>> + "if test $beaglerev = xMAB; then " \
>>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
>>> + "if test $beaglerev = xMC; then " \
>>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
>>> + "if test $fdtfile = undefined; then " \
>>> + "echo WARNING: Could not determine device tree to use;
>>> fi; \0" \
>>
>> With the remote chance of a future xM rev D, can you make the
>> fallthrough be 'omap3-beagle-xm.dtb' intead of 'undefined'?
>
> I don't like that idea. On am335x_evm configs we have undefined and
> then say "hey, it's undefined!" so it's clear that we don't know what to
> do. That in theory future xM rev D might need a different device tree
> for example.
And that's patched out on the build that actually ships with the beaglebone and
beaglebone black so it will fall back to BBB when it can't ID the board. You'll
see that the u-boot bits that need the ID for the xM also fallback to the
latest rev. I don't see why the boardfile and script need to have different
behaviour.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
On Mon, Jul 15, 2013 at 02:16:50PM +0200, Koen Kooi wrote:
>
> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
> geschreven:
>
> > For folks not using concatenated device tree with uImage, having
> > an handy function to find and load device tree is very handy.
> >
> > So introduce findfdt and loadfdt and run findfdt by default to make
> > it easier on user scripts.
> >
> > Signed-off-by: Nishanth Menon
> > ---
> > V3: Fixes typo mistake reported in
> > http://marc.info/?t=13735821236&r=1&w=2
> >
> > include/configs/omap3_beagle.h | 15 +++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index bdeee17..5ec8ade 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -210,6 +210,8 @@
> > #define CONFIG_EXTRA_ENV_SETTINGS \
> > "loadaddr=0x8020\0" \
> > "rdaddr=0x8100\0" \
> > + "fdt_high=0x\0" \
> > + "fdtaddr=0x80f8\0" \
> > "usbtty=cdc_acm\0" \
> > "bootfile=uImage\0" \
> > "ramdisk=ramdisk.gz\0" \
> > @@ -250,6 +252,17 @@
> > "omapdss.def_disp=${defaultdisplay} " \
> > "root=${nandroot} " \
> > "rootfstype=${nandrootfstype}\0" \
> > + "findfdt=" \
> > + "if test $beaglerev = AxBx; then " \
> > + "setenv fdtfile omap3-beagle.dtb; fi; " \
> > + "if test $beaglerev = Cx; then " \
> > + "setenv fdtfile omap3-beagle.dtb; fi; " \
> > + "if test $beaglerev = xMAB; then " \
> > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> > + "if test $beaglerev = xMC; then " \
> > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> > + "if test $fdtfile = undefined; then " \
> > + "echo WARNING: Could not determine device tree to use;
> > fi; \0" \
>
> With the remote chance of a future xM rev D, can you make the
> fallthrough be 'omap3-beagle-xm.dtb' intead of 'undefined'?
I don't like that idea. On am335x_evm configs we have undefined and
then say "hey, it's undefined!" so it's clear that we don't know what to
do. That in theory future xM rev D might need a different device tree
for example.
--
Tom
signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
On 15:07-20130715, Koen Kooi wrote:
> Op 15 jul. 2013, om 14:25 heeft Nishanth Menon het volgende
> geschreven:
> > On 14:16-20130715, Koen Kooi wrote:
> >> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
> >> geschreven:
> >>
[..]
> >>> + "findfdt=" \
> >>> + "if test $beaglerev = AxBx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = Cx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = xMAB; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $beaglerev = xMC; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $fdtfile = undefined; then " \
> >>> + "echo WARNING: Could not determine device tree to use;
> >>> fi; \0" \
> >>
> >> With the remote chance of a future xM rev D, can you make the fallthrough
> >> be 'omap3-beagle-xm.dtb' intead of 'undefined'?
> > Lets add the detection of xMD and along with that we add
> > omap3-beagle-xm.dtb detection - makes sense? OR do we assume all
> > un-matched devices default to beagle xMD? what if there was a vanilla
> > beagle rev D?
>
> The fallthrough case should always be the most recent board rev, any other
> way will just make the HW guys spoof the ID in the design and we all know how
> that ends :(
Fair enough. Anyone else has a contrary opinion?
If none, the following is the replacement patch, wont repost unless a new series
is needed:
>From 07e1787cc59f4622c764d7da33da2684cf122d41 Mon Sep 17 00:00:00 2001
From: Nishanth Menon
Date: Thu, 11 Jul 2013 16:25:09 -0500
Subject: [PATCH V4] omap3_beagle: support findfdt and loadfdt for devicetree
support
For folks not using concatenated device tree with uImage, having
an handy function to find and load device tree is very handy.
So introduce findfdt and loadfdt and run findfdt by default to make
it easier on user scripts.
Signed-off-by: Nishanth Menon
---
include/configs/omap3_beagle.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index bdeee17..7e6e38c 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -210,6 +210,8 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
"loadaddr=0x8020\0" \
"rdaddr=0x8100\0" \
+ "fdt_high=0x\0" \
+ "fdtaddr=0x80f8\0" \
"usbtty=cdc_acm\0" \
"bootfile=uImage\0" \
"ramdisk=ramdisk.gz\0" \
@@ -250,6 +252,20 @@
"omapdss.def_disp=${defaultdisplay} " \
"root=${nandroot} " \
"rootfstype=${nandrootfstype}\0" \
+ "findfdt=" \
+ "if test $beaglerev = AxBx; then " \
+ "setenv fdtfile omap3-beagle.dtb; fi; " \
+ "if test $beaglerev = Cx; then " \
+ "setenv fdtfile omap3-beagle.dtb; fi; " \
+ "if test $beaglerev = xMAB; then " \
+ "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
+ "if test $beaglerev = xMC; then " \
+ "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
+ "if test $fdtfile = undefined; then " \
+ "setenv fdtfile omap3-beagle-xm.dtb;" \
+ "echo WARNING: Could not determine device tree to use;"
\
+ "echo WARNING: assuming ${fdtfile};" \
+ "fi; \0" \
"bootenv=uEnv.txt\0" \
"loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenv}\0" \
"importbootenv=echo Importing environment from mmc ...; " \
@@ -265,6 +281,7 @@
"rootfstype=${ramrootfstype}\0" \
"loadramdisk=load mmc ${bootpart} ${rdaddr} ${bootdir}/${ramdisk}\0" \
"loadimage=load mmc ${bootpart} ${loadaddr} ${bootdir}/${bootfile}\0" \
+ "loadfdt=load mmc ${bootpart} ${fdtaddr} ${bootdir}/${fdtfile}\0" \
"mmcboot=echo Booting from mmc ...; " \
"run mmcargs; " \
"bootm ${loadaddr}\0" \
@@ -281,6 +298,7 @@
"userbutton_nonxm=gpio input 7;\0"
/* "run userbutton" will return 1 (false) if pressed and 0 (true) if not */
#define CONFIG_BOOTCOMMAND \
+ "run findfdt; " \
"mmc dev ${mmcdev}; if mmc rescan; then " \
"if run userbutton; then " \
"setenv bootenv uEnv.txt;" \
--
1.7.9.5
--
Regards,
Nishanth Menon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
Op 15 jul. 2013, om 14:25 heeft Nishanth Menon het volgende
geschreven:
> On 14:16-20130715, Koen Kooi wrote:
>>
>> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
>> geschreven:
>>
>>> For folks not using concatenated device tree with uImage, having
>>> an handy function to find and load device tree is very handy.
>>>
>>> So introduce findfdt and loadfdt and run findfdt by default to make
>>> it easier on user scripts.
>>>
>>> Signed-off-by: Nishanth Menon
>>> ---
>>> V3: Fixes typo mistake reported in
>>> http://marc.info/?t=13735821236&r=1&w=2
>>>
>>> include/configs/omap3_beagle.h | 15 +++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>>> index bdeee17..5ec8ade 100644
>>> --- a/include/configs/omap3_beagle.h
>>> +++ b/include/configs/omap3_beagle.h
>>> @@ -210,6 +210,8 @@
>>> #define CONFIG_EXTRA_ENV_SETTINGS \
>>> "loadaddr=0x8020\0" \
>>> "rdaddr=0x8100\0" \
>>> + "fdt_high=0x\0" \
>>> + "fdtaddr=0x80f8\0" \
>>> "usbtty=cdc_acm\0" \
>>> "bootfile=uImage\0" \
>>> "ramdisk=ramdisk.gz\0" \
>>> @@ -250,6 +252,17 @@
>>> "omapdss.def_disp=${defaultdisplay} " \
>>> "root=${nandroot} " \
>>> "rootfstype=${nandrootfstype}\0" \
>>> + "findfdt=" \
>>> + "if test $beaglerev = AxBx; then " \
>>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
>>> + "if test $beaglerev = Cx; then " \
>>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
>>> + "if test $beaglerev = xMAB; then " \
>>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
>>> + "if test $beaglerev = xMC; then " \
>>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
>>> + "if test $fdtfile = undefined; then " \
>>> + "echo WARNING: Could not determine device tree to use;
>>> fi; \0" \
>>
>> With the remote chance of a future xM rev D, can you make the fallthrough be
>> 'omap3-beagle-xm.dtb' intead of 'undefined'?
> Lets add the detection of xMD and along with that we add
> omap3-beagle-xm.dtb detection - makes sense? OR do we assume all
> un-matched devices default to beagle xMD? what if there was a vanilla
> beagle rev D?
The fallthrough case should always be the most recent board rev, any other way
will just make the HW guys spoof the ID in the design and we all know how that
ends :(
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
On 14:16-20130715, Koen Kooi wrote:
>
> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
> geschreven:
>
> > For folks not using concatenated device tree with uImage, having
> > an handy function to find and load device tree is very handy.
> >
> > So introduce findfdt and loadfdt and run findfdt by default to make
> > it easier on user scripts.
> >
> > Signed-off-by: Nishanth Menon
> > ---
> > V3: Fixes typo mistake reported in
> > http://marc.info/?t=13735821236&r=1&w=2
> >
> > include/configs/omap3_beagle.h | 15 +++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index bdeee17..5ec8ade 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -210,6 +210,8 @@
> > #define CONFIG_EXTRA_ENV_SETTINGS \
> > "loadaddr=0x8020\0" \
> > "rdaddr=0x8100\0" \
> > + "fdt_high=0x\0" \
> > + "fdtaddr=0x80f8\0" \
> > "usbtty=cdc_acm\0" \
> > "bootfile=uImage\0" \
> > "ramdisk=ramdisk.gz\0" \
> > @@ -250,6 +252,17 @@
> > "omapdss.def_disp=${defaultdisplay} " \
> > "root=${nandroot} " \
> > "rootfstype=${nandrootfstype}\0" \
> > + "findfdt=" \
> > + "if test $beaglerev = AxBx; then " \
> > + "setenv fdtfile omap3-beagle.dtb; fi; " \
> > + "if test $beaglerev = Cx; then " \
> > + "setenv fdtfile omap3-beagle.dtb; fi; " \
> > + "if test $beaglerev = xMAB; then " \
> > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> > + "if test $beaglerev = xMC; then " \
> > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> > + "if test $fdtfile = undefined; then " \
> > + "echo WARNING: Could not determine device tree to use;
> > fi; \0" \
>
> With the remote chance of a future xM rev D, can you make the fallthrough be
> 'omap3-beagle-xm.dtb' intead of 'undefined'?
Lets add the detection of xMD and along with that we add
omap3-beagle-xm.dtb detection - makes sense? OR do we assume all
un-matched devices default to beagle xMD? what if there was a vanilla
beagle rev D?
--
Regards,
Nishanth Menon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende
geschreven:
> For folks not using concatenated device tree with uImage, having
> an handy function to find and load device tree is very handy.
>
> So introduce findfdt and loadfdt and run findfdt by default to make
> it easier on user scripts.
>
> Signed-off-by: Nishanth Menon
> ---
> V3: Fixes typo mistake reported in http://marc.info/?t=13735821236&r=1&w=2
>
> include/configs/omap3_beagle.h | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index bdeee17..5ec8ade 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -210,6 +210,8 @@
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "loadaddr=0x8020\0" \
> "rdaddr=0x8100\0" \
> + "fdt_high=0x\0" \
> + "fdtaddr=0x80f8\0" \
> "usbtty=cdc_acm\0" \
> "bootfile=uImage\0" \
> "ramdisk=ramdisk.gz\0" \
> @@ -250,6 +252,17 @@
> "omapdss.def_disp=${defaultdisplay} " \
> "root=${nandroot} " \
> "rootfstype=${nandrootfstype}\0" \
> + "findfdt=" \
> + "if test $beaglerev = AxBx; then " \
> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> + "if test $beaglerev = Cx; then " \
> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> + "if test $beaglerev = xMAB; then " \
> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> + "if test $beaglerev = xMC; then " \
> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> + "if test $fdtfile = undefined; then " \
> + "echo WARNING: Could not determine device tree to use;
> fi; \0" \
With the remote chance of a future xM rev D, can you make the fallthrough be
'omap3-beagle-xm.dtb' intead of 'undefined'?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
