Re: [U-Boot] [PATCH V4 1/5] mv: seperate kirkwood and armada from common setting
Hi Wolfgang, On Wed, Jan 19, 2011 at 5:48 AM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message <1294754710-7834-2-git-send-email-lei...@marvell.com> you wrote: >> Since there are lots of difference between kirkwood and armada series, >> it is better to seperate them but still keep the most common file >> shared by all marvell platform in the mv-common configure file. >> >> This patch move the kirkwood only driver definitoin in mv-common to >> the /config.h. >> >> This patch is tested with compilation for armada100 and guruplug. >> >> Signed-off-by: Lei Wen > ... >> +#ifdef CONFIG_SYS_MVFS > > Is this a new CONFIG_SYS_* ? Please document it (in the README). > Same for all other new CONFIG_* or CONFIG_SYS_*, please. > I would post another patch set to fix the issues you mentioned... Best regards, Lei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V4 1/5] mv: seperate kirkwood and armada from common setting
Dear Lei Wen, In message <1294754710-7834-2-git-send-email-lei...@marvell.com> you wrote: > Since there are lots of difference between kirkwood and armada series, > it is better to seperate them but still keep the most common file > shared by all marvell platform in the mv-common configure file. > > This patch move the kirkwood only driver definitoin in mv-common to > the /config.h. > > This patch is tested with compilation for armada100 and guruplug. > > Signed-off-by: Lei Wen ... > +#ifdef CONFIG_SYS_MVFS Is this a new CONFIG_SYS_* ? Please document it (in the README). Same for all other new CONFIG_* or CONFIG_SYS_*, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How can you tell when sour cream goes bad? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
